thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong intent in exception message

Browse Source
This commit is contained in:
Alexey Milovidov 2021-05-23 03:30:17 +03:00
parent e000b994e5
commit ecc2e98265
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Compression/CompressionFactory.cpp
View File

@ -78,7 +78,8 @@ void CompressionCodecFactory::validateCodec(const String & family_name, std::opt
} }
} }
ASTPtr CompressionCodecFactory::validateCodecAndGetPreprocessedAST(const ASTPtr & ast, const IDataType * column_type, bool sanity_check, bool allow_experimental_codecs) const ASTPtr CompressionCodecFactory::validateCodecAndGetPreprocessedAST(
const ASTPtr & ast, const IDataType * column_type, bool sanity_check, bool allow_experimental_codecs) const
{ {
if (const auto * func = ast->as<ASTFunction>()) if (const auto * func = ast->as<ASTFunction>())
{ {
@ -107,16 +108,21 @@ ASTPtr CompressionCodecFactory::validateCodecAndGetPreprocessedAST(const ASTPtr
else else
throw Exception("Unexpected AST element for compression codec", ErrorCodes::UNEXPECTED_AST_STRUCTURE); throw Exception("Unexpected AST element for compression codec", ErrorCodes::UNEXPECTED_AST_STRUCTURE);
if (sanity_check && !allow_experimental_codecs) { if (!allow_experimental_codecs)
if (codec_family_name == "Lizard" || {
if (codec_family_name == "Lizard" ||
codec_family_name == "Density" || codec_family_name == "Density" ||
codec_family_name == "LZSSE2" || codec_family_name == "LZSSE2" ||
codec_family_name == "LZSSE4" || codec_family_name == "LZSSE4" ||
codec_family_name == "LZSSE8") { codec_family_name == "LZSSE8")
{
throw Exception(ErrorCodes::BAD_ARGUMENTS, throw Exception(ErrorCodes::BAD_ARGUMENTS,
"Experimental codecs Lizard, Density and LZSSE* are not allowed, please enable allow_experimental_codecs flag."); "Codec {} is experimental and not meant to be used in production."
" You can enable it with the 'allow_experimental_codecs' setting.",
codec_family_name);
} }
} }
/// Default codec replaced with current default codec which may depend on different /// Default codec replaced with current default codec which may depend on different
/// settings (and properties of data) in runtime. /// settings (and properties of data) in runtime.
CompressionCodecPtr result_codec; CompressionCodecPtr result_codec;