From ed64f2ad67fc0702ca05e24d005dcbf599b6a92a Mon Sep 17 00:00:00 2001
From: Azat Khuzhin <a3at.mail@gmail.com>
Date: Sat, 14 Nov 2020 14:22:21 +0300
Subject: [PATCH] Add a test for Distributed query finish does not produce any
 NETWORK_ERROR

---
 docker/test/fasttest/run.sh                   |  2 ++
 .../01563_distributed_query_finish.reference  |  2 ++
 .../01563_distributed_query_finish.sh         | 33 +++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 tests/queries/0_stateless/01563_distributed_query_finish.reference
 create mode 100755 tests/queries/0_stateless/01563_distributed_query_finish.sh

diff --git a/docker/test/fasttest/run.sh b/docker/test/fasttest/run.sh
index ab1da5aeb33..aef967b6b41 100755
--- a/docker/test/fasttest/run.sh
+++ b/docker/test/fasttest/run.sh
@@ -287,6 +287,8 @@ TESTS_TO_SKIP=(
     01322_ttest_scipy
 
     01545_system_errors
+    # Checks system.errors
+    01563_distributed_query_finish
 )
 
 time clickhouse-test -j 8 --order=random --no-long --testname --shard --zookeeper --skip "${TESTS_TO_SKIP[@]}" 2>&1 | ts '%Y-%m-%d %H:%M:%S' | tee "$FASTTEST_OUTPUT/test_log.txt"
diff --git a/tests/queries/0_stateless/01563_distributed_query_finish.reference b/tests/queries/0_stateless/01563_distributed_query_finish.reference
new file mode 100644
index 00000000000..c3688b553c4
--- /dev/null
+++ b/tests/queries/0_stateless/01563_distributed_query_finish.reference
@@ -0,0 +1,2 @@
+1,0
+NETWORK_ERROR=0
diff --git a/tests/queries/0_stateless/01563_distributed_query_finish.sh b/tests/queries/0_stateless/01563_distributed_query_finish.sh
new file mode 100755
index 00000000000..8189025a4b9
--- /dev/null
+++ b/tests/queries/0_stateless/01563_distributed_query_finish.sh
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+# query finish should not produce any NETWORK_ERROR
+# (NETWORK_ERROR will be in case of connection reset)
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+. "$CURDIR"/../shell_config.sh
+
+$CLICKHOUSE_CLIENT -nm <<EOL
+drop table if exists dist_01247;
+drop table if exists data_01247;
+
+create table data_01247 engine=Memory() as select * from numbers(2);
+create table dist_01247 as data_01247 engine=Distributed(test_cluster_two_shards, currentDatabase(), data_01247, number);
+
+select * from dist_01247 format Null;
+EOL
+
+network_errors_before=$($CLICKHOUSE_CLIENT -q "SELECT value FROM system.errors WHERE name = 'NETWORK_ERROR'")
+
+opts=(
+    "--max_distributed_connections=1"
+    "--optimize_skip_unused_shards=1"
+    "--optimize_distributed_group_by_sharding_key=1"
+    "--prefer_localhost_replica=0"
+)
+$CLICKHOUSE_CLIENT "${opts[@]}" --format CSV -nm <<EOL
+select count(), * from dist_01247 group by number limit 1;
+EOL
+
+# expect zero new network errors
+network_errors_after=$($CLICKHOUSE_CLIENT -q "SELECT value FROM system.errors WHERE name = 'NETWORK_ERROR'")
+echo NETWORK_ERROR=$(( network_errors_after-network_errors_before ))