thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-29 13:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review fixes.

Browse Source
This commit is contained in:
Vladimir Chebotarev 2020-07-23 01:05:45 +03:00
parent 8039d45910
commit ee21fde3fe
5 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Disks/IVolume.cpp
View File

@ -81,9 +81,9 @@ Disks MultiDiskReservation::getDisks() const
{
Disks res;
res.reserve(reservations.size());
for (const auto &r: reservations)
for (const auto & reservation : reservations)
{
res.push_back(r->getDisk());
res.push_back(reservation->getDisk());
}
return res;
}

3
src/Disks/VolumeJBOD.cpp
View File

@ -64,7 +64,8 @@ DiskPtr VolumeJBOD::getNextDisk()
ReservationPtr VolumeJBOD::reserve(UInt64 bytes)
{
/// This volume can not store files which size greater than max_data_part_size
/// This volume can not store data which size is greater than `max_data_part_size`
/// to ensure that parts of size greater than that go to another volume(s).
if (max_data_part_size != 0 && bytes > max_data_part_size)
return {};

3
src/Disks/VolumeRAID1.cpp
View File

@ -8,7 +8,8 @@ namespace DB
ReservationPtr VolumeRAID1::reserve(UInt64 bytes)
{
/// This volume can not store files which size greater than max_data_part_size
/// This volume can not store data which size is greater than `max_data_part_size`
/// to ensure that parts of size greater than that go to another volume(s).
if (max_data_part_size != 0 && bytes > max_data_part_size)
return {};

1
src/Disks/VolumeRAID1.h
View File

@ -8,7 +8,6 @@ namespace DB
class VolumeRAID1 : public VolumeJBOD
{
friend VolumePtr createVolumeFromReservation(const ReservationPtr & reservation, VolumePtr other_volume);
public:
VolumeRAID1(String name_, Disks disks_, UInt64 max_data_part_size_)
: VolumeJBOD(name_, disks_, max_data_part_size_)