thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-14 18:32:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Remove debug code

Browse Source
This commit is contained in:
Sergey Skvortsov 2022-06-17 20:55:53 +03:00
parent f77f8201aa
commit ee22101005
2 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Interpreters/GraceHashJoin.cpp
View File

@ -244,25 +244,6 @@ void GraceHashJoin::rehashInMemoryJoin(InMemoryJoinPtr & join, const BucketsSnap
} }
} }
bool GraceHashJoin::checkBlock(std::string_view desc, const Block & block, size_t bucket)
{
const auto & column = block.getByPosition(0);
bool found = false;
if (isUInt64(column.type))
{
for (size_t i = 0; i < column.column->size(); ++i)
{
UInt64 value = column.column->getUInt(i);
if (value == 798)
{
LOG_INFO(log, "{}: Found matching value {} at bucket {}:{}, column {}", desc, value, bucket, i, column.name);
found = true;
}
}
}
return found;
}
bool GraceHashJoin::fitsInMemory(InMemoryJoin * join) const bool GraceHashJoin::fitsInMemory(InMemoryJoin * join) const
{ {
return table_join->sizeLimits().softCheck(join->getTotalRowCount(), join->getTotalByteCount()); return table_join->sizeLimits().softCheck(join->getTotalRowCount(), join->getTotalByteCount());
@ -510,7 +491,6 @@ void GraceHashJoin::fillInMemoryJoin(InMemoryJoinPtr & join, FileBucket * bucket
while (auto block = reader.read()) while (auto block = reader.read())
{ {
checkBlock("fillInMemoryJoin", block, bucket->index());
addJoinedBlockImpl(join, bucket->index(), block); addJoinedBlockImpl(join, bucket->index(), block);
} }
} }
@ -520,7 +500,6 @@ void GraceHashJoin::addJoinedBlockImpl(InMemoryJoinPtr & join, size_t bucket_ind
BucketsSnapshot snapshot = buckets.get(); BucketsSnapshot snapshot = buckets.get();
Blocks blocks = scatterBlock<true>(block, snapshot->size()); Blocks blocks = scatterBlock<true>(block, snapshot->size());
checkBlock("addJoinedBlockImpl:inmemory", blocks[bucket_index], bucket_index);
join->addJoinedBlock(blocks[bucket_index], /*check_limits=*/false); join->addJoinedBlock(blocks[bucket_index], /*check_limits=*/false);
// We need to rebuild block without bucket_index part in case of overflow. // We need to rebuild block without bucket_index part in case of overflow.
@ -543,7 +522,6 @@ void GraceHashJoin::addJoinedBlockImpl(InMemoryJoinPtr & join, size_t bucket_ind
assert(blocks.empty() || blocks.size() == snapshot->size()); assert(blocks.empty() || blocks.size() == snapshot->size());
for (size_t i = 1; i < blocks.size(); ++i) for (size_t i = 1; i < blocks.size(); ++i)
{ {
checkBlock("addJoinedBlockImpl:lastwrite", blocks[i], i);
if (i != bucket_index && blocks[i].rows()) if (i != bucket_index && blocks[i].rows())
snapshot->at(i)->addRightBlock(blocks[i]); snapshot->at(i)->addRightBlock(blocks[i]);
} }

2
src/Interpreters/GraceHashJoin.h
View File

@ -75,8 +75,6 @@ private:
/// Perform some bookkeeping after all calls to @joinBlock. /// Perform some bookkeeping after all calls to @joinBlock.
void startReadingDelayedBlocks(); void startReadingDelayedBlocks();
bool checkBlock(std::string_view desc, const Block & block, size_t bucket);
Poco::Logger * log; Poco::Logger * log;
ContextPtr context; ContextPtr context;
std::shared_ptr<TableJoin> table_join; std::shared_ptr<TableJoin> table_join;