thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16660 from ClickHouse/ornull-minor

Browse Source 
Minor modification: less templates
This commit is contained in:
alexey-milovidov 2020-11-04 23:42:49 +03:00 committed by GitHub
commit ef111f104c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/AggregateFunctions/AggregateFunctionOrFill.cpp
View File

@ -9,16 +9,23 @@ namespace DB
namespace
{
template <bool UseNull>
enum class Kind
{
OrNull,
OrDefault
};
class AggregateFunctionCombinatorOrFill final : public IAggregateFunctionCombinator
{
private:
Kind kind;
public:
explicit AggregateFunctionCombinatorOrFill(Kind kind_) : kind(kind_) {}
String getName() const override
{
if constexpr (UseNull)
return "OrNull";
else
return "OrDefault";
return kind == Kind::OrNull ? "OrNull" : "OrDefault";
}
AggregateFunctionPtr transformAggregateFunction(
@ -27,10 +34,10 @@ public:
const DataTypes & arguments,
const Array & params) const override
{
return std::make_shared<AggregateFunctionOrFill<UseNull>>(
nested_function,
arguments,
params);
if (kind == Kind::OrNull)
return std::make_shared<AggregateFunctionOrFill<true>>(nested_function, arguments, params);
else
return std::make_shared<AggregateFunctionOrFill<false>>(nested_function, arguments, params);
}
};
@ -38,8 +45,8 @@ public:
void registerAggregateFunctionCombinatorOrFill(AggregateFunctionCombinatorFactory & factory)
{
factory.registerCombinator(std::make_shared<AggregateFunctionCombinatorOrFill<false>>());
factory.registerCombinator(std::make_shared<AggregateFunctionCombinatorOrFill<true>>());
factory.registerCombinator(std::make_shared<AggregateFunctionCombinatorOrFill>(Kind::OrNull));
factory.registerCombinator(std::make_shared<AggregateFunctionCombinatorOrFill>(Kind::OrDefault));
}
}