From f1d695463717703d9c9f076b0e18972425b6bf46 Mon Sep 17 00:00:00 2001
From: vdimir <vdimir@clickhouse.com>
Date: Thu, 29 Jun 2023 13:09:55 +0000
Subject: [PATCH] Fix logical error in ANTI join with NULL

---
 src/Interpreters/HashJoin.cpp                    |  3 +++
 .../02771_semi_join_use_nulls.reference          | 16 ++++++++++++++++
 .../0_stateless/02771_semi_join_use_nulls.sql.j2 |  6 ++++++
 3 files changed, 25 insertions(+)

diff --git a/src/Interpreters/HashJoin.cpp b/src/Interpreters/HashJoin.cpp
index 6fe2b8464f5..7fee2ab7a6f 100644
--- a/src/Interpreters/HashJoin.cpp
+++ b/src/Interpreters/HashJoin.cpp
@@ -1383,6 +1383,9 @@ NO_INLINE IColumn::Filter joinRightColumns(
         {
             if (!right_row_found && null_element_found)
             {
+                if constexpr (join_features.is_anti_join && join_features.left)
+                    setUsed<need_filter>(filter, i);
+
                 addNotFoundRow<join_features.add_missing, join_features.need_replication>(added_columns, current_offset);
 
                 if constexpr (join_features.need_replication)
diff --git a/tests/queries/0_stateless/02771_semi_join_use_nulls.reference b/tests/queries/0_stateless/02771_semi_join_use_nulls.reference
index 8d4b1a3a75e..91c0d964968 100644
--- a/tests/queries/0_stateless/02771_semi_join_use_nulls.reference
+++ b/tests/queries/0_stateless/02771_semi_join_use_nulls.reference
@@ -11,7 +11,9 @@
 0	0
 0	0
 0	1
+\N	0
 0	1
+\N	0
 0	0
 0	0
 0	\N
@@ -25,7 +27,9 @@
 0	0
 0	0
 0	2
+\N	1
 0	2
+\N	1
 0	\N
 0	0
 0	\N
@@ -39,7 +43,9 @@
 0	\N
 0	\N
 0	1
+\N	\N
 0	1
+\N	\N
 0	0
 0	0
 0	0
@@ -53,7 +59,9 @@
 0	0
 0	0
 \N	2
+\N	1
 \N	2
+\N	1
 0	0
 0	0
 0	0
@@ -67,7 +75,9 @@
 0	0
 0	0
 0	1
+\N	0
 0	1
+\N	0
 0	0
 0	0
 0	0
@@ -81,7 +91,9 @@
 0	0
 0	0
 1	2
+\N	1
 1	2
+\N	1
 0	\N
 0	0
 0	0
@@ -95,7 +107,9 @@
 0	\N
 0	\N
 0	1
+\N	\N
 0	1
+\N	\N
 0	0
 0	0
 0	0
@@ -109,4 +123,6 @@
 0	0
 0	0
 1	2
+\N	1
 1	2
+\N	1
diff --git a/tests/queries/0_stateless/02771_semi_join_use_nulls.sql.j2 b/tests/queries/0_stateless/02771_semi_join_use_nulls.sql.j2
index 37b2e63761b..248461a98bb 100644
--- a/tests/queries/0_stateless/02771_semi_join_use_nulls.sql.j2
+++ b/tests/queries/0_stateless/02771_semi_join_use_nulls.sql.j2
@@ -44,6 +44,12 @@ SELECT id > 1, d.idd FROM (SELECT {{ maybe_materialize }}(toLowCardinality(0)) A
 ON a.id = d.idd
 ;
 
+SELECT *
+FROM (SELECT {{ maybe_materialize }}(NULL :: Nullable(UInt64)) AS id) AS a
+{{ strictness }} {{ kind }} JOIN (SELECT {{ maybe_materialize }}(1 :: UInt32) AS id) AS d
+ON a.id = d.id
+;
+
 {% endfor -%}
 {% endfor -%}
 {% endfor -%}