thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 09:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash with different allow_experimental_analyzer value in subqueries

Browse Source
This commit is contained in:
Dmitry Novik 2024-03-04 15:32:15 +01:00
parent fb02137fcc
commit f2387262ce
3 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/Interpreters/executeQuery.cpp
View File

@ -651,6 +651,36 @@ static void setQuerySpecificSettings(ASTPtr & ast, ContextMutablePtr context)
}
}
void validateAnalyzerSettings(ASTPtr ast, bool context_value)
{
if (ast->as<ASTSetQuery>())
return;
bool top_level = context_value;
std::vector<ASTPtr> nodes_to_process{ ast };
while (!nodes_to_process.empty())
{
auto node = nodes_to_process.back();
nodes_to_process.pop_back();
if (auto * set_query = node->as<ASTSetQuery>())
{
if (auto * value = set_query->changes.tryGet("allow_experimental_analyzer"))
{
if (top_level != value->safeGet<bool>())
throw Exception(ErrorCodes::LOGICAL_ERROR, "Setting 'allow_experimental_analyzer' is changed in the subquery. Top level value: {}", top_level);
}
}
for (auto child : node->children)
{
if (child)
nodes_to_process.push_back(std::move(child));
}
}
}
static std::tuple<ASTPtr, BlockIO> executeQueryImpl(
const char * begin,
const char * end,
@ -861,6 +891,7 @@ static std::tuple<ASTPtr, BlockIO> executeQueryImpl(
/// Interpret SETTINGS clauses as early as possible (before invoking the corresponding interpreter),
/// to allow settings to take effect.
InterpreterSetQuery::applySettingsFromQuery(ast, context);
validateAnalyzerSettings(ast, context->getSettingsRef().allow_experimental_analyzer);
if (auto * insert_query = ast->as<ASTInsertQuery>())
insert_query->tail = istr;

0
tests/queries/0_stateless/03003_analyzer_setting.reference Normal file
View File

9
tests/queries/0_stateless/03003_analyzer_setting.sql Normal file
View File

@ -0,0 +1,9 @@
CREATE TABLE test (dummy Int8) ENGINE = Distributed(test_cluster_two_shards, 'system', 'one');
SET allow_experimental_analyzer = 0;
SELECT * FROM (SELECT * FROM test SETTINGS allow_experimental_analyzer = 1); -- { serverError LOGICAL_ERROR}
SET allow_experimental_analyzer = 1;
SELECT * FROM (SELECT * FROM test SETTINGS allow_experimental_analyzer = 0); -- { serverError LOGICAL_ERROR}