thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-29 11:02:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18306 from amosbird/restrictsettings

Browse Source 
Extend mergetree setting alter restriction
This commit is contained in:
alesapin 2020-12-23 23:09:59 +03:00 committed by GitHub
commit f3f5466d23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Storages/MergeTree/MergeTreeSettings.h
View File

@ -134,7 +134,8 @@ struct MergeTreeSettings : public BaseSettings<MergeTreeSettingsTraits>
/// We check settings after storage creation
static bool isReadonlySetting(const String & name)
{
return name == "index_granularity" || name == "index_granularity_bytes";
return name == "index_granularity" || name == "index_granularity_bytes" || name == "write_final_mark"
|| name == "enable_mixed_granularity_parts";
}
static bool isPartFormatSetting(const String & name)

28
tests/integration/test_adaptive_granularity_different_settings/test.py
View File

@ -51,31 +51,3 @@ def test_attach_detach(start_cluster):
assert node1.query("SELECT COUNT() FROM test") == "4\n"
assert node2.query("SELECT COUNT() FROM test") == "4\n"
def test_mutate_with_mixed_granularity(start_cluster):
node3.query("""
CREATE TABLE test (date Date, key UInt64, value1 String, value2 String)
ENGINE = MergeTree
ORDER BY key PARTITION BY date""")
node3.query(
"INSERT INTO test SELECT toDate('2019-10-01') + number % 5, number, toString(number), toString(number * number) FROM numbers(500)")
assert node3.query("SELECT COUNT() FROM test") == "500\n"
node3.restart_with_latest_version()
assert node3.query("SELECT COUNT() FROM test") == "500\n"
node3.query("ALTER TABLE test MODIFY SETTING enable_mixed_granularity_parts = 1")
node3.query(
"INSERT INTO test SELECT toDate('2019-10-01') + number % 5, number, toString(number), toString(number * number) FROM numbers(500, 500)")
assert node3.query("SELECT COUNT() FROM test") == "1000\n"
assert node3.query("SELECT COUNT() FROM test WHERE key % 100 == 0") == "10\n"
node3.query("ALTER TABLE test DELETE WHERE key % 100 == 0", settings={"mutations_sync": "2"})
assert node3.query("SELECT COUNT() FROM test WHERE key % 100 == 0") == "0\n"