thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-01 03:52:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable parallel replicas for joins

Browse Source
This commit is contained in:
Antonio Andelic 2023-03-07 11:24:46 +00:00
parent 2ae0bceb2b
commit f408f750eb
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Interpreters/InterpreterSelectQuery.cpp
View File

@ -455,10 +455,11 @@ InterpreterSelectQuery::InterpreterSelectQuery(
} }
} }
if (joined_tables.tablesCount() > 1 && settings.allow_experimental_parallel_reading_from_replicas) if (joined_tables.tablesCount() > 1 && (!settings.parallel_replicas_custom_key.value.empty() || settings.allow_experimental_parallel_reading_from_replicas))
{ {
LOG_WARNING(log, "Joins are not supported with parallel replicas. Query will be executed without using them."); LOG_WARNING(log, "Joins are not supported with parallel replicas. Query will be executed without using them.");
context->setSetting("allow_experimental_parallel_reading_from_replicas", false); context->setSetting("allow_experimental_parallel_reading_from_replicas", false);
context->setSetting("parallel_replicas_custom_key", String{""});
} }
/// Rewrite JOINs /// Rewrite JOINs

1
tests/queries/0_stateless/02535_max_parallel_replicas_custom_key.reference
View File

@ -170,3 +170,4 @@ filter_type='range' max_replicas=3 prefer_localhost_replica=1
0 334 0 334
1 333 1 333
2 333 2 333
1

2
tests/queries/0_stateless/02535_max_parallel_replicas_custom_key.sh
View File

@ -41,4 +41,6 @@ run_count_with_custom_key "y"
run_count_with_custom_key "cityHash64(y)" run_count_with_custom_key "cityHash64(y)"
run_count_with_custom_key "cityHash64(y) + 1" run_count_with_custom_key "cityHash64(y) + 1"
$CLICKHOUSE_CLIENT --query="SELECT count() FROM cluster(test_cluster_one_shard_three_replicas_localhost, currentDatabase(), 02535_custom_key) as t1 JOIN 02535_custom_key USING y" --parallel_replicas_custom_key="y" --send_logs_level="trace" 2>&1 | grep -Fac "Joins are not supported with parallel replicas"
$CLICKHOUSE_CLIENT --query="DROP TABLE 02535_custom_key" $CLICKHOUSE_CLIENT --query="DROP TABLE 02535_custom_key"