From f4101861e7aeaf3d28eb9589b810116fc5cc25e0 Mon Sep 17 00:00:00 2001 From: Maksim Kita Date: Tue, 4 Oct 2022 17:29:33 +0200 Subject: [PATCH] Function name normalization fix functions header --- .clang-tidy | 2 +- src/AggregateFunctions/AggregateFunctionFactory.h | 2 ++ src/Functions/FunctionFactory.h | 2 ++ src/Interpreters/FunctionNameNormalizer.cpp | 6 +++--- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 532b0f37b81..5da1d309f62 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,7 +1,7 @@ # To run clang-tidy from CMake, build ClickHouse with -DENABLE_CLANG_TIDY=1. To show all warnings, it is # recommended to pass "-k0" to Ninja. -# Enable all checks + disale selected checks. Feel free to remove disabled checks from below list if +# Enable all checks + disable selected checks. Feel free to remove disabled checks from below list if # a) the new check is not controversial (this includes many checks in readability-* and google-*) or # b) too noisy (checks with > 100 new warnings are considered noisy, this includes e.g. cppcoreguidelines-*). diff --git a/src/AggregateFunctions/AggregateFunctionFactory.h b/src/AggregateFunctions/AggregateFunctionFactory.h index a860831cb88..0a966e4d8b5 100644 --- a/src/AggregateFunctions/AggregateFunctionFactory.h +++ b/src/AggregateFunctions/AggregateFunctionFactory.h @@ -114,4 +114,6 @@ struct AggregateUtils } }; +const String & getAggregateFunctionCanonicalNameIfAny(const String & name); + } diff --git a/src/Functions/FunctionFactory.h b/src/Functions/FunctionFactory.h index b6a2adcb424..1a909ea0598 100644 --- a/src/Functions/FunctionFactory.h +++ b/src/Functions/FunctionFactory.h @@ -88,4 +88,6 @@ private: String getFactoryName() const override { return "FunctionFactory"; } }; +const String & getFunctionCanonicalNameIfAny(const String & name); + } diff --git a/src/Interpreters/FunctionNameNormalizer.cpp b/src/Interpreters/FunctionNameNormalizer.cpp index d163bf3cba5..ece474772bc 100644 --- a/src/Interpreters/FunctionNameNormalizer.cpp +++ b/src/Interpreters/FunctionNameNormalizer.cpp @@ -4,12 +4,12 @@ #include #include +#include +#include + namespace DB { -const String & getFunctionCanonicalNameIfAny(const String & name); -const String & getAggregateFunctionCanonicalNameIfAny(const String & name); - void FunctionNameNormalizer::visit(IAST * ast) { if (!ast)