mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-23 08:02:02 +00:00
Rename "Non-significant" to "Not for changelog".
The previous name was not universally liked, because technically a PR might be very much significant, we just don't want to mention it in the changelog.
This commit is contained in:
parent
51a064aa75
commit
f4d9002182
2
.github/PULL_REQUEST_TEMPLATE.md
vendored
2
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -9,7 +9,7 @@ Changelog category (leave one):
|
|||||||
- Build/Testing/Packaging Improvement
|
- Build/Testing/Packaging Improvement
|
||||||
- Documentation (changelog entry is not required)
|
- Documentation (changelog entry is not required)
|
||||||
- Other
|
- Other
|
||||||
- Non-significant (changelog entry is not required)
|
- Not for changelog (changelog entry is not required)
|
||||||
|
|
||||||
|
|
||||||
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
|
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
|
||||||
|
@ -284,7 +284,7 @@ def parse_one_pull_request(item):
|
|||||||
cat = re.sub(r'^[-*\s]*', '', cat)
|
cat = re.sub(r'^[-*\s]*', '', cat)
|
||||||
|
|
||||||
# Filter out the PR categories that are not for changelog.
|
# Filter out the PR categories that are not for changelog.
|
||||||
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)', cat):
|
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)|(not[ ]*for[ ]*changelog)', cat):
|
||||||
return False
|
return False
|
||||||
|
|
||||||
short_descr = ''
|
short_descr = ''
|
||||||
|
@ -57,7 +57,7 @@ def parse_one_pull_request(item):
|
|||||||
category = "NO CL CATEGORY"
|
category = "NO CL CATEGORY"
|
||||||
|
|
||||||
# Filter out the PR categories that are not for changelog.
|
# Filter out the PR categories that are not for changelog.
|
||||||
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)', category):
|
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)|(not[ ]*for[ ]*changelog)', category):
|
||||||
return False
|
return False
|
||||||
|
|
||||||
if not entry:
|
if not entry:
|
||||||
|
Loading…
Reference in New Issue
Block a user