thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename "Non-significant" to "Not for changelog".

Browse Source 
The previous name was not universally liked, because technically a PR
might be very much significant, we just don't want to mention it in the
changelog.
This commit is contained in:
Alexander Kuzmenkov 2020-05-22 23:07:48 +03:00
parent 51a064aa75
commit f4d9002182
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -9,7 +9,7 @@ Changelog category (leave one):
- Build/Testing/Packaging Improvement
- Documentation (changelog entry is not required)
- Other
- Non-significant (changelog entry is not required)
- Not for changelog (changelog entry is not required)
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

2
utils/make_changelog.py
View File

@ -284,7 +284,7 @@ def parse_one_pull_request(item):
cat = re.sub(r'^[-*\s]*', '', cat)
# Filter out the PR categories that are not for changelog.
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)', cat):
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)|(not[ ]*for[ ]*changelog)', cat):
return False
short_descr = ''

2
utils/simple-backport/format-changelog.py
View File

@ -57,7 +57,7 @@ def parse_one_pull_request(item):
category = "NO CL CATEGORY"
# Filter out the PR categories that are not for changelog.
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)', category):
if re.match(r'(?i)doc|((non|in|not|un)[-\s]*significant)|(not[ ]*for[ ]*changelog)', category):
return False
if not entry: