Removes unused CMake variable and fixes clang-tidy lint

This commit is contained in:
Benjamin Naecker 2021-06-11 14:35:40 -07:00
parent e4e0bd557a
commit f5cf9adc66
2 changed files with 2 additions and 13 deletions

View File

@ -186,17 +186,6 @@ set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -rdynamic")
find_program (OBJCOPY_PATH NAMES "llvm-objcopy" "llvm-objcopy-12" "llvm-objcopy-11" "llvm-objcopy-10" "llvm-objcopy-9" "llvm-objcopy-8" "objcopy")
if (OBJCOPY_PATH)
message(STATUS "Using objcopy: ${OBJCOPY_PATH}.")
if (OS_LINUX)
if (ARCH_AMD64)
set(OBJCOPY_ARCH_OPTIONS -O elf64-x86-64 -B i386)
elseif (ARCH_AARCH64)
set(OBJCOPY_ARCH_OPTIONS -O elf64-aarch64 -B aarch64)
endif ()
elseif (OS_DARWIN)
set(OBJCOPY_ARCH_OPTIONS -O mach-o-x86-64 -B i386)
elseif (OS_SUNOS)
set(OBJCOPY_ARCH_OPTIONS -O elf64-x86-64-sol2 -B i386)
endif()
else ()
message(FATAL_ERROR "Cannot find objcopy.")
endif ()

View File

@ -33,8 +33,8 @@ std::string_view getResource(std::string_view name)
std::string symbol_name_start = prefix + name_replaced + "_start";
std::string symbol_name_end = prefix + name_replaced + "_end";
auto sym_start = reinterpret_cast<const char*>(dlsym(RTLD_DEFAULT, symbol_name_start.c_str()));
auto sym_end = reinterpret_cast<const char*>(dlsym(RTLD_DEFAULT, symbol_name_end.c_str()));
const char* sym_start = reinterpret_cast<const char*>(dlsym(RTLD_DEFAULT, symbol_name_start.c_str()));
const char* sym_end = reinterpret_cast<const char*>(dlsym(RTLD_DEFAULT, symbol_name_end.c_str()));
if (sym_start && sym_end)
{