thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-19 04:42:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #73159 from ClickHouse/backport/24.10/73045

Browse Source 
Backport #73045 to 24.10: Fix crash in transactions with unsupported storage
This commit is contained in:
Raúl Marín 2024-12-12 12:52:57 +01:00 committed by GitHub
commit f66e8b8047
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Interpreters/InterpreterSelectQuery.cpp
View File

@ -582,7 +582,7 @@ InterpreterSelectQuery::InterpreterSelectQuery(
auto maybe_storage = DatabaseCatalog::instance().tryGetTable({table.table.database, table.table.table}, context);
if (!maybe_storage)
continue;
checkStorageSupportsTransactionsIfNeeded(storage, context, /* is_readonly_query */ true);
checkStorageSupportsTransactionsIfNeeded(maybe_storage, context, /* is_readonly_query */ true);
}
}

0
tests/queries/0_stateless/03282_memory_transaction_crash.reference Normal file
View File

9
tests/queries/0_stateless/03282_memory_transaction_crash.sql Normal file
View File

@ -0,0 +1,9 @@
-- Tags: zookeeper
-- https://github.com/ClickHouse/ClickHouse/issues/72887
DROP TABLE IF EXISTS t0;
CREATE TABLE t0 (c0 Int) ENGINE = Memory();
BEGIN TRANSACTION;
EXPLAIN SYNTAX SELECT 1 FROM (SELECT 1) tx JOIN t0 ON TRUE; -- { serverError NOT_IMPLEMENTED }
ROLLBACK;
DROP TABLE IF EXISTS t0;