thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-17 21:24:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor: using UInt32 DateTime64-related scale instead of UInt64.

Browse Source
This commit is contained in:
Vasily Nemkov 2019-10-04 17:05:39 +03:00
parent 1069812d88
commit f6a997d1e1
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dbms/src/Functions/now.cpp
View File

@ -16,7 +16,7 @@ namespace ErrorCodes
extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH; extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
} }
DateTime64::NativeType nowSubsecond(UInt8 scale) { DateTime64::NativeType nowSubsecond(UInt32 scale) {
timespec spec; timespec spec;
clock_gettime(CLOCK_REALTIME, &spec); clock_gettime(CLOCK_REALTIME, &spec);
@ -64,11 +64,12 @@ public:
bool isVariadic() const override { return true; } bool isVariadic() const override { return true; }
size_t getNumberOfArguments() const override { return 0; } size_t getNumberOfArguments() const override { return 0; }
ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return ColumnNumbers{0}; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return ColumnNumbers{0}; }
bool isDeterministic() const override { return false; }
// Return type depends on argument value. // Return type depends on argument value.
DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override
{ {
UInt64 scale = DataTypeDateTime64::default_scale; UInt32 scale = DataTypeDateTime64::default_scale;
// Type check is similar to the validateArgumentType, trying to keep error codes and messages as close to the said function as possible. // Type check is similar to the validateArgumentType, trying to keep error codes and messages as close to the said function as possible.
if (arguments.size() >= 1) if (arguments.size() >= 1)
@ -87,11 +88,9 @@ public:
return std::make_shared<DataTypeDateTime64>(scale); return std::make_shared<DataTypeDateTime64>(scale);
} }
bool isDeterministic() const override { return false; }
void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override
{ {
UInt64 scale = DataTypeDateTime64::default_scale; UInt32 scale = DataTypeDateTime64::default_scale;
if (arguments.size() == 1) if (arguments.size() == 1)
{ {
const IColumn * scale_column = block.getByPosition(arguments[0]).column.get(); const IColumn * scale_column = block.getByPosition(arguments[0]).column.get();