thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-26 09:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
János Benjamin Antal 2024-08-05 09:11:55 +00:00
parent bada9ea9be
commit f816158dbc
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Storages/MessageQueueSink.cpp
View File

@ -46,6 +46,8 @@ void MessageQueueSink::consume(Chunk & chunk)
if (columns.empty())
return;
/// The formatter might hold pointers to buffer (e.g. if PeekableWriteBuffer is used), which means the formatter
/// needs to be reset after buffer might reallocate its memory. In this exact case after restarting the buffer.
if (row_format)
{
size_t row = 0;
@ -77,6 +79,4 @@ void MessageQueueSink::consume(Chunk & chunk)
format->resetFormatter();
}
}
}

2
tests/integration/test_storage_kafka/test.py
View File

@ -5098,7 +5098,7 @@ def test_multiple_read_in_materialized_views(kafka_cluster, max_retries=15):
def test_kafka_produce_http_interface_row_based_format(kafka_cluster):
# reproduction of #https://github.com/ClickHouse/ClickHouse/issues/61060 with validating the written messages
# reproduction of #61060 with validating the written messages
admin_client = KafkaAdminClient(
bootstrap_servers="localhost:{}".format(kafka_cluster.kafka_port)
)