thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-23 18:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

update the evict action when overwrite a key

Browse Source
This commit is contained in:
lgbo-ustc 2021-12-27 18:12:40 +08:00 committed by liangjiabiao
parent 54b2a42530
commit f86e3ef1ae
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Common/LRUCache.h
View File

@ -339,10 +339,10 @@ private:
std::forward_as_tuple()); std::forward_as_tuple());
Cell & cell = it->second; Cell & cell = it->second;
auto value_weight = mapped ? weight_function(*mapped) : 0;
if (inserted) if (inserted)
{ {
auto value_weight = mapped ? weight_function(*mapped) : 0;
if (!removeOverflow(value_weight)) if (!removeOverflow(value_weight))
{ {
// cannot find enough space to put in the new value // cannot find enough space to put in the new value
@ -364,6 +364,8 @@ private:
{ {
if (!evict_policy.canRelease(cell.value)) if (!evict_policy.canRelease(cell.value))
return false; return false;
if (value_weight > cell.size && !removeOverflow(value_weight - cell.size))
return false;
evict_policy.release(cell.value); // release the old value. this action is empty in default policy. evict_policy.release(cell.value); // release the old value. this action is empty in default policy.
current_size -= cell.size; current_size -= cell.size;
queue.splice(queue.end(), queue, cell.queue_iterator); queue.splice(queue.end(), queue, cell.queue_iterator);
@ -373,7 +375,6 @@ private:
cell.size = cell.value ? weight_function(*cell.value) : 0; cell.size = cell.value ? weight_function(*cell.value) : 0;
current_size += cell.size; current_size += cell.size;
removeOverflow();
return true; return true;
} }