thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow trailing comma in the Values format

Browse Source
This commit is contained in:
Alexey Milovidov 2024-05-15 06:01:49 +02:00
parent 17fc2936ce
commit f88d294dd0
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Processors/Formats/Impl/ValuesBlockInputFormat.cpp
View File

@ -572,9 +572,16 @@ bool ValuesBlockInputFormat::checkDelimiterAfterValue(size_t column_idx)
skipWhitespaceIfAny(*buf);
if (likely(column_idx + 1 != num_columns))
{
return checkChar(',', *buf);
}
else
{
/// Optional trailing comma.
if (checkChar(',', *buf))
skipWhitespaceIfAny(*buf);
return checkChar(')', *buf);
}
}
bool ValuesBlockInputFormat::shouldDeduceNewTemplate(size_t column_idx)

3
tests/queries/0_stateless/03153_trailing_comma_in_values_list_in_insert.reference Normal file
View File

@ -0,0 +1,3 @@
1 2 3
4 5 6
7 8 9

5
tests/queries/0_stateless/03153_trailing_comma_in_values_list_in_insert.sql Normal file
View File

@ -0,0 +1,5 @@
CREATE TEMPORARY TABLE test (a UInt8, b UInt8, c UInt8);
INSERT INTO test (a, b, c) VALUES (1, 2, 3, );
INSERT INTO test (a, b, c) VALUES (4, 5, 6,);
INSERT INTO test (a, b, c) VALUES (7, 8, 9);
SELECT * FROM test ORDER BY a;