thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #49616 from ClickHouse/fix-error-48300

Browse Source 
Fix error in #48300
This commit is contained in:
Alexey Milovidov 2023-05-07 17:38:23 +03:00 committed by GitHub
commit f93064d9c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/Functions/transform.cpp
View File

@ -4,9 +4,7 @@
#include <Columns/ColumnArray.h>
#include <Columns/ColumnConst.h>
#include <Columns/ColumnDecimal.h>
#include <Columns/ColumnNullable.h>
#include <Columns/ColumnString.h>
#include <Columns/ColumnsNumber.h>
#include <Core/DecimalFunctions.h>
#include <DataTypes/DataTypeArray.h>
#include <DataTypes/getLeastSupertype.h>
@ -15,10 +13,7 @@
#include <Functions/IFunction.h>
#include <Interpreters/castColumn.h>
#include <Interpreters/convertFieldToType.h>
#include <base/StringRef.h>
#include <Common/Arena.h>
#include <Common/FieldVisitorConvertToNumber.h>
#include <Common/FieldVisitorDump.h>
#include <Common/HashTable/HashMap.h>
#include <Common/typeid_cast.h>
@ -635,22 +630,27 @@ namespace
}
}
static void checkAllowedType(const DataTypePtr & dt)
static void checkAllowedType(const DataTypePtr & type)
{
if (dt->isNullable())
checkAllowedTypeHelper(static_cast<const DataTypeNullable *>(dt.get())->getNestedType());
if (type->isNullable())
checkAllowedTypeHelper(static_cast<const DataTypeNullable *>(type.get())->getNestedType());
else
checkAllowedTypeHelper(dt);
checkAllowedTypeHelper(type);
}
static void checkAllowedTypeHelper(const DataTypePtr & dt)
static void checkAllowedTypeHelper(const DataTypePtr & type)
{
if (isStringOrFixedString(dt))
if (isStringOrFixedString(type))
return;
auto dtsize = dt->getMaximumSizeOfValueInMemory();
if (dtsize <= sizeof(UInt64))
return;
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Unexpected type {} in function 'transform'", dt->getName());
if (type->haveMaximumSizeOfValue())
{
auto data_type_size = type->getMaximumSizeOfValueInMemory();
if (data_type_size <= sizeof(UInt64))
return;
}
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Unexpected type {} in function 'transform'", type->getName());
}
/// Can be called from different threads. It works only on the first call.

0
tests/queries/0_stateless/02732_transform_fuzz.reference Normal file
View File

1
tests/queries/0_stateless/02732_transform_fuzz.sql Normal file
View File

@ -0,0 +1 @@
SELECT caseWithExpr(arrayReduce(NULL, []), []); -- { serverError BAD_ARGUMENTS }