From fa59133463bbdb44ed860c6e607829d7cad9b166 Mon Sep 17 00:00:00 2001
From: vdimir <vdimir@clickhouse.com>
Date: Wed, 13 Jul 2022 11:51:11 +0000
Subject: [PATCH] Do not spam log in MergeJoinAlgorithm

---
 src/Processors/Transforms/MergeJoinTransform.cpp |  2 +-
 src/Processors/Transforms/MergeJoinTransform.h   | 15 +--------------
 2 files changed, 2 insertions(+), 15 deletions(-)

diff --git a/src/Processors/Transforms/MergeJoinTransform.cpp b/src/Processors/Transforms/MergeJoinTransform.cpp
index 690f751209f..c7b7afab541 100644
--- a/src/Processors/Transforms/MergeJoinTransform.cpp
+++ b/src/Processors/Transforms/MergeJoinTransform.cpp
@@ -855,7 +855,7 @@ MergeJoinTransform::MergeJoinTransform(
 
 void MergeJoinTransform::onFinish()
 {
-    algorithm.logElapsed(total_stopwatch.elapsedSeconds(), true);
+    algorithm.logElapsed(total_stopwatch.elapsedSeconds());
 }
 
 }
diff --git a/src/Processors/Transforms/MergeJoinTransform.h b/src/Processors/Transforms/MergeJoinTransform.h
index 0098e470e6f..9f60eafb455 100644
--- a/src/Processors/Transforms/MergeJoinTransform.h
+++ b/src/Processors/Transforms/MergeJoinTransform.h
@@ -233,19 +233,14 @@ public:
     virtual void consume(Input & input, size_t source_num) override;
     virtual Status merge() override;
 
-    void logElapsed(double seconds, bool force)
+    void logElapsed(double seconds)
     {
-        /// Do not log more frequently than once per ten seconds
-        if (seconds - stat.last_log_seconds < 10 && !force)
-            return;
-
         LOG_TRACE(log,
             "Finished pocessing in {} seconds"
             ", left: {} blocks, {} rows; right: {} blocks, {} rows"
             ", max blocks loaded to memory: {}",
             seconds, stat.num_blocks[0], stat.num_rows[0], stat.num_blocks[1], stat.num_rows[1],
             stat.max_blocks_loaded);
-        stat.last_log_seconds = seconds;
     }
 
 private:
@@ -277,8 +272,6 @@ private:
         size_t num_rows[2] = {0, 0};
 
         size_t max_blocks_loaded = 0;
-
-        double last_log_seconds = 0;
     };
 
     Statistic stat;
@@ -303,12 +296,6 @@ public:
 protected:
     void onFinish() override;
 
-    void work() override
-    {
-        algorithm.logElapsed(total_stopwatch.elapsedSeconds(), true);
-        Base::work();
-    }
-
     Poco::Logger * log;
 };