thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-01 12:01:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comment for memory tracker blocking

Browse Source
This commit is contained in:
Antonio Andelic 2022-08-04 07:13:42 +00:00
parent 56ca93ca3f
commit fa98338ce1
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Coordination/KeeperServer.cpp
View File

@ -176,6 +176,11 @@ struct KeeperServer::KeeperRaftServer : public nuraft::raft_server
void commit_in_bg() override
{
// For NuRaft, if any commit fails (uncaught exception) the whole server aborts as a safety
// This includes failed allocation which can produce an unknown state for the storage,
// making it impossible to handle correctly.
// We block the memory tracker for all the commit operations (including KeeperStateMachine::commit)
// assuming that the allocations are small
MemoryTrackerBlockerInThread blocker;
nuraft::raft_server::commit_in_bg();
}