thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect key condition of fixed strings.

Browse Source
This commit is contained in:
Amos Bird 2020-09-20 11:53:29 +08:00
parent 988b20a32c
commit fcee786320
No known key found for this signature in database
GPG Key ID: 80D430DCBECFEDB4
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Interpreters/convertFieldToType.cpp
View File

@ -191,7 +191,20 @@ Field convertFieldToTypeImpl(const Field & src, const IDataType & type, const ID
else if (which_type.isStringOrFixedString()) else if (which_type.isStringOrFixedString())
{ {
if (src.getType() == Field::Types::String) if (src.getType() == Field::Types::String)
{
if (which_type.isFixedString())
{
size_t n = assert_cast<const DataTypeFixedString &>(type).getN();
const auto & src_str = src.get<String>();
if (src_str.size() < n)
{
String src_str_extended = src_str;
src_str_extended.resize(n);
return src_str_extended;
}
}
return src; return src;
}
} }
else if (const DataTypeArray * type_array = typeid_cast<const DataTypeArray *>(&type)) else if (const DataTypeArray * type_array = typeid_cast<const DataTypeArray *>(&type))
{ {

1
tests/queries/0_stateless/01503_fixed_string_primary_key.reference Normal file
View File

@ -0,0 +1 @@
8

7
tests/queries/0_stateless/01503_fixed_string_primary_key.sql Normal file
View File

@ -0,0 +1,7 @@
DROP TABLE IF EXISTS test;
CREATE TABLE test(key FixedString(10)) ENGINE=MergeTree() PARTITION BY tuple() ORDER BY (key);
INSERT INTO test SELECT toString(intDiv(number, 8)) FROM numbers(100);
SELECT count() FROM test WHERE key = '1';
DROP TABLE IF EXISTS test;