thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not read part status just for logging

Browse Source
This commit is contained in:
Sema Checherinda 2022-12-01 16:03:39 +01:00
parent 1f93183dc7
commit fd2c7657be
4 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Storages/MergeTree/IMergeTreeDataPart.cpp
View File

@ -2041,14 +2041,6 @@ bool isCompressedFromIndexExtension(const String & index_extension)
return index_extension == getIndexExtension(true);
}
Strings getPartsNamesWithStates(const MergeTreeDataPartsVector & parts)
{
Strings part_names;
for (const auto & p : parts)
part_names.push_back(p->getNameWithState());
return part_names;
}
Strings getPartsNames(const MergeTreeDataPartsVector & parts)
{
Strings part_names;

1
src/Storages/MergeTree/IMergeTreeDataPart.h
View File

@ -597,7 +597,6 @@ bool isCompressedFromIndexExtension(const String & index_extension);
using MergeTreeDataPartsVector = std::vector<MergeTreeDataPartPtr>;
Strings getPartsNamesWithStates(const MergeTreeDataPartsVector & parts);
Strings getPartsNames(const MergeTreeDataPartsVector & parts);
}

2
src/Storages/MergeTree/MergeTreeData.cpp
View File

@ -4691,7 +4691,7 @@ void MergeTreeData::filterVisibleDataParts(DataPartsVector & maybe_visible_parts
[[maybe_unused]] size_t visible_size = maybe_visible_parts.size();
LOG_TEST(log, "Got {} parts (of {}) visible in snapshot {} (TID {}): {}",
visible_size, total_size, snapshot_version, current_tid, fmt::join(getPartsNamesWithStates(maybe_visible_parts), ", "));
visible_size, total_size, snapshot_version, current_tid, fmt::join(getPartsNames(maybe_visible_parts), ", "));
}

2
src/Storages/StorageMergeTree.cpp
View File

@ -1541,7 +1541,7 @@ void StorageMergeTree::truncate(const ASTPtr &, const StorageMetadataPtr &, Cont
LOG_TEST(log, "Made {} empty parts in order to cover {} parts. Empty parts: {}, covered parts: {}. With txn {}",
future_parts.size(), parts.size(),
fmt::join(getPartsNames(future_parts), ", "), fmt::join(getPartsNamesWithStates(parts), ", "),
fmt::join(getPartsNames(future_parts), ", "), fmt::join(getPartsNames(parts), ", "),
transaction.getTID());
captureTmpDirectoryHolders(*this, future_parts);