thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-28 10:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed bug with dictGetString

Browse Source
This commit is contained in:
Артем Стрельцов 2020-05-03 21:03:41 +03:00
parent 31fb42cf01
commit ff7b5db800
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Dictionaries/DirectDictionary.cpp
View File

@ -464,18 +464,20 @@ void DirectDictionary::getItemsStringImpl(
{
const auto rows = ext::size(ids);
std::vector<bool> is_found(rows, false);
for (const auto row : ext::range(0, rows))
{
auto stream = source_ptr->loadAll();
stream->readPrefix();
bool is_found = false;
while (const auto block = stream->read())
{
const IColumn & id_column = *block.safeGetByPosition(0).column;
for (const size_t attribute_idx : ext::range(0, attributes.size()))
{
if (is_found)
break;
const IColumn & attribute_column = *block.safeGetByPosition(attribute_idx + 1).column;
for (const auto row_idx : ext::range(0, id_column.size()))
@ -483,19 +485,19 @@ void DirectDictionary::getItemsStringImpl(
const auto key = id_column[row_idx].get<UInt64>();
if (key == ids[row] && attribute.name == attribute_name_by_index.at(attribute_idx))
{
is_found[row] = true;
is_found = true;
const String from_source = attribute_column[row_idx].get<String>();
set_value(row, from_source);
break;
}
}
}
}
stream->readSuffix();
}
for (const auto row : ext::range(0, rows))
if (!is_found[row])
if (!is_found)
set_value(row, get_default(row));
}
query_count.fetch_add(rows, std::memory_order_relaxed);
}