thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible performance test error

Browse Source 
CI [1]:

    2023-10-24 12:18:27	 ++ rg -c array_fill.xml changed-test-definitions.txt
    2023-10-24 12:18:27	 + '[' '' -gt 0 ']'
    2023-10-24 12:18:27	 right/scripts/compare.sh: line 288: [: : integer expression expected

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/55944/da408df4a7296835897d7cef80d63f252df79b75/performance_comparison_[2_4]/compare.log

v1: use --include-zero
v2: revert to grep
v3: check exit code
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
Azat Khuzhin 2023-10-24 13:00:44 +02:00
parent e2846d4c58
commit ff7e9e16d5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker/test/performance-comparison/compare.sh
View File

@ -285,7 +285,7 @@ function run_tests
# Use awk because bash doesn't support floating point arithmetic.
profile_seconds=$(awk "BEGIN { print ($profile_seconds_left > 0 ? 10 : 0) }")
if [ "$(rg -c $(basename $test) changed-test-definitions.txt)" -gt 0 ]
if rg --quiet "$(basename $test)" changed-test-definitions.txt
then
# Run all queries from changed test files to ensure that all new queries will be tested.
max_queries=0