Commit Graph

29696 Commits

Author SHA1 Message Date
Nikolai Kochetov
540ae64f37 Fix big memory usage for fetch. 2022-08-08 13:32:49 +00:00
Maksim Kita
a9c8e13344 Fixed code review issues 2022-08-08 14:54:11 +02:00
avogar
2f95726b06 Fix comments 2022-08-08 12:41:00 +00:00
vdimir
708747ca0b
Merge branch 'master' into refactor-prepared-sets 2022-08-08 14:27:18 +02:00
Vladimir C
6bd4821656
Merge pull request #39575 from vdimir/join_pushdown_column_not_found
Fix column not found for push down with join
2022-08-08 14:04:42 +02:00
Robert Schulze
ad0d060dc1
Merge pull request #39904 from ClickHouse/library-bridge-refactoring
Prepare library-bridge for catboost integration
2022-08-08 12:15:01 +02:00
Kseniia Sumarokova
d1b436597f
Merge pull request #39940 from azat/file-log-fix
Create metadata directory on CREATE for FileLog engine
2022-08-08 11:39:17 +02:00
Kseniia Sumarokova
ec4a4d31ea
Fix style check 2022-08-08 11:23:57 +02:00
Alexey Milovidov
0921548a37
Merge pull request #39527 from pkit/pkit/fix_nats_tls
fix nats-io TLS support
2022-08-08 08:28:14 +03:00
Alexey Milovidov
855e52a7c9 Send final ProfileEvents just in case 2022-08-08 07:12:08 +02:00
Alexey Milovidov
db85ebfaa7 Add server-side time to Progress 2022-08-08 06:55:41 +02:00
Alexey Milovidov
5524706b78
Revert "ColumnVector: optimize filter with AVX512VBMI2 compress store" 2022-08-08 05:03:15 +03:00
Alexey Milovidov
73f4643afa
Merge pull request #39839 from ClickHouse/Avogar-patch-1
Update settings changes history
2022-08-08 02:48:09 +03:00
Igor Nikonov
5268eacc9d
Merge pull request #39955 from ClickHouse/distinct-reduce-trace-level
Remove debug trace from DistinctStep
2022-08-07 23:47:11 +02:00
alexX512
f16c668a0c Delete Args from CacheBase 2022-08-07 20:44:26 +00:00
alexX512
1c9d40e4a8 Fix build error 2022-08-07 20:37:11 +00:00
alexX512
269631cfbe Fix typo 2022-08-07 20:02:32 +00:00
alexX512
62f84b88eb Review fixes 2022-08-07 20:02:21 +00:00
alexX512
8adf9f2448 fix compile error 2022-08-07 19:59:39 +00:00
alexX512
2be72560f4 Add loading of mark cache policy 2022-08-07 19:59:39 +00:00
alexX512
a057e1607a Fix remove operation, add evict ion i from cachef number of elements greater than max_elements_size 2022-08-07 19:59:39 +00:00
alexX512
8be62770aa Test with SLRU and debug logs 2022-08-07 19:59:39 +00:00
alexX512
c044fee7a0 Test with LRU 2022-08-07 19:59:39 +00:00
alexX512
a238e349cd Unblocking get max_size 2022-08-07 19:59:39 +00:00
alexX512
daab74925c Test with default cache policy = SLRU 2022-08-07 19:59:39 +00:00
alexX512
994a9fc005 Minor fixes 2022-08-07 19:59:38 +00:00
alexX512
50a8887ab9 Add [[maybe_unused]] locks and delete all objects from cache queue 2022-08-07 19:59:38 +00:00
alexX512
69cc89e36e Check with default cache policy = LRU 2022-08-07 19:59:38 +00:00
alexX512
a94950d3ac Test only with LRU 2022-08-07 19:59:38 +00:00
alexX512
9940b69bd7 Include fix in ICachePolicy.h 2022-08-07 19:59:38 +00:00
alexX512
910645a52a Include fix in SLRUCachePolicy.h 2022-08-07 19:59:38 +00:00
alexX512
4f52efd4bb Build fix 2022-08-07 19:59:38 +00:00
alexX512
6bf29cb610 Change class LRUCache to class CachBase. Check running CacheBase with default pcahce policy SLRU 2022-08-07 19:59:30 +00:00
alexX512
c606ccc75d Fix formatting problems 2022-08-07 19:16:40 +00:00
alexX512
1133e42367 Add CacheBase clas instead of LRUCache and SLRUCache fo simpler configuration oache policiesf 2022-08-07 19:16:40 +00:00
alexX512
a0d2da7261 Add tests for SLRU cache 2022-08-07 19:16:40 +00:00
AlPerevyshin
d7bdf9e601 Add SLRU cache 2022-08-07 19:16:38 +00:00
Maksim Kita
59db59fe83 Fix style check 2022-08-07 18:00:07 +02:00
Maksim Kita
83977dfead
Merge pull request #39869 from pkit/pkit/func_settings_format
fix incorrect format for functions with settings
2022-08-07 16:30:49 +02:00
Maksim Kita
4ddb341cc9 IAST destructor intrusive list 2022-08-07 16:29:23 +02:00
Igor Nikonov
254d14b1d3 Remove debug trace from DistinctStep
+ this information can be seen later via EXPLAIN PLAN
2022-08-07 13:12:11 +00:00
Kseniia Sumarokova
895639644e
Update src/Storages/StorageFile.cpp 2022-08-07 14:17:42 +02:00
flynn
4fa1762f96
Merge branch 'master' into file 2022-08-07 14:22:08 +08:00
Igor Nikonov
b4f5d9ca10
Merge pull request #39740 from ClickHouse/ordinary_distinct_small_refact
Simple refactoring: ordinary DISTINCT implementation
2022-08-07 01:05:23 +02:00
flynn
384a7ae901 Fix read of StorageFile with virtual columns 2022-08-06 17:29:33 +00:00
Constantine Peresypkin
766d816df6 fix incorrect format for functions with settings
when support for settings was added in #39681
the formating was not altered to support settings

now it's supported
2022-08-06 17:08:32 +02:00
Azat Khuzhin
d0189e8f66 Create metadata directory on CREATE for FileLog engine
This will allow to distinguish really corrupted data, since right now if
you will CREATE/DETACH/ATTACH such engine you will have the following
error [1]:

    2022.08.05 20:02:20.726398 [ 696405 ] {} <Error> StorageFileLog (file_log): Metadata files of table file_log are lost.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/39926/72961328f68b1ec05300d6dc4411a87618a2f46b/stress_test__debug_.html

Likely that previously it was not created to avoid creating empty
directories, however this should be a problem I guess.

Refs: #25969 (@ucasfl)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-06 13:54:49 +03:00
Alexander Gololobov
f52b6748db
Merge pull request #39900 from ClickHouse/wait_for_mutation_race
Fix the race between waitMutation and updating local queue from ZK
2022-08-06 12:09:16 +02:00
Azat Khuzhin
2d7de7f683 Remove dictionaries from prometheus metrics on DETACH/DROP
Fixes: #23436 (cc @kitaisreal)
Introduced-in: #9622 (cc @YiuRULE)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-06 12:58:07 +03:00
Alexey Milovidov
adc880f362
Merge pull request #39867 from ClickHouse/keeper-block-memory-tracker-commit
Block memory tracker in Keeper during commit
2022-08-06 02:02:29 +03:00
Igor Nikonov
8278da6475 Fix: read row counts before move columns out of chunk 2022-08-05 21:29:57 +00:00
Igor Nikonov
9fddf6efde Merge remote-tracking branch 'origin/master' into ordinary_distinct_small_refact 2022-08-05 19:23:44 +00:00
HarryLeeIBM
cbd01a3a73 Fix Endian issue in KeeperSnapshotManager 2022-08-05 11:07:42 -07:00
Alexander Gololobov
b57df6d71d
Merge branch 'master' into wait_for_mutation_race 2022-08-05 18:51:39 +02:00
Nikolai Kochetov
b41b716245
Update AsynchronousMetrics.cpp 2022-08-05 18:16:35 +02:00
Nikolai Kochetov
c6e3e14bcc
Merge pull request #39184 from ClickHouse/respect-remote_url_allow_hosts-for-other-dict-sources
Respect remote_url_allow_hosts in relevant dictionary sources.
2022-08-05 17:25:53 +02:00
Nikolai Kochetov
0005c37acc
Merge pull request #39477 from azat/fix-mv-drop-race
Fix LOGICAL_ERROR on race between DROP and INSERT with materialized views
2022-08-05 17:19:45 +02:00
Alexander Tokmakov
c983f14ed1
Merge pull request #39925 from ClickHouse/log_test_on_connection_close
Add logging to debug flaky tests
2022-08-05 16:20:17 +03:00
Alexander Tokmakov
25a9bf5deb
Merge pull request #39922 from ClickHouse/fix_flaky_tests_commit_obsolete_part
Fix flaky tests (`Tried to commit obsolete part`)
2022-08-05 14:36:43 +03:00
Alexander Tokmakov
e59f217f8d add test logs on connection close 2022-08-05 13:33:27 +02:00
Nikolai Kochetov
cf34232675 Output header is now empty for every MV chain.
Instead of checking that number of processors different for different
threads, simply always return empty header from buildChainImpl(), by
adding explicit conversion.

v2: ignore UNKNOWN_TABLE errors in test
2022-08-05 13:16:32 +03:00
Azat Khuzhin
4efa847a1f Fix LOGICAL_ERROR on race between DROP and INSERT with materialized views
In case of parallel INSERT (max_insert_threads > 1) it is possible for
VIEW to be DROP/DETACH'ed while building pipeline for various paralell
streams, and in this case the header will not match since when you have
VIEW you will got empty header and non-empty header otherwise.

And this leads to LOGICAL_ERROR later, while checking that output
headers are the same (in QueryPipelineBuilder::addChains() -> Pipe::addChains()).

However it also makes the pipeline different for various parallel
streams, and it looks like it is better to fail in this case, so instead
of always returning empty header from buildChainImpl() explicit check
had been added.

Note, that I wasn't able to reproduce the issue with the added test,
but CI may have more "luck" (although I've verified it manually).

Fixes: #35902
Cc: @KochetovNicolai
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-08-05 13:16:32 +03:00
Alexander Tokmakov
65e1ce8ad1
Merge pull request #39674 from tonickkozlov/tonickkozlov/fix-default-database-resolution
Default database resolution in distributed reads
2022-08-05 13:09:15 +03:00
Alexander Tokmakov
4bf7a2ca3a fix warning 2022-08-05 12:05:50 +02:00
alesapin
329120ca7a
Merge pull request #39755 from ClickHouse/keeper-create-snapshot-on-exit
Create Keeper snapshot on exit
2022-08-05 12:00:16 +02:00
Nikolai Kochetov
2fe893ba67
Merge pull request #25563 from ClickHouse/use-dag-in-key-condition
Use ActionsDAG in KeyCondition
2022-08-05 11:22:46 +02:00
Alexander Tokmakov
d9190a8121
Merge pull request #39872 from ClickHouse/store_cleanup_all_disks
Cleanup unused dirs from `store/` on all disks
2022-08-05 12:21:59 +03:00
Constantine Peresypkin
10c76917ea fix nats-io TLS support
nats-io library needs `NATS_HAS_TLS` define to correctly compile-in TLS
support

fixes #39525
2022-08-05 11:20:05 +02:00
Alexey Milovidov
3130aa7218
Merge pull request #39732 from HarryLeeIBM/hlee-s390x-unaligned
Fix Endian issue in SipHash for s390x
2022-08-05 07:24:57 +03:00
Alexey Milovidov
995e7ab350
Merge pull request #39886 from pzhdfy/fix_netlink_leak
fix potential netlink leak when init fail in TaskStatsInfoGetter
2022-08-05 07:13:59 +03:00
Anton Popov
0492ef63a4
Merge pull request #39464 from CurtizJ/fix-custom-serializations
Fix columns of type `Object` with sparse serialization
2022-08-05 00:55:41 +02:00
Kseniia Sumarokova
ba53ed274b
Merge pull request #39327 from kssenii/update-azure-lib
Update azure library (removed "harmful" function)
2022-08-05 00:20:43 +02:00
Amos Bird
6a3a9dcf96
Fix building aggregate projections when external aggregation is on (#39671) 2022-08-04 23:29:26 +02:00
Robert Schulze
cb146ee6f1
Rename LibraryBridgeHelper to ExternalDictionaryLibraryBridgeHelper
- ExternalDictionaryLibraryBridgeHelper provides the server-side
  interface to access the dictionary part of the library bridge.

- In a later commit, CatBoostLibraryBridgeHelper will be added to access
  the catboost part of the library bridge from the server.
2022-08-04 19:58:37 +00:00
Robert Schulze
20bb8a248e
Prepare server-side BridgeHelper for catboost integration
Wall of text, sorry, but I also had to document some stuff for myself:

There are three ways to communicate data using HTTP:
- the HTTP verb: for our purposes, PUT and GET,
- the HTTP path: '/ping', '/request' etc.,
- the HTTP URL parameter(s), e.g. 'method=libNew&dictionary_id=1234'

The bridge will use different handlers for communication with the
external dictionary library and for communication with the catboost
library. Handlers are created based on a combination of the HTTP verb
and the HTTP method. More specifically, there will be combinations
- GET + '/extdict_ping'
- PUT + '/extdict_request'
- GET + '/catboost_ping'
- PUT + '/catboost_request'.
For each combination, the bridge expects a certain set of URL
parameters, e.g. for the first combination parameter "dictionary_id" is
expected.

Starting with this commit, the library-bridge creates handlers based on
the first two combinations (the latter two combinations will be added
later). This makes the handler creation mechanism consistent with it's
counterpart in xdbc-bridge.

For that, it was necessary to make both IBridgeHelper methods
"getMainURI()" and "getPingURI()" pure virtual so that derived classes
(LibraryBridgeHelper and XDBCBridgeHelper) must provide custom URLs with
custom paths.

Side note 1: Previously, LibraryBridgeHelper sent HTTP URL parameter
"method=ping" during handshake (PING) but the library-bridge ignored
that parameter. We now omit this parameter, i.e.
LibraryBridgeHelper::PING was removed. Again, this makes things
consistent with xdbc-bridge.

Side note 2: xdbc-bridge is unchanged in this commit. Therefore,
XDBCBridgeHelper now uses the HTTP paths previously in the base class.
For funny reason, XDBCBridgeHelper did not use
IBridgeHelper::getMainURI() - it generates the URLs by itself. I kept it
that way for now but provided an implementation of getMainURI() anyways.
2022-08-04 19:29:51 +00:00
Robert Schulze
ea73b98fb9
Prepare library-bridge for catboost integration
- Rename generic file and identifier names in library-bridge to
  something more dictionary-specific. This is needed because later on,
  catboost will be integrated into library-bridge.

- Also: Some smaller fixes like typos and un-inlining non-performance
  critical code.

- The logic remains unchanged in this commit.
2022-08-04 19:26:51 +00:00
Arthur Passos
62d48053c0 Use insertDefault instead of insert(0) 2022-08-04 15:53:44 -03:00
Arthur Passos
c307e9a228 Fix ArrowColumn dictionary to CH low cardinality conversion 2022-08-04 15:34:44 -03:00
Alexander Gololobov
eb3e2ed092
Merge branch 'master' into wait_for_mutation_race 2022-08-04 20:27:09 +02:00
Alexander Gololobov
f5e358ecc5 Make sure that the current replica is the first on the list 2022-08-04 20:26:39 +02:00
Alexander Tokmakov
460f2f2e39 Merge branch 'master' into store_cleanup_all_disks 2022-08-04 19:48:41 +02:00
Yakov Olkhovskiy
23037daf17
Merge branch 'master' into fix-quota-key 2022-08-04 12:14:49 -04:00
Alexander Tokmakov
20cf4e8d22 slightly more readable if conditions 2022-08-04 18:04:06 +02:00
Nikolai Kochetov
60599197b2 Review fixes. 2022-08-04 15:23:10 +00:00
Nikolai Kochetov
658a269d56
Merge branch 'master' into use-dag-in-key-condition 2022-08-04 16:18:40 +02:00
Alexander Tokmakov
6a5171c829
Update DatabaseCatalog.cpp 2022-08-04 17:10:13 +03:00
Alexander Tokmakov
ebbaed46bd Merge branch 'master' into tonickkozlov/fix-default-database-resolution 2022-08-04 15:20:44 +02:00
Antonio Andelic
07a85513e8 Merge branch 'master' into keeper-create-snapshot-on-exit 2022-08-04 13:12:26 +00:00
Antonio Andelic
10d7259c2b Add log for snapshot on exit 2022-08-04 13:12:24 +00:00
Antonio Andelic
c99c5a0dd1 Merge branch 'master' into keeper-block-memory-tracker-commit 2022-08-04 13:04:11 +00:00
Antonio Andelic
0a7d2e7b8a Use LockMemoryExceptionThread 2022-08-04 13:03:05 +00:00
alesapin
1eb28f5f5f
Merge pull request #39860 from ClickHouse/avoid_additional_disk_touch
Better total part size calculation on mutation
2022-08-04 14:21:31 +02:00
Alexander Gololobov
7caf4c210e Update local queue to see current mutation entry 2022-08-04 14:06:19 +02:00
Vladimir C
a627b00c43
Merge branch 'master' into refactor-prepared-sets 2022-08-04 13:27:38 +02:00
Kruglov Pavel
235649cb98
Merge pull request #39458 from Avogar/fix-cancel-insert-into-function
Fix WriteBuffer finalize when cancel insert into function
2022-08-04 13:02:08 +02:00
vdimir
298fb2431d
Fix column not found for push down with join 2022-08-04 10:58:21 +00:00
Antonio Andelic
278921be3b Fix style 2022-08-04 07:25:28 +00:00
Antonio Andelic
fa98338ce1 Add comment for memory tracker blocking 2022-08-04 07:13:42 +00:00
Alexey Milovidov
24ee944986
Update TaskStatsInfoGetter.cpp 2022-08-04 07:34:36 +03:00
Fangyuan Deng
0bf5c3d1a1
Merge branch 'master' into fix_netlink_leak 2022-08-04 11:42:17 +08:00
pzhdfy
848a349e42 fix potential netlink leak when init fail in TaskStatsInfoGetter 2022-08-04 11:37:27 +08:00
Alexey Milovidov
9e46abc560
Merge pull request #39420 from amosbird/better-projection1-fix1
Normalize AggregateFunction types and state representations
2022-08-04 03:06:55 +03:00
Nikolay Degterinsky
71cb055ecc
Merge pull request #39812 from guowangy/applyFunction-multi-thread
KeyCondition: optimize applyFunction in multi-thread scenario
2022-08-04 01:36:47 +02:00
Alexey Milovidov
fe95703a49
Merge pull request #39586 from guowangy/bytes-to-bits-mask
Improve bytes to bits mask transform for SSE/AVX/AVX512
2022-08-04 02:33:58 +03:00
Alexey Milovidov
f474eb957d
Merge pull request #39758 from ClickHouse/tsan_clang_15
Try clang-15 for build with tsan
2022-08-04 01:56:52 +03:00
Kseniia Sumarokova
bd5610b732
Merge branch 'master' into update-azure-lib 2022-08-03 23:00:57 +02:00
Yakov Olkhovskiy
1680be19ca some refactoring 2022-08-03 16:36:52 -04:00
Yakov Olkhovskiy
2e34b384c1 update tcp protocol, add quota_key 2022-08-03 15:44:08 -04:00
Alexander Tokmakov
a269cf29e4 remove unused dirs from store on all disks 2022-08-03 19:49:16 +02:00
Alexander Tokmakov
b8ffaabdd8 add chmod and stat to IDisk 2022-08-03 19:47:36 +02:00
Anton Popov
04f6a85070 fix mutations 2022-08-03 17:34:46 +00:00
Kruglov Pavel
b84e65bb3b
Merge pull request #39716 from arthurpassos/fix_scalar_cte_with_lc_result
Unwrap LC column in IExecutablefunction::executeWithoutSparseColumns
2022-08-03 18:53:37 +02:00
Maksim Kita
e6efb47aa3
Merge pull request #39850 from kitaisreal/select-query-has-join-method
Add hasJoin method into ASTSelectQuery
2022-08-03 18:50:25 +02:00
Nikita Taranov
4943202921
Improve memory usage during memory efficient merging of aggregation results (#39429) 2022-08-03 17:56:59 +02:00
Anton Popov
5da32fafb3 fix ALTER MODIFY COLUMN from nested 2022-08-03 15:08:38 +00:00
Antonio Andelic
56ca93ca3f Block memory tracker in Keeper during commit 2022-08-03 14:14:57 +00:00
root
b2d87a9376 Merge branch 'Structured-Logging-Support' of github.com:ClibMouse/ClickHouse into Structured-Logging-Support 2022-08-03 06:37:00 -07:00
root
d58ae78712 removed default color enable in OwnPatternFormatter constructor calling 2022-08-03 06:30:48 -07:00
Nikita Mikhaylov
f144eae388
Fix typo and extra dots in exception messages from OverCommitTracker (#39858) 2022-08-03 15:23:07 +02:00
Igor Nikonov
9eef299e11
Merge pull request #39103 from tonickkozlov/tonickkozlov/37032/do-not-optimize-functions-shadowing-args
Do not optimize GROUP BY functions that shadow their arguments
2022-08-03 15:06:42 +02:00
alesapin
f608e62c27 Fix call 2022-08-03 14:17:31 +02:00
alesapin
56a4d26e87 Better total part size calculation on mutation 2022-08-03 14:15:45 +02:00
Anton Popov
6b15ee2bd9
Merge pull request #39685 from CurtizJ/hash-functions-map
Allow to execute hash functions with arguments of type `Map`
2022-08-03 13:51:16 +02:00
Antonio Andelic
05467e315f
Merge pull request #39698 from ClickHouse/update-digest-version
Update Keeper version for digest
2022-08-03 13:13:00 +02:00
alesapin
86561509c5
Merge pull request #39673 from ClickHouse/fix-rollback-inconsistency-keeper
Rollback request in Keeper if storing log fails
2022-08-03 13:03:31 +02:00
Maksim Kita
3e6b663020 ASTSelectQuery added hasJoin method 2022-08-03 11:25:45 +02:00
Robert Schulze
00a7c8733b
Merge pull request #39633 from guowangy/filter-vbmi2
ColumnVector: optimize filter with AVX512VBMI2 compress store
2022-08-03 09:23:24 +02:00
Antonio Andelic
cbff608d0b
Merge branch 'master' into update-digest-version 2022-08-03 07:53:38 +02:00
Igor Nikonov
30782a2b05 Test: distinct sorted is not used on const column 2022-08-02 17:44:43 +00:00
Kruglov Pavel
6b2186bfeb
Merge branch 'master' into numbers-schema-inference 2022-08-02 19:34:53 +02:00
Kruglov Pavel
8a351724de
Update settings changes history 2022-08-02 19:31:20 +02:00
Anton Popov
2a5b023b0f
Merge pull request #39800 from CurtizJ/fix-cannot-read-all-data
Fix `CANNOT_READ_ALL_DATA` with `pread_threadpool`.
2022-08-02 16:06:13 +02:00
Nikolay Degterinsky
6405439976
Merge pull request #39558 from evillique/fix-logs
Fix logs rotation issue
2022-08-02 15:49:14 +02:00
Mallik Hassan
87bde54ee5
Merge branch 'ClickHouse:master' into Structured-Logging-Support 2022-08-02 10:44:05 -03:00
root
0fad007220 changing OwnPatternFormatter.cpp to its original version 2022-08-02 06:42:50 -07:00
Anton Popov
a333cc4146 Merge remote-tracking branch 'upstream/master' into HEAD 2022-08-02 12:57:43 +00:00
Anton Popov
2312d8ceea
Merge pull request #39696 from BiteTheDDDDt/fix_0729
fix align of AggregateFunctionDistinct
2022-08-02 14:27:01 +02:00
Arthur Passos
e9b124b4bc Don't use default implementation for LC columns in Scalar functions 2022-08-02 09:17:53 -03:00
Anton Popov
f94d4d4877
Merge branch 'master' into hash-functions-map 2022-08-02 13:26:54 +02:00
Igor Nikonov
56697125d3 Merge remote-tracking branch 'origin/master' into distinct_sorted_simplify 2022-08-02 11:18:46 +00:00
Anton Kozlov
ce70f3dacb fixed 02303_query_kind test; added logging in 02352_grouby_shadows_arg test 2022-08-02 10:50:27 +00:00
Alexander Tokmakov
82b50e79cf
Merge branch 'master' into tsan_clang_15 2022-08-02 13:00:55 +03:00
Alexander Tokmakov
5050e0aca5
Revert "Limit number of analyze for one query" 2022-08-02 12:48:31 +03:00
Nikolai Kochetov
a3bf9496d4
Merge pull request #39799 from ClickHouse/fix-extra-column-after-array-join-optimization
Fix extra column after ARRAY JOIN optimization.
2022-08-02 10:35:35 +02:00
Wangyang Guo
91e3e2f18b KeyCondition: optimize applyFunction in multi-thread scenario
Construct and deconstruct args (ColumnsWithTypeAndName) will inc/dec
ref_count (actually this is a atomic lock inc/dec operation) to share_ptr,
which may share the same DataTypePtr among different threads. This will
have a lock contention issue in large parallel situation.

The patch try to minimize `args` scope and reduce unnecessary
construct/destory of instances. It will improve the performance in
multi-thread cases.
2022-08-02 16:16:16 +08:00
Antonio Andelic
b3b3c371f0
Update KeeperStorage.h 2022-08-02 09:20:02 +02:00
Amos Bird
b98e645ff7
Revert "test what will be wrong if state returns norm type"
This reverts commit 55802099bc.
2022-08-02 11:33:45 +08:00
root
433b961d5c changed code for expected seg fault 2022-08-01 20:21:48 -07:00
Alexey Milovidov
316528817b
Merge pull request #39179 from azat/fsync-profile-events
Add profile events for fsync
2022-08-02 05:44:35 +03:00
Amos Bird
c8aaa32f9c
Revert "Another test"
This reverts commit 69347028c5.
2022-08-02 10:43:48 +08:00
Wangyang Guo
6a7213291b Merge master and resolve conflict 2022-08-02 10:40:40 +08:00
Alexey Milovidov
b1919d045f
Update ThreadPoolReader.cpp 2022-08-02 05:34:14 +03:00
Wangyang Guo
ce3411b0ff Merge master and solve conflict 2022-08-02 10:27:01 +08:00
Nikolay Degterinsky
90b08d6fae
Merge branch 'master' into fix-logs 2022-08-02 02:55:29 +02:00
Anton Popov
64cbecf0c8 fix build on non linux systems 2022-08-02 00:13:20 +00:00
Anton Popov
5d6804dd65
Merge branch 'master' into fix_0729 2022-08-01 21:14:46 +02:00
Amos Bird
69347028c5
Another test 2022-08-02 03:08:25 +08:00
Anton Popov
43e8ca5ba8 fix CANNOT_READ_ALL_DATA with pread_threadpool 2022-08-01 18:40:21 +00:00
Nikolai Kochetov
77c143aa23 Fix extra column after ARRAY JOIN optimization. 2022-08-01 17:56:27 +00:00
Alexey Milovidov
3de747a6e2
Merge pull request #39746 from ClickHouse/cleanup-projection-setting
Cleanup usages of `allow_experimental_projection_optimization` setting, part 1
2022-08-01 19:21:30 +03:00
Alexander Tokmakov
0d68b1c67f fix build with clang-15 2022-08-01 18:00:54 +02:00
Maksim Kita
31891322a5
Merge pull request #39681 from pkit/pkit/executable_settings
add settings for executable table func
2022-08-01 17:59:52 +02:00
Robert Schulze
bf574b9154
Merge pull request #39760 from ClickHouse/bit-fiddling
Use std::popcount, ::countl_zero, ::countr_zero functions
2022-08-01 17:04:51 +02:00
Amos Bird
55802099bc
test what will be wrong if state returns norm type 2022-08-01 21:04:16 +08:00
Amos Bird
8ab475ccf3
Fix another case 2022-08-01 21:04:15 +08:00
Amos Bird
09c99d8440
Fix tests 2022-08-01 21:04:14 +08:00
Amos Bird
f84e5b6827
Allow to format DataTypePtr 2022-08-01 21:04:13 +08:00
Amos Bird
0e746c1afa
More format refactor 2022-08-01 21:04:13 +08:00
Amos Bird
f11d0484f3
Normalize everything else 2022-08-01 21:04:11 +08:00
Anton Popov
8a3ec52b5e
Merge pull request #39752 from CurtizJ/fix-index-analysis
Fix index analysis with tuples and `IN`
2022-08-01 14:41:46 +02:00
Anton Popov
eeb9366010
Merge pull request #39731 from CurtizJ/fix-send-logs-level-test
Fix redirecting of logs to stdout in clickhouse-client
2022-08-01 14:22:49 +02:00
Alexander Tokmakov
80f9ba9186
Merge pull request #39690 from ClickHouse/show-addresses-in-stack-traces
Configuration parameter to hide addresses in stack traces
2022-08-01 14:20:37 +03:00
Kruglov Pavel
1c1e7eb0cd
Fix duplicate lines 2022-08-01 13:16:23 +02:00
Kruglov Pavel
a0d51601bf
Update EscapingRuleUtils.cpp 2022-08-01 13:07:48 +02:00
Kruglov Pavel
dfdfabec94
Merge pull request #39218 from evillique/file_default_value
Add default argument to the function `file`
2022-08-01 13:04:19 +02:00
Kruglov Pavel
42136b7630
Merge pull request #39647 from Avogar/fix-arrow-strings
Fix strings in dictionary in Arrow format
2022-08-01 12:46:07 +02:00
Kruglov Pavel
6457c069a9
Merge pull request #39293 from kssenii/fix-positional-args-case
Fix positional arguments in case of unneeded columns pruning
2022-08-01 12:42:18 +02:00
Antonio Andelic
9ec27c0ab4
Merge pull request #39757 from ClickHouse/fix-rocksdb-filter-with-params
Use params correctly for filtering by key in EmbeddedRocksDB
2022-08-01 12:17:10 +02:00
Wangyang Guo
6a67147584 ColumnVector: refactory to use TargetSpecific::Default::doFilterAligned 2022-08-01 13:41:02 +08:00
Wangyang Guo
b05be56eef ColumnVector: naming style fix 2022-08-01 10:16:15 +08:00
Dmitry Novik
ab5a147065
Merge pull request #38725 from azat/fix-order-by-projection
Fix ORDER BY that matches projections ORDER BY
2022-08-01 00:32:59 +02:00
Robert Schulze
d39259a4c0
More conversions 2022-07-31 22:06:02 +00:00
Azat Khuzhin
3e627e2861 Add profile events for fsync
The following new provile events had been added:

- FileSync - Number of times the F_FULLFSYNC/fsync/fdatasync function was called for files.
- DirectorySync - Number of times the F_FULLFSYNC/fsync/fdatasync function was called for directories.
- FileSyncElapsedMicroseconds - Total time spent waiting for F_FULLFSYNC/fsync/fdatasync syscall for files.
- DirectorySyncElapsedMicroseconds - Total time spent waiting for F_FULLFSYNC/fsync/fdatasync syscall for directories.

v2: rewrite test to sh with retries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-31 23:19:30 +03:00
Nikolai Kochetov
22fbfe19a4 Merge branch 'master' into use-dag-in-key-condition 2022-07-31 21:54:12 +02:00
Alexey Milovidov
ccef227494
Merge pull request #38185 from vdimir/analyze_stuck
Limit number of analyze for one query
2022-07-31 22:53:09 +03:00
kssenii
687f0fabfc Move some dependencies 2022-07-31 20:17:22 +03:00
Robert Schulze
a7734672b9
Use std::popcount, ::countl_zero, ::countr_zero functions
- Introduced with the C++20 <bit> header

- The problem with __builtin_c(l|t)z() is that 0 as input has an
  undefined result (*) and the code did not always check. The std::
  versions do not have this issue.

- In some cases, we continue to use buildin_c(l|t)z(), (e.g. in
  src/Common/BitHelpers.h) because the std:: versions only accept
  unsigned inputs (and they also check that) and the casting would be
  ugly.

(*) https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
2022-07-31 15:16:51 +00:00
Robert Schulze
52d08d9db4
Merge pull request #39520 from ClickHouse/no-split-binary
Remove SPLIT_BINARY
2022-07-31 14:23:31 +02:00
Robert Schulze
0f2177127b
Merge pull request #39751 from ClickHouse/enable-getoskernelversion
Enable SQL function getOSKernelVersion() on all platforms
2022-07-31 14:09:46 +02:00
Nikolai Kochetov
eaeb0446c7
Merge pull request #39705 from ClickHouse/avoid-recursive-dtor-for-ast
Avoid recursive destruction of AST.
2022-07-31 12:59:20 +02:00
Antonio Andelic
eea1aaef2c Use params for filtering by key in EmbeddedRocksDB 2022-07-31 10:44:01 +00:00
Alexander Gololobov
d259c4fa6c
Merge pull request #39747 from ClickHouse/fix-double-escaping-json
Fix double escaping in the metadata of FORMAT JSON
2022-07-31 11:28:25 +02:00
Robert Schulze
4d7627e45e
Fix include 2022-07-31 07:36:40 +00:00
Anton Popov
095e400075 fix index analysis with tuples and IN 2022-07-31 00:38:52 +00:00
Alexey Milovidov
d285648a37
Merge branch 'master' into shell-command-wait-pid-refactoring 2022-07-31 02:57:46 +03:00
Anton Popov
74eb8119ef
Merge branch 'master' into fix-custom-serializations 2022-07-31 01:51:52 +02:00
Alexey Milovidov
22bc89690d
Merge pull request #39222 from azat/fix-http-session
Do not report "Failed communicating with" on and on for parts exchange
2022-07-31 02:24:05 +03:00
Alexey Milovidov
8fb70abe3e
Merge pull request #39178 from azat/dist-insert-log
Add connection info for Distributed sends log message
2022-07-31 02:22:22 +03:00
Robert Schulze
8ca236de08
Enable SQL function getOSKernelVersion() on all platforms
Follow up to PR #38615
2022-07-30 22:36:47 +00:00
Igor Nikonov
83e1dd1172
Merge branch 'master' into ordinary_distinct_small_refact 2022-07-31 00:23:21 +02:00