Commit Graph

11441 Commits

Author SHA1 Message Date
kssenii
0087ad3fe5 Fix test 2024-12-09 11:52:40 +01:00
kssenii
924e274cf2 Merge remote-tracking branch 'origin/master' into disable-metadata-deletion-in-s3-queue 2024-12-06 17:33:30 +01:00
kssenii
9b28d404e2 Review fixes 2024-12-06 17:31:42 +01:00
Kseniia Sumarokova
02f27e53f7
Merge pull request #72858 from ClickHouse/fix-backup-resotre-of-empty-file-with-plain-rewr
Fix backup/restore with plain rewritable disk in case there are empty files in backup
2024-12-06 10:53:16 +00:00
Julia Kartseva
8694ce5456 try fix test_backup_restore_s3 2024-12-05 23:37:29 +00:00
kssenii
13dbd31608 Fix backup/restore of empty file 2024-12-05 19:08:38 +01:00
Mikhail Artemenko
55d6a7f603
Merge pull request #72593 from azat/config-zk-sync
Ensure that ClickHouse will see ZooKeeper changes on config reloads
2024-12-05 17:44:51 +00:00
Mikhail f. Shiryaev
65d895a6db
Merge pull request #72835 from ClickHouse/limit-integration-tests-memory
Limit the docker memory to {HOST_MEM-2G}, preventing OOMs
2024-12-05 15:20:03 +00:00
Vladimir Cherkasov
d88f39c7e9
Merge pull request #67323 from kirillgarbar/ch-disks-remove
Reduce memory usage for removeSharedRecursive operation
2024-12-05 13:58:53 +00:00
Alexander Tokmakov
d22174e3bf
Merge pull request #72685 from ClickHouse/rdb_fix_flatten_nested
Fix flatten_nested when recovering a Replicated database
2024-12-05 13:26:50 +00:00
Mikhail f. Shiryaev
726054d161
Print the argparse help with defaults 2024-12-05 13:15:36 +01:00
Mikhail f. Shiryaev
5b1d454f2e
Make docker container memory a CLI argument 2024-12-05 13:14:33 +01:00
Mikhail f. Shiryaev
9489137e23
Fix typing warnings 2024-12-05 12:39:52 +01:00
Mikhail f. Shiryaev
90d655dd96
Limit the docker memory to {HOST_MEM-2G} 2024-12-05 12:32:43 +01:00
Miсhael Stetsyuk
4346ccb434
Merge pull request #72637 from ClickHouse/startup-scripts-execution-state
add `StartupScriptsExecutionState` metric
2024-12-05 10:43:04 +00:00
Daniil Ivanik
9f425ebe73
Merge pull request #69445 from ClickHouse/divanik/add_schema_evolution_concise
Make simple schema evolution for Iceberg data format
2024-12-05 10:22:55 +00:00
Kseniia Sumarokova
777b016d6a
Merge pull request #72738 from ClickHouse/s3queue-avoid-no-such-key
Fix no-such-key in s3queue in certain case
2024-12-04 22:32:37 +00:00
Azat Khuzhin
1aa320c0ca tests: allow nested with_replace_config()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 22:54:44 +01:00
Kseniia Sumarokova
fe01be106c
Update test.py 2024-12-04 19:38:26 +01:00
Azat Khuzhin
47397a45c5 tests: make test_config_substitutions idempotent
Now the following passed:

    $ bin=$(which clickhouse); g=$PWD; docker run --privileged -it --rm --volume=$bin:/clickhouse --volume=$bin:/usr/share/clickhouse_fresh --volume=/dev/null:/usr/bin/clickhouse-odbc-bridge --volume=/dev/null:/usr/share/clickhouse-odbc-bridge_fresh --volume=$g/programs/server:/clickhouse-config --volume=$g:/ClickHouse --volume=$g/docker/test/integration/runner/compose:/compose:ro --volume=clickhouse-integration-tests:/var/lib/docker -e PYTEST_ADDOPTS='-vvv -s --pdb --count 2 test_config_substitutions/test.py' --name ch clickhouse/integration-tests-runner

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
Azat Khuzhin
f1e909e309 Remove config_reload_sync_zookeeper (issue sync unconditionally)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
Azat Khuzhin
c9291949ba Enable config_reload_sync_zookeeper for test_config_substitutions
This should fix flakiness of `test_config_substitutions/test.py::test_config_multiple_zk_substitutions` [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/71406/af822de0bf896dcb0a28f55889d12611bd38171a/integration_tests__asan__old_analyzer__[1_6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
Azat Khuzhin
ac0fb050f1 Add ability to sync ZooKeeper before reloading the config
Otherwise it is not deterministic wether ClickHouse will see this
change, i.e. if you created znode just before `SYSTEM RELOAD CONFIG` it
is not 100% that the ClickHouse will see it.

Refs: apache/zookeeper@8ee17324ce
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
kssenii
03f44e8920 Merge remote-tracking branch 'origin/master' into disable-metadata-deletion-in-s3-queue 2024-12-04 17:41:26 +01:00
kssenii
7fc60d84cc Better deletion of keeper metadata in s3queue 2024-12-04 17:39:04 +01:00
Kseniia Sumarokova
d9da4e4235
Update test.py 2024-12-04 16:27:11 +01:00
divanik
30ccc96c93 Resolve conflicts 2024-12-04 12:29:09 +00:00
Kseniia Sumarokova
e94a42c576
Update test.py 2024-12-04 11:38:01 +01:00
Antonio Andelic
373d6acbdd
Merge pull request #72730 from ClickHouse/fix-keeper-internal-ssl
Fix advanced SSL configuration for Keeper's internal communication
2024-12-04 08:20:57 +00:00
kssenii
7bee0a4872 Speed up the test 2024-12-03 18:29:50 +01:00
kssenii
bd284fbb0d Add a test 2024-12-03 18:17:25 +01:00
divanik
f1219d3e8e Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/add_schema_evolution_concise 2024-12-03 15:27:45 +00:00
Vladimir Cherkasov
902a42fead
Merge branch 'master' into ch-disks-remove 2024-12-03 14:23:17 +01:00
Antonio Andelic
340b0a9860 Fix style 2024-12-03 13:18:52 +01:00
Antonio Andelic
d65f440679 Fix advanced SSL configuration for Keeper's internal communication 2024-12-03 09:44:17 +01:00
Michael Kolupaev
bc267d4427 Merge remote-tracking branch 'origin/master' into ssett 2024-12-03 06:51:08 +00:00
Yakov Olkhovskiy
617af1d3c0
Merge pull request #71297 from lzydmxy/force-connect-on-retry
Force_connected for retry resume connection establisher
2024-12-03 01:21:31 +00:00
Alexander Tokmakov
12ac21f10f fix flatten_nested when recovering a Replicated db 2024-12-02 11:08:43 +01:00
Raúl Marín
0a5a0a2973
Merge pull request #72402 from Algunenano/keeper_fault
Better error message on bad keeper snapshots
2024-12-02 09:24:16 +00:00
robot-clickhouse
fad3f2ff00 Automatic style fix 2024-11-29 17:54:14 +00:00
Michael Stetsyuk
b512997e50 better test 2024-11-29 17:45:55 +00:00
vdimir
0a5bc248fd
Merge branch 'master' into vdimir/join_select_inner_table 2024-11-29 15:50:25 +00:00
Mikhail Artemenko
b81ee27750
Merge pull request #71406 from azat/automatic-external-aggregation
Automatic GROUP/ORDER BY to disk based on the memory usage
2024-11-29 12:27:43 +00:00
Alexey Katsman
d7167bd103
Merge pull request #72548 from alexkats/dict
Add source query validation for dictionaries
2024-11-29 11:25:40 +00:00
alesapin
d25b15a3b1
Merge pull request #72613 from ClickHouse/nopctest
Remove flaky test_page_cache
2024-11-29 10:16:13 +00:00
Michael Kolupaev
29b722df29 Remove flaky test_page_cache 2024-11-28 21:09:12 +00:00
Pablo Marcos
d8a235b785
Merge pull request #67733 from Zawa-ll/66073-system-load-primary-key-rebase
Added statement `SYSTEM LOAD PRIMARY KEY`
2024-11-28 16:02:31 +00:00
Alex Katsman
23086e1424 Add source query validation for dictionaries 2024-11-28 15:38:07 +00:00
Azat Khuzhin
bdb39a6fef Change logic of automatic ORDER/GROUP BY to be based on available memory
- remove max_bytes_ratio_before_external_{order,group_by}_for_server
- change the way max_bytes_ratio_before_external_{order,group_by} works

Note, that it is not enough to transform ratio to bytes in
executeQuery(), since in this case it will not work for merges and
internal queries, plus, you have to reset them for Distributed engine
and update it for Merge/View/...

This patch also introduce some helpers (see MemoryTrackerUtils) and
adjust Aggregator::Params constructor to accept Settings object instead
of tons of arguments.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-11-28 16:01:53 +01:00
Azat Khuzhin
db1f459cc4 tests: disable test_max_bytes_ratio_before_external_order_group_by_for_server under TSan
The problem is that TSan has some memory overhead which increases
process RSS to 10Gi in the middle of the query and it will fail.
Another option is to avoid syncing with RSS too frequently, but I doubt
that it is significant to run this test under TSan

v1: increase memory to 20Gi
    Fixes: https://s3.amazonaws.com/clickhouse-test-reports/71406/b33be86dee3c7616e9193c339837b9e250810557/integration_tests__tsan__[6_6].html
v2: instead just disable under TSan
    Fixes: https://s3.amazonaws.com/clickhouse-test-reports/71406/df68cf7362d825c3d83991fd74c391a49e73a8b1/integration_tests__tsan__[6_6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-11-28 16:01:53 +01:00