Commit Graph

142566 Commits

Author SHA1 Message Date
Dmitry Novik
2458defd01 Analyzer: Forbid WINDOW redefinition 2024-05-13 15:16:35 +02:00
Antonio Andelic
449aacb3d0
Correct 2024-05-13 15:08:52 +02:00
MikhailBurdukov
cfa0aa772e
Merge branch 'master' into truncate_for_obj_storage_disks 2024-05-13 16:05:44 +03:00
Antonio Andelic
2b38b8a97b
Correct byte count 2024-05-13 14:49:26 +02:00
Dmitry Novik
5e1a3b5601
Update src/Interpreters/InterpreterSelectQueryAnalyzer.cpp 2024-05-13 14:48:33 +02:00
Igor Nikonov
aff8bea1e6 selectRangesToRead() simple cleanup 2024-05-13 12:47:19 +00:00
MikhailBurdukov
7d0214018c Enable truncate operation for object storage disks. 2024-05-13 12:46:42 +00:00
divanik
dc8f8a9a18 Resolve several issues 2024-05-13 12:37:03 +00:00
Nikolai Kochetov
bb9652998b Another attemtp. 2024-05-13 12:26:10 +00:00
Mikhail f. Shiryaev
baffd31423
Fix typos 2024-05-13 14:21:15 +02:00
Mikhail f. Shiryaev
dab1e5002e
Upgrade the runner version to the latest 2024-05-13 14:21:14 +02:00
Mikhail f. Shiryaev
599c512e0b
Patch runner helpers and check the exit code for attempts 2024-05-13 14:21:13 +02:00
Mikhail f. Shiryaev
cbf02f69d5
Add a fallback for autoupdate if GH actions runner fails to start 2024-05-13 14:21:13 +02:00
Mikhail f. Shiryaev
ee49e237da
Clean github runner's temporary _work derectory between runs 2024-05-13 14:21:12 +02:00
Mikhail f. Shiryaev
b74ce036fa
Make init-network.sh sourceable, tune runner's tailscale hostname 2024-05-13 14:21:11 +02:00
Maksim Kita
fefd071ec7 Fixed tests 2024-05-13 15:20:02 +03:00
divanik
faef8807d2 Resolve conflicts 2024-05-13 12:04:06 +00:00
divanik
d468a0a577 Add archives reading support to s3 2024-05-13 12:00:15 +00:00
Azat Khuzhin
599fce53e3 Fix compiling FunctionsConversion.cpp (by properly passing -g0)
CI reports [1]:

    May 11 20:27:25 FAILED: src/CMakeFiles/dbms.dir/Functions/FunctionsConversion.cpp.o
    May 11 20:27:25 prlimit --as=10000000000 --data=5000000000 --cpu=1800 /usr/bin/sccache /usr/bin/clang++-17 --target=riscv64-linux-gnu --sysroot=/build/cmake/linux/../../contrib/sysroot/linux-riscv64 -DANNOYLIB_MULTITHREADED_BUILD -DBOOST_ASIO_HAS_STD_INVOKE_RESULT=1 -DBOOST_ASIO_STANDALONE=1 -DBOOST_TIMER_ENABLE_DEPRECATED=1 -DCONFIGDIR=\"\" -DDUMMY_BACKTRACE -DENABLE_ANNOY -DENABLE_MULTITARGET_CODE=1 -DENABLE_USEARCH -DHAVE_BZLIB_H=1 -DHAVE_CONFIG_H -DHAVE_FUTIMESAT=1 -DHAVE_ICONV=1 -DHAVE_LIBLZMA=1 -DHAVE_LIBZSTD=1 -DHAVE_LIBZSTD_COMPRESSOR=1 -DHAVE_LINUX_FS_H=1 -DHAVE_LINUX_TYPES_H=1 -DHAVE_LZMA_H=1 -DHAVE_STRUCT_STAT_ST_MTIM_TV_NSEC=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_ZLIB_H=1 -DHAVE_ZSTD_H=1 -DINCBIN_SILENCE_BITCODE_WARNING -DLIBSASL_EXPORTS=1 -DLZ4_DISABLE_DEPRECATE_WARNINGS=1 -DLZ4_FAST_DEC_LOOP=1 -DMAJOR_IN_SYSMACROS=1 -DOBSOLETE_CRAM_ATTR=1 -DOBSOLETE_DIGEST_ATTR=1 -DPLUGINDIR=\"\" -DPOCO_ENABLE_CPP11 -DPOCO_HAVE_FD_EPOLL -DPOCO_OS_FAMILY_UNIX -DSASLAUTHD_CONF_FILE_DEFAULT=\"\" -DSNAPPY_CODEC_AVAILABLE -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -DUSE_CLICKHOUSE_THREADS=1 -DWITH_COVERAGE=0 -DWITH_GZFILEOP -DZLIB_COMPAT -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I/build/build_docker/includes/configs -I/build/src -I/build/build_docker/src -I/build/build_docker/src/Core/include -I/build/base/base/.. -I/build/build_docker/base/base/.. -I/build/contrib/cctz/include -I/build/contrib/re2 -I/build/base/pcg-random/. -I/build/contrib/libfiu/libfiu -I/build/contrib/libssh/include -I/build/build_docker/contrib/libssh/include -I/build/contrib/miniselect/include -I/build/contrib/zstd/lib -I/build/contrib/pocketfft -I/build/contrib/libarchive-cmake -I/build/contrib/libarchive/libarchive -I/build/build_docker/contrib/cyrus-sasl-cmake -I/build/contrib/lz4/lib -isystem /build/contrib/llvm-project/libcxx/include -isystem /build/contrib/llvm-project/libcxxabi/include -isystem /build/contrib/libunwind/include -isystem /build/contrib/libdivide-cmake/. -isystem /build/contrib/libdivide -isystem /build/contrib/jemalloc-cmake/include -isystem /build/contrib/llvm-project/llvm/include -isystem /build/build_docker/contrib/llvm-project/llvm/include -isystem /build/contrib/abseil-cpp -isystem /build/contrib/croaring/cpp -isystem /build/contrib/croaring/include -isystem /build/contrib/sparsehash-c11 -isystem /build/contrib/incbin -isystem /build/contrib/cityhash102/include -isystem /build/contrib/boost -isystem /build/base/poco/Net/include -isystem /build/base/poco/Foundation/include -isystem /build/base/poco/NetSSL_OpenSSL/include -isystem /build/base/poco/Crypto/include -isystem /build/contrib/openssl-cmake/linux_riscv64/include -isystem /build/contrib/openssl/include -isystem /build/base/poco/Util/include -isystem /build/base/poco/JSON/include -isystem /build/base/poco/XML/include -isystem /build/contrib/replxx/include -isystem /build/contrib/fmtlib-cmake/../fmtlib/include -isystem /build/contrib/magic_enum/include -isystem /build/contrib/double-conversion -isystem /build/contrib/dragonbox/include -isystem /build/contrib/zlib-ng -isystem /build/build_docker/contrib/zlib-ng-cmake -isystem /build/contrib/pdqsort -isystem /build/contrib/xz/src/liblzma/api -isystem /build/contrib/aws/src/aws-cpp-sdk-core/include -isystem /build/build_docker/contrib/aws-cmake/include -isystem /build/contrib/aws/generated/src/aws-cpp-sdk-s3/include -isystem /build/contrib/aws-c-auth/include -isystem /build/contrib/aws-c-common/include -isystem /build/contrib/aws-c-io/include -isystem /build/contrib/aws-crt-cpp/include -isystem /build/contrib/aws-c-mqtt/include -isystem /build/contrib/aws-c-sdkutils/include -isystem /build/contrib/azure/sdk/core/azure-core/inc -isystem /build/contrib/azure/sdk/identity/azure-identity/inc -isystem /build/contrib/azure/sdk/storage/azure-storage-common/inc -isystem /build/contrib/azure/sdk/storage/azure-storage-blobs/inc -isystem /build/contrib/snappy -isystem /build/build_docker/contrib/snappy-cmake -isystem /build/contrib/libbcrypt -isystem /build/contrib/msgpack-c/include -isystem /build/build_docker/contrib/liburing/src/include-compat -isystem /build/build_docker/contrib/liburing/src/include -isystem /build/contrib/liburing/src/include -isystem /build/contrib/fast_float/include -isystem /build/contrib/librdkafka-cmake/include -isystem /build/contrib/librdkafka/src -isystem /build/build_docker/contrib/librdkafka-cmake/auxdir -isystem /build/contrib/cppkafka/include -isystem /build/contrib/nats-io/src -isystem /build/contrib/nats-io/src/adapters -isystem /build/contrib/nats-io/src/include -isystem /build/contrib/nats-io/src/unix -isystem /build/contrib/libuv/include -isystem /build/contrib/krb5/src/include -isystem /build/build_docker/contrib/krb5-cmake/include -isystem /build/contrib/NuRaft/include -isystem /build/base/poco/MongoDB/include -isystem /build/base/poco/Redis/include -isystem /build/contrib/icu/icu4c/source/i18n -isystem /build/contrib/icu/icu4c/source/common -isystem /build/contrib/capnproto/c++/src -isystem /build/contrib/avro/lang/c++/api -isystem /build/contrib/google-protobuf/src -isystem /build/contrib/s2geometry/src -isystem /build/contrib/s2geometry-cmake -isystem /build/contrib/AMQP-CPP/include -isystem /build/contrib/AMQP-CPP -isystem /build/contrib/sqlite-amalgamation -isystem /build/contrib/rocksdb/include -isystem /build/contrib/libpqxx/include -isystem /build/contrib/libpq -isystem /build/contrib/libpq/include -isystem /build/contrib/libstemmer_c/include -isystem /build/contrib/wordnet-blast -isystem /build/contrib/lemmagen-c/include -isystem /build/contrib/ulid-c/include -isystem /build/contrib/simdjson/include -isystem /build/contrib/rapidjson/include -isystem /build/contrib/consistent-hashing -isystem /build/contrib/annoy/src -isystem /build/contrib/FP16/include -isystem /build/contrib/robin-map/include -isystem /build/contrib/SimSIMD-map/include -isystem /build/contrib/usearch/include --gcc-toolchain=/build/cmake/linux/../../contrib/sysroot/linux-riscv64 -fdiagnostics-color=always -Xclang -fuse-ctor-homing -Wno-enum-constexpr-conversion -fsized-deallocation  -gdwarf-aranges -pipe -fasynchronous-unwind-tables -ffile-prefix-map=/build=. -ftime-trace -falign-functions=32 -ffp-contract=off  -fdiagnostics-absolute-paths -fstrict-vtable-pointers -Wall -Wextra -Wframe-larger-than=65536 -Weverything -Wpedantic -Wno-zero-length-array -Wno-c++98-compat-pedantic -Wno-c++98-compat -Wno-c++20-compat -Wno-sign-conversion -Wno-implicit-int-conversion -Wno-implicit-int-float-conversion -Wno-ctad-maybe-unsupported -Wno-disabled-macro-expansion -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-padded -Wno-switch-enum -Wno-undefined-func-template -Wno-unused-template -Wno-vla -Wno-weak-template-vtables -Wno-weak-vtables -Wno-thread-safety-negative -Wno-enum-constexpr-conversion -Wno-unsafe-buffer-usage -Wno-switch-default -O2 -g -DNDEBUG -O3 -g  -fno-pie -std=c++23   -D OS_LINUX -Werror -Wno-deprecated-declarations -Wno-poison-system-directories -nostdinc++ -MD -MT src/CMakeFiles/dbms.dir/Functions/FunctionsConversion.cpp.o -MF src/CMakeFiles/dbms.dir/Functions/FunctionsConversion.cpp.o.d -o src/CMakeFiles/dbms.dir/Functions/FunctionsConversion.cpp.o -c /build/src/Functions/FunctionsConversion.cpp
    May 11 20:27:25 sccache: warning: The server looks like it shut down unexpectedly, compiling locally instead

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/63632/e795e0e028d45b654e099dee136a44e7ac5ed627/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 13:53:44 +02:00
Mark Needham
13b2980761
Explain map insertion order 2024-05-13 11:59:47 +01:00
Yarik Briukhovetskyi
df9961f266
rename function 2024-05-13 12:46:21 +02:00
Maksim Kita
b8c719f866 Analyzer view read only necessary columns 2024-05-13 13:41:47 +03:00
Antonio Andelic
e65dd3d939 Cancel S3 reads properly when parallel reads are used 2024-05-13 12:36:29 +02:00
Vitaly Baranov
6c0450f8ff
Merge pull request #62685 from azat/yaml-cpp-merge-key
Bump yaml-cpp for YAML Merge Key support
2024-05-13 09:49:25 +00:00
vdimir
f0704624fc
fix test 2024-05-13 09:40:18 +00:00
Igor Nikonov
033155d8fa Parallel replicas: simple cleanup 2024-05-13 09:05:42 +00:00
Azat Khuzhin
a4e1ddc95a Link dbms to ZooKeeper examples
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
7261f924bb Exclude FunctionsConversion from the large objects check for now
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
5d7d9e9e34 Provide ThreadStatus::initGlobalProfiler() for standalone keeper build
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
44f77fe9f5 Link dbms for zookeeper examples
Since it uses ZooKeeper, which has ThreadFromGlobalPool inside, which
requires THreadPool with enabled profiler, which requires
ThreadStatusExt.cpp, which included only into dbms, but not into
clickhouse_common_io (like ThreadStatus.cpp)

Error:

    FAILED: src/Common/ZooKeeper/examples/zkutil_test_commands_new_lib
    ld.lld-17: error: undefined symbol: DB::ThreadStatus::initGlobalProfiler(unsigned long, unsigned long)
    >>> referenced by ThreadPool.h:243 (./src/Common/ThreadPool.h:243)
    >>>               ZooKeeperImpl.cpp.o:(void std::__1::__function::__policy_invoker<void ()>::__call_impl<std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true, true>::ThreadFromGlobalPoolImpl<Coordination::ZooKeeper::ZooKeeper(std::__1::vector<Coordination::ZooKeeper::Node, std::__1::allocator<Coordination::ZooKeeper::Node>> const&, zkutil::ZooKeeperArgs const&, std::__1::shared_ptr<DB::ZooKeeperLog>)::$_0>(Coordination::ZooKeeper::ZooKeeper(std::__1::vector<Coordination::ZooKeeper::Node, std::__1::allocator<Coordination::ZooKeeper::Node>> const&, zkutil::ZooKeeperArgs const&, std::__1::shared_ptr<DB::ZooKeeperLog>)::$_0&&)::'lambda'(), void ()>>(std::__1::__function::__policy_storage const*)) in archive src/Common/ZooKeeper/libclickhouse_common_zookeeper_no_log.a

Another way of fixing it is to provide some define wich default value
for "is profiler enabled" for ThreadPool, should work, but will be
tricky.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
d743285417 Fix undefined symbol createFunctionBaseCast() during linking examples
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
4ad88d04b4 Move initGlobalProfiler() into ThreadStatusExt.cpp and fix examples
To avoid undefined references in examples:

    May 11 01:58:40 ld.lld-17: error: undefined symbol: DB::Context::hasTraceCollector() const
    May 11 01:58:40 >>> referenced by ThreadStatus.cpp:132 (/build/src/Common/ThreadStatus.cpp:132)
    May 11 01:58:40 >>>               ThreadStatus.cpp.o:(DB::ThreadStatus::initGlobalProfiler(unsigned long, unsigned long)) in archive src/libclickhouse_common_iod.a
    May 11 01:58:40 clang++-17: error: linker command failed with exit code 1 (use -v to see invocation)

Move it firstly into ThreadStatusExt and then do not try to use it from
the ThreadPool.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
11f1d9a30e Remove extra includes of ThreadPool.h in tests
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
0b270a67cf Fix disabling global profilers for keeper standalone build
CLICKHOUSE_KEEPER_STANDALONE_BUILD does not set while compiling
ThreadStatus.cpp, but it linked to the clickhouse-keeper standalone
build, and before this patch it simply leads to the linking error [1]:

    May 10 20:02:58 ld.lld-17: error: undefined symbol: DB::Context::hasTraceCollector() const
    May 10 20:02:58 >>> referenced by ThreadStatus.cpp:132 (./build_docker/./src/Common/ThreadStatus.cpp:132)
    May 10 20:02:58 >>>               lto.tmp:(DB::ThreadStatus::initGlobalProfiler(unsigned long, unsigned long))
    May 10 20:02:58 clang++-17: error: linker command failed with exit code 1 (use -v to see invocation)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/63632/643061bd9d7ef16641ea9537be868fc39d029726/clickhouse_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:36 +02:00
Azat Khuzhin
90b8ae0f0b Ignore global profiler if system.trace_log is not enabled
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-13 11:05:35 +02:00
Salvatore Mesoraca
6a94ba370a
Fix clang-tidy errors 2024-05-13 09:43:03 +02:00
Alexey Milovidov
f27a0d6801
Merge pull request #60469 from ClickHouse/clang-18-ci
Use clang-18 in CI
2024-05-13 09:35:45 +02:00
v01dxyz
8e63d2f795 Compress STDOUT if redirected to file with a compression extension
* Add a new member to ClientBase: default_output_compression_method
* Move the code to get file path from file descriptor to a separate
  Common function.

The stateless test is almost a copy-paste of 02001_compress_output_file.

Fixes https://github.com/ClickHouse/ClickHouse/issues/63496
2024-05-13 09:21:01 +02:00
Alexey Milovidov
4eb42bba8f Fix test 2024-05-13 07:16:26 +02:00
Alexey Milovidov
b3e6259a3c Fix test 2024-05-13 02:41:14 +02:00
Alexey Milovidov
2d138d3d7e
Merge pull request #63674 from nickitat/remove_monotonous_func_optimisation_leftovers
Remove leftovers of `optimize_monotonous_functions_in_order_by`
2024-05-12 22:29:52 +00:00
Alexey Milovidov
9c21066c9b Useless changes 2024-05-13 00:26:18 +02:00
Alexey Milovidov
034256b405 Fix test 2024-05-13 00:25:29 +02:00
Alexey Milovidov
c2caaf007c Merge branch 'master' into clang-18-ci 2024-05-13 00:24:06 +02:00
Кирилл Гарбар
5f2228cd16 Fix test 2024-05-13 00:35:38 +03:00
Alexey Milovidov
7cb10c19f9
Merge pull request #63672 from ClickHouse/fix-test-part_log_bytes_uncompressed
Fix bad test `02950_part_log_bytes_uncompressed`
2024-05-12 20:13:14 +00:00
Nikita Taranov
68d9e55302 impl 2024-05-12 20:38:43 +01:00
Alexey Milovidov
bf31d12dc8 Fix bad test 02950_part_log_bytes_uncompressed 2024-05-12 18:54:57 +02:00
Alexey Milovidov
bf0040f383 Debug a test 2024-05-12 18:48:05 +02:00
Alexey Milovidov
c44e42dd7a Useless changes 2024-05-12 18:22:41 +02:00