Commit Graph

3428 Commits

Author SHA1 Message Date
alexey-milovidov
c696354dd4
Merge pull request #12115 from ianton-ru/disk-type-in-system-disks
Add type column in system.disks
2020-07-05 01:04:17 +03:00
alexey-milovidov
f8a43d5e07
Update formatDateTime.cpp 2020-07-05 01:00:30 +03:00
Alexey Milovidov
731d92657d Remove harmful code from "geoDistance" #12117 2020-07-05 00:57:57 +03:00
alexey-milovidov
e05283d5d3
Merge pull request #12060 from ClickHouse/fix-12053
Check wrong type for filter.
2020-07-04 23:46:34 +03:00
alexey-milovidov
cf1967bb29
Merge pull request #12089 from ClickHouse/fix-11595
Fix result_rows and result_bytes metrics for selects.
2020-07-04 23:41:51 +03:00
alexey-milovidov
c6def5f14b
Merge pull request #12108 from ClickHouse/fix-12086
Fix Parquet for LowCardinality
2020-07-04 23:39:38 +03:00
Alexey Milovidov
c4b6c780c6 Merge branch 'master' into fix-constraints 2020-07-04 23:36:48 +03:00
Alexey Milovidov
918e979449 Merge branch 'master' into fix-if-fixed-string 2020-07-04 22:00:27 +03:00
vivarum
d387fa719e New ISO8601 year modificators for formatDateTime 2020-07-04 21:54:42 +03:00
alexey-milovidov
f1151ed474
Merge pull request #12133 from ClickHouse/normalize-pid-file
Normalize "pid" file handling #3501
2020-07-04 21:36:27 +03:00
alexey-milovidov
d9ea8cfc42
Update StatusFile.cpp 2020-07-04 16:57:04 +03:00
Alexey Milovidov
176a7f2f72 Normalize "pid" file handling #3501 2020-07-04 16:54:24 +03:00
Anton Popov
73676f5022
Improve performace of reading in order of sorting key. (#11696)
* simplify reading in order of sorting key

* add perf test for reading many parts

* Revert "simplify reading in order of sorting key"

This reverts commit 7267d7c46e.

* add threshold for preliminary merge for reading in order

* better threshold

* limit threads in test
2020-07-04 15:48:51 +03:00
Matwey V. Kornilov
caafbe19a4 Add missed <atomic> include in ProxyListConfiguration 2020-07-04 15:32:02 +03:00
alesapin
a2b6d58053
Merge pull request #11069 from kssenii/add-storage-rabbitmq-read-only
Add storage RabbitMQ
2020-07-04 10:38:50 +03:00
alesapin
bfa8cdc7a4
Move skip lists for tests to skip_list.json file (#12107)
* Add unbundled mode flag

* Move skip lists to clickhouse-test

* More verbose message about skip

* Make skip-list optional

* Update clickhouse-test
2020-07-04 10:35:45 +03:00
alesapin
8dc204350f
Fix version column in replicated version collapsing merge tree (#12121) 2020-07-04 10:35:17 +03:00
alexey-milovidov
6677e0a503
Merge pull request #12073 from zhang2014/feature/atfer_column_modify_column
ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN
2020-07-03 22:54:05 +03:00
Vitaly Baranov
ab343132de Fix handling dependency of table with ENGINE=Dictionary on dictionary. 2020-07-03 22:05:53 +03:00
Mikhail Filimonov
6e599533a7 Add missing query context for system logs
Needed to allow attaching materialized views with joins or with
subqueries to system.logs.
2020-07-03 19:19:32 +02:00
Nikita Mikhaylov
5c97106ea3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into Avogar_orc_output_format 2020-07-03 18:00:28 +03:00
Nikita Mikhaylov
fba02badcb fix test with UBSan 2020-07-03 17:53:54 +03:00
Vitaly Baranov
929d652297
Merge pull request #12083 from vitlibar/improve-revoke-command
Improve REVOKE command
2020-07-03 17:17:36 +03:00
Nikolai Kochetov
8349afa4ad Try fix tests. 2020-07-03 16:38:35 +03:00
Alexander Kuzmenkov
e7e4d29a54 more fuzzing 2020-07-03 15:52:16 +03:00
Anton Ivashkin
23b44ca6fe Add type column in system.disks 2020-07-03 15:45:54 +03:00
Guillaume Tassery
027c6b705f Create initializeAggregation to initialize an aggregation function based on a value 2020-07-03 19:18:47 +07:00
Nikolai Kochetov
6d08b7b45a Remove LC converting to Arrow. 2020-07-03 14:04:36 +03:00
Nikolai Kochetov
3d37a63247 Remove LC converting to Arrow. 2020-07-03 13:37:55 +03:00
Nikolai Kochetov
b3f1842035 Remove LC converting to Arrow. 2020-07-03 13:35:44 +03:00
alesapin
0a6f3ca9fd Add unbundled mode flag 2020-07-03 13:11:16 +03:00
Nikolai Kochetov
5e8d5bc8c0 Fix overlimiting the nuber of threads for union. 2020-07-03 11:10:52 +03:00
alesapin
c57edd2018 Tiny fixes 2020-07-03 11:02:35 +03:00
Nikolai Kochetov
17c89f3fe0
Merge pull request #12085 from ClickHouse/fix-11937
Fix limiting the number of threads for VIEW.
2020-07-03 10:35:04 +03:00
Azat Khuzhin
bd5e5e9462 kafka: remove outdated comment
As stated by @filimonov it is not relevant (after #11599)
2020-07-03 09:23:39 +03:00
Azat Khuzhin
de8bc99d48 kafka: avoid superior polling after DROP/DETACH TABLE
Before this patch isStalled() was checked before polledDataUnusable(),
and after DROP TABLE isStalled() == true (although this looks tricky).
2020-07-03 09:23:39 +03:00
Azat Khuzhin
8508200020 kafka: improve logging during engine shutdown
This will help with tracking possible issues, when you need to know was
buffer released or not.
2020-07-03 09:23:39 +03:00
Azat Khuzhin
e7179c402c kafka: check that the data is still usable after parsing 2020-07-03 09:23:38 +03:00
Azat Khuzhin
6104872cae kafka: fix SIGSEGV on DROP TABLE
After #11599 it is possible that messages of the
ReadBufferFromKafkaConsumer will be cleaned-up right in
read_kafka_message callback (from KafkaBlockInputStream) if the stop
flag isset (i.e. DROP TABLE is waiting the consumer), and if
read_kafka_message already processed some rows it will not return 0 and
the loop after will try to get current topic from the buffer, which uses
messages in the underlying and this will got SIGSEGV:

    12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue
    12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup
    12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11
    12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ########################################
    12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11)
    12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object.
    12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace:
    12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse

55421 thread (shows that it still waiting for deactivation):

    5  std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90
    6  DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59
    7  DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821

And just in case thread where read_kafka_message is called:

    0  DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491
    1  DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59
    2  DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81
    3  DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945
    4  DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222
    5  DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218
    6  DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64
    7  DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48
    8  DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826
    9  DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340

Cc: @filimonov
2020-07-03 09:22:44 +03:00
Anton Popov
4422df2e37 Merge remote-tracking branch 'upstream/master' into HEAD 2020-07-02 20:18:21 +03:00
alesapin
c6c7ee30d9 Less race conditions 2020-07-02 19:44:04 +03:00
Anton Popov
a5cbeda1e3 fix segfault with -StateResample combinators 2020-07-02 19:13:42 +03:00
Nikolai Kochetov
3f51419889 Fix tests. 2020-07-02 18:26:44 +03:00
Nikolai Kochetov
e7ab4df148 Fix result_rows and result_bytes metrics for selects. 2020-07-02 18:00:37 +03:00
Nikolai Kochetov
57d727d078 Fix result_rows and result_bytes metrics for selects. 2020-07-02 17:51:10 +03:00
alesapin
96df2e6b71 Better shutdown and conversion 2020-07-02 17:35:10 +03:00
alexey-milovidov
82061da77c
Merge pull request #12040 from azat/dist-fixes
Tiny fixes for distributed queries
2020-07-02 17:02:56 +03:00
alesapin
64583ceb22 Merge branch 'master' into add-storage-rabbitmq-read-only 2020-07-02 16:08:29 +03:00
Anton Popov
71059e4dff
Merge pull request #12062 from nvartolomei/nv/set-index-tuple-types
Try fix pk in tuple performance
2020-07-02 15:51:03 +03:00
Nikolai Kochetov
6527e04ec3 Fix limiting the number of threads for VIEW. 2020-07-02 15:35:51 +03:00
alesapin
f87c3af097
Merge pull request #12055 from ClickHouse/fix-9766
Fix arrayMap with Tuple(LowCardinality) argument
2020-07-02 13:40:05 +03:00
alesapin
65dae99c12
Merge pull request #12056 from ClickHouse/fix-11808
Fix defaultValueOfArgumentType
2020-07-02 13:35:38 +03:00
alesapin
cec02d15ed
Merge pull request #12067 from excitoon-favorites/betters3logs
Moved useless S3 logging to TRACE level
2020-07-02 13:21:55 +03:00
Vitaly Baranov
03b36c262e Improve REVOKE command: now it requires only grant/admin option for only
access which will be revoked.
REVOKE ALL FROM user1 now revokes all granted roles.
2020-07-02 12:54:24 +03:00
Nikolai Kochetov
924f1dfc46 Allow to parse EXPLAIN PLAN. 2020-07-02 11:40:41 +03:00
Nikolai Kochetov
79cd33a567 Fix tests. 2020-07-02 10:44:47 +03:00
Alexander Kazakov
cc2cadb7f5
Merge pull request #11893 from excitoon-favorites/autostartmoves
In *MergeTree: Parts moving task shall be started if new storage policy needs them
2020-07-02 10:44:38 +03:00
zhang2014
9ed5c6d925 ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN 2020-07-01 22:58:52 +08:00
Vitaly Baranov
811d124a82
Merge pull request #12002 from vitlibar/fix-partial-revokes
Fix partial revokes
2020-07-01 17:15:01 +03:00
Nicolae Vartolomei
3854ce6d84 Rewrite Set lookup to make it more readable 2020-07-01 15:05:54 +01:00
Nicolae Vartolomei
f8ceca6942 Remove const specifier to allow auto-move (clangtidy) 2020-07-01 15:04:08 +01:00
hcz
e284bf83d0 Optimize and fix 2020-07-01 11:21:53 +08:00
Vladimir Chebotarev
a541683efa Moved useless S3 logging to TRACE level. 2020-07-01 01:04:30 +03:00
Anton Popov
68c9896fa2 fix arcadia build 2020-07-01 00:15:39 +03:00
Anton Popov
d45697a1b5 in-memory-parts: lazy creation of WAL 2020-06-30 21:47:12 +03:00
alexey-milovidov
948af0bfc5
Merge pull request #12045 from ClickHouse/fix_loading_of_tables
Parse metadata in parallel when loading tables
2020-06-30 21:16:40 +03:00
Nikolai Kochetov
3585700506 Fix tests. 2020-06-30 19:41:43 +03:00
Vitaly Baranov
c39eb8f71b Fix partial revokes (complex cases). 2020-06-30 18:47:02 +03:00
Nicolae Vartolomei
8f1845185e Try fix pk in tuple performance
Possible approach for fixing #10574

The problem is that prepared sets are built correctly, it is a hash map of key -> set
where key is a hash of AST and list of data types (when we a list of
tuples of literals).

However, when the key is built from the index to try and find if there
exists a prepared set that would match it looks for data types of the
primary key (see how data_types is populated) because the primary key
has only one field (v in my example) it can not find the prepared set.

The patch looks for any prepared indexes where data types match for the
subset of fields found in primary key, we are not interested in other
fields anyway for the purpose of primary key pruning.
2020-06-30 16:33:38 +01:00
Vitaly Baranov
40942a2164
Merge pull request #12031 from vitlibar/fix-access-rights-if-allow_introspection_functions-is-0
Fix calculation of access rights when allow_introspection_functions = 0
2020-06-30 18:32:18 +03:00
Nikolai Kochetov
ddc231b088 Check type of filter for prewhere. 2020-06-30 17:58:11 +03:00
Nikolai Kochetov
e3aede57c6 Check type of filter for prewhere. 2020-06-30 17:48:00 +03:00
Nikolai Kochetov
18059e9289 Check type of filter for prewhere. 2020-06-30 17:44:49 +03:00
Nikolai Kochetov
66da0733ab Check type of filter for prewhere. 2020-06-30 17:20:27 +03:00
Nikita Mikhaylov
c45a054f65 fix clang-tidy 2020-06-30 16:06:35 +03:00
Vladimir Chebotarev
bb8da71eff Moves task shall be started if new storage policy needs them. 2020-06-30 15:36:44 +03:00
alexey-milovidov
81b43dc481
Merge pull request #12020 from ClickHouse/fix-collations-order-by-tuple-const
Fix ORDER BY tuple with COLLATE on const column
2020-06-30 15:09:57 +03:00
alexey-milovidov
08b6ca19d8
Merge pull request #12043 from ClickHouse/topk-enum
Make topK return Enum for Enum types
2020-06-30 15:08:42 +03:00
Nikita Mikhaylov
b74b27854a yet another try 2020-06-30 14:38:09 +03:00
Nikolai Kochetov
e8ee5176cd Fix defaultValueOfArgumentType 2020-06-30 14:29:50 +03:00
Artem Zuikov
29178e26da
fix low card types in merge join (#12035) 2020-06-30 14:13:43 +03:00
Nikolai Kochetov
820d2c63df Try fix labda tuple(LC) argument. 2020-06-30 13:51:17 +03:00
Nikolai Kochetov
be51741566 Try fix labda tuple(LC) argument. 2020-06-30 13:19:06 +03:00
Nikita Mikhaylov
7c828861da fix arcadia 2020-06-30 13:18:38 +03:00
Alexander Kuzmenkov
3a50b81e31 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-30 12:25:52 +03:00
Alexander Kuzmenkov
5c417f45b8 streaming wip 2020-06-30 12:25:23 +03:00
Alexander Kuzmenkov
aa8461e996
Update ThreadProfileEvents.cpp 2020-06-30 10:47:19 +03:00
Alexander Kuzmenkov
1d838b7b3a
Update ThreadProfileEvents.cpp 2020-06-30 09:56:11 +03:00
Alexander Kuzmenkov
67a28971e8 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-30 09:09:36 +03:00
Vladimir Chebotarev
8128ca10f4 Switched paths in S3 metadata to relative. 2020-06-30 07:59:22 +03:00
kssenii
f797efb04c Fix build 2020-06-30 01:48:11 +00:00
Alexey Milovidov
a23df81dd5 Fix error 2020-06-30 03:53:30 +03:00
Alexander Tokmakov
987e64acfe parse metadata in parallel when loading tables 2020-06-30 03:12:16 +03:00
Alexey Milovidov
15cddc3c6e Make topK return Enum for Enum types 2020-06-30 02:17:20 +03:00
Alexey Milovidov
d97cb1e7b4 Fix constraints check for constant columns 2020-06-30 01:54:20 +03:00
Alexey Milovidov
5a35ff8938 Merge branch 'master' of github.com:yandex/ClickHouse into fix-collations-order-by-tuple-const 2020-06-30 01:51:04 +03:00
Alexey Milovidov
1194863b3d Fix error 2020-06-30 01:50:26 +03:00
Alexey Milovidov
0bf7a8c554 Add multiIf 2020-06-30 01:50:26 +03:00
Alexey Milovidov
6fa1204698 Fix function if with FixedString arguments of different sizes 2020-06-30 01:50:26 +03:00
alexey-milovidov
c1d2d2d7f7
Merge pull request #12039 from ClickHouse/fix-nullable-tuple-compare
Fix nullable tuple compare
2020-06-30 01:38:46 +03:00
Nikita Mikhaylov
b2712aa242 disable orc in arcadia at all 2020-06-29 23:48:18 +03:00
Anton Popov
53e955c6dd several fixes 2020-06-29 23:36:18 +03:00
Nikolai Kochetov
8587c2025d Merge branch 'master' into initial-explain 2020-06-29 23:35:56 +03:00
Nikolai Kochetov
b3a7a27779 Update arrows. 2020-06-29 23:23:34 +03:00
Azat Khuzhin
ebff4eae7d Add replica priority for load_balancing
Make default 1, to match with <weight>
2020-06-29 23:03:28 +03:00
Azat Khuzhin
03def348c8 Sync comments for <node>/<replica> in Cluster.h 2020-06-29 23:03:28 +03:00
Azat Khuzhin
177d699cde Do not check *optimize_skip_unused_shards_nesting w/o *optimize_skip_unused_shards
This will avoid supperior log message in case of
*optimize_skip_unused_shards_nesting already disables it.
And also it is logical.
2020-06-29 23:00:14 +03:00
Azat Khuzhin
9c94993f14 Fix "Sharding key is not deterministic" message 2020-06-29 23:00:14 +03:00
Nikita Mikhaylov
da26f6496f
Merge pull request #11857 from ClickHouse/better-distinct-for-query-plan
Update query plan traits for DISTINCT. Add more comments.
2020-06-29 23:06:22 +04:00
Nikita Mikhaylov
c057dd38c9
Update ITransformingStep.h 2020-06-29 22:04:10 +03:00
Nikita Mikhaylov
bfc815339f fix yandex sync 2020-06-29 20:54:35 +03:00
Nikolai Kochetov
c97d071b4b Fix test. 2020-06-29 19:28:14 +03:00
kssenii
fd9b416871 Fix and simplify code 2020-06-29 15:47:25 +00:00
Anton Popov
a43cb93be5 remove questionable functionality 2020-06-29 18:46:50 +03:00
Nikolai Kochetov
6bf9d670be Fix test. 2020-06-29 18:22:21 +03:00
alexey-milovidov
eeb9998d51
Merge pull request #12022 from oandrew/clickhouse-local-improvements
clickhouse-local improvements
2020-06-29 17:54:24 +03:00
Nikita Mikhaylov
33e627777b Merge branch 'master' of github.com:ClickHouse/ClickHouse into Avogar_orc_output_format 2020-06-29 17:25:33 +03:00
Alexander Kuzmenkov
877c10f5fa
Update ThreadProfileEvents.cpp 2020-06-29 17:13:16 +03:00
Vitaly Baranov
eb27814fbe Fix access rights: cannot grant INTROSPECTION when allow_introspection_functions=0. 2020-06-29 16:43:31 +03:00
Nikolai Kochetov
0a455fc0e1 Fix tuple nullable comparison. 2020-06-29 16:25:28 +03:00
Alexander Kuzmenkov
3223757808
Merge pull request #12019 from ClickHouse/fix-neighbor-overflow
Fix overflow in function "neighbor"
2020-06-29 16:06:05 +03:00
alesapin
718262e7ce
Merge pull request #11973 from ClickHouse/alter-enum-partition-key
Allow to perform "metadata-only" ALTER of partition key.
2020-06-29 16:01:07 +03:00
Alexander Kuzmenkov
9b9030caad
Update ThreadProfileEvents.cpp 2020-06-29 15:57:36 +03:00
Alexander Kuzmenkov
af8d62bbcb Add TLB misses perf counters. 2020-06-29 15:48:18 +03:00
kssenii
88ece429c9 Move writing to RabbitMQ into background task 2020-06-29 12:33:01 +00:00
Vitaly Baranov
f3f005d5b9
Merge pull request #12015 from vitlibar/fix-access-rights-allow-ddl-0
Fix calculation of access rights when allow_ddl = 0
2020-06-29 15:14:22 +03:00
kssenii
3d2cc9d4b2 Remove libevent library 2020-06-29 12:11:17 +00:00
tavplubix
99dfd33e71
Merge pull request #12007 from oandrew/avro-allow-missing-fields
Avro: allow_missing_fields setting
2020-06-29 14:40:27 +03:00
kssenii
5fc0b93400 Use ConcurentBoundedQueue instead of vector 2020-06-29 09:50:33 +00:00
alesapin
e72bc39654
Merge pull request #11983 from ClickHouse/storage_mongodb
Merging #10931 (Storage MongoDB)
2020-06-29 11:49:18 +03:00
Nikolai Kochetov
40b398c8c4 Merge branch 'master' into better-distinct-for-query-plan 2020-06-29 11:14:05 +03:00
hcz
0a8a29272b Add TabSeparatedRawRowInputFormat 2020-06-29 15:06:43 +08:00
alexey-milovidov
22de79846a
Merge pull request #12017 from ClickHouse/fix-integration-test-11996
Fix integration test
2020-06-29 03:39:12 +03:00
Andrew Onyshchuk
3c0ba8f9ad Limit /proc/cpuinfo metrics to linux only 2020-06-28 18:44:24 -05:00
Alexey Milovidov
4dcdad2f08 Fix ORDER BY tuple with COLLATE on const column 2020-06-28 23:55:45 +03:00
Alexey Milovidov
28c446e9a5 Whitespace 2020-06-28 23:51:14 +03:00
Alexey Milovidov
6a8659ab34 Whitespace 2020-06-28 23:49:13 +03:00
Alexey Milovidov
a838f86f7c Fix overflow in function "neighbor" 2020-06-28 23:43:26 +03:00
Alexey Milovidov
b6a57b162a Fix error in addMonths with floating point argument 2020-06-28 23:20:49 +03:00
alexey-milovidov
aaadc8addb
Merge pull request #12006 from ClickHouse/fix-error-geohash
Avoid floating point error in geohashesInBox #11369
2020-06-28 23:09:39 +03:00
Alexey Milovidov
cc597bb30b Implement for ReplicatedMergeTree 2020-06-28 22:39:31 +03:00
Alexey Milovidov
6aa89d9073 Typos 2020-06-28 22:39:31 +03:00
Alexey Milovidov
e3410ca617 Write partition key changes to ZooKeeper 2020-06-28 22:39:31 +03:00
Alexey Milovidov
e5f4a4b4b0 Whitespace 2020-06-28 22:39:31 +03:00
Alexey Milovidov
1f9c27de34 Fix clang-tidy 2020-06-28 22:39:31 +03:00
Alexey Milovidov
b6e31f0a5e Only allow Enum extension within the same width 2020-06-28 22:39:31 +03:00
Alexey Milovidov
e4d8cc2b44 Slightly more safe 2020-06-28 22:39:31 +03:00
Alexey Milovidov
97ad23b905 Allow to ALTER partition key in some cases 2020-06-28 22:39:31 +03:00
Alexey Milovidov
678d127503 Whitespace 2020-06-28 22:39:31 +03:00
Alexey Milovidov
c4d5ca485e Remove the usage of obsolete setting 2020-06-28 22:39:31 +03:00
Vitaly Baranov
bd72bd6e10 Fix access rights: cannot grant DDL when allow_ddl=0 2020-06-28 21:38:14 +03:00
kssenii
649eb8e348 Move reading from RabbitMQ into background task 2020-06-28 18:20:18 +00:00
Alexey Milovidov
306714f2d3 Merge remote-tracking branch 'origin/master' into fix-array-size-overflow-generate-random 2020-06-28 19:12:54 +03:00
Alexey Milovidov
78ee63e395 More hardening 2020-06-28 19:11:53 +03:00
Alexey Milovidov
4ec66545a3 More hardening 2020-06-28 19:07:19 +03:00
alexey-milovidov
7376f18467
Merge pull request #11923 from ucasFL/client-not-argue
client exit with unrecognized arguments
2020-06-28 17:38:25 +03:00
alexey-milovidov
86ef3e1d8c
Update ErrorCodes.cpp 2020-06-28 17:37:42 +03:00
Alexey Milovidov
d1f4a0e473 Fix array size overflow in generateRandom 2020-06-28 17:33:02 +03:00
Alexey Milovidov
305641ad3c Fix test 2020-06-28 17:31:57 +03:00
Alexey Milovidov
0a76ff118a Fix build 2020-06-28 16:18:14 +03:00
alexey-milovidov
d867dd8a65
Merge pull request #12005 from ClickHouse/fix-div-nontrivial-fpe
Fix potential FPE.
2020-06-28 16:16:26 +03:00
alexey-milovidov
935d2be826
Merge pull request #12003 from ClickHouse/fix-typos
Fix typos in code
2020-06-28 15:49:17 +03:00
Andrew Onyshchuk
9054862dde Avro: allow missing fields 2020-06-27 21:23:21 -05:00
Alexey Milovidov
c35841e4e1 Avoid floating point error in geohashesInBox #11369 2020-06-28 02:07:24 +03:00
Alexey Milovidov
ae67ea3ab3 Make it more correct 2020-06-28 01:37:46 +03:00
Alexey Milovidov
40e73b9134 Fix FPE, step 1 2020-06-28 01:32:43 +03:00
alexey-milovidov
5a99cdb0d9
Merge pull request #11996 from BohuTANG/mysql_engine_enum
ISSUES-3985 Support MySQL engine reading Enums type
2020-06-27 22:18:25 +03:00
Alexey Milovidov
1462a66d1e Fix typos 2020-06-27 22:05:00 +03:00
Nikolai Kochetov
90fb5716cf Fix build. 2020-06-27 18:30:19 +03:00
Nikolai Kochetov
ff47f83034 Refactor some code. 2020-06-27 17:18:23 +03:00
Nikolai Kochetov
5b1596cdb2 Refactor some code. 2020-06-27 17:02:24 +03:00
Alexey Milovidov
46caa211d5 Better diagnostics of "Replica {} appears to be already active" message 2020-06-27 16:55:00 +03:00
Nikita Mikhaylov
36549884f4
Merge pull request #11947 from nikitamikhaylov/merging-ssh-cache
Merging #8624 (ssd-cache)
2020-06-27 14:58:08 +04:00
Nikolai Kochetov
893a75bcf7 Merge branch 'master' into initial-explain 2020-06-27 12:45:40 +03:00
Nikolai Kochetov
f1f98d7582 More comments. 2020-06-27 12:30:37 +03:00
Nikolai Kochetov
2c02bfac75 Compact pipeline. 2020-06-27 12:32:53 +03:00
Nikolai Kochetov
f4e944cd35 Graph for pipeline. 2020-06-27 12:30:37 +03:00
Nikolai Kochetov
79bcc8309c Header for pipeline. 2020-06-27 12:31:56 +03:00
Nikolai Kochetov
5a678d74c2 Add explain pipeline. 2020-06-27 12:31:31 +03:00
Nikolai Kochetov
ca01094f4b More actions description. 2020-06-27 12:31:11 +03:00
Nikolai Kochetov
d88e19b69d Added actions setting for Explain query. 2020-06-27 12:31:06 +03:00
Nikolai Kochetov
4ed499c6f0 Fix explain formatting. 2020-06-27 12:30:37 +03:00
Nikolai Kochetov
b282a1775f Add description setting. 2020-06-27 12:30:37 +03:00
Nikolai Kochetov
8408c03aff Update explain settings. 2020-06-27 12:30:37 +03:00
Nikolai Kochetov
47d9f4af9c Header for explain. 2020-06-27 12:30:51 +03:00
Nikolai Kochetov
e1481ccfc2 Add initial explain. 2020-06-27 12:30:38 +03:00
BohuTANG
f609fd34f7 Support Enums type for MySQL engine #3985 2020-06-27 09:10:07 +08:00
Avogar
81d459a5a8 Small update ORCBlockOutputFormat and add ORC output format to performance test. 2020-06-26 23:17:28 +03:00
Alexander Kuzmenkov
58bf6f7adc
Merge pull request #11972 from ClickHouse/aku/cpu-freq
Add CPU frequencies to system.asynchronous_metrics
2020-06-26 20:45:58 +03:00
alesapin
6b3092290d Trying to fix ya.make 2020-06-26 19:33:51 +03:00
alesapin
b5f79bc28c Remove strange header 2020-06-26 19:32:15 +03:00
alesapin
6fc6422c4d Remove empty lines 2020-06-26 18:19:00 +03:00
alesapin
252706e956 Add comment 2020-06-26 17:34:37 +03:00
alesapin
4969da85d9 Fixes 2020-06-26 17:28:00 +03:00
alesapin
11f88340a5 Merge branch 'mongo' of https://github.com/ageraab/ClickHouse into storage_mongodb 2020-06-26 16:03:06 +03:00
Nikolai Kochetov
4f5be494c5
Merge pull request #11950 from 4ertus2/joins
Extract JOIN in own plan step
2020-06-26 15:52:58 +03:00
alesapin
9710a67704 Fix style check 2020-06-26 15:27:12 +03:00
Nikolai Kochetov
7c47a964cf
Update ExpressionActions.h 2020-06-26 15:24:13 +03:00
tavplubix
dfdfc69df1
Merge pull request #11900 from bharatnc/ncb/fix-file-path
fix double slashed paths in DatabaseOrdinary by switching to std::filesystem::path
2020-06-26 15:05:15 +03:00
alesapin
6caf2e7a3f Fix protocol check 2020-06-26 14:38:37 +03:00
alesapin
6f1824f0ea Correct merge with master 2020-06-26 14:30:23 +03:00
alesapin
e9c47dc89c Merge branch 'master' into CurtizJ-polymorphic-parts 2020-06-26 14:27:19 +03:00
alexey-milovidov
751d36f7c7
Merge pull request #11954 from oandrew/avro-uuid
Avro UUID support
2020-06-26 14:09:54 +03:00
Nikita Mikhaylov
f90dfa3ef4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into merging-ssh-cache 2020-06-26 13:56:21 +03:00
Anton Popov
39fe7d6c3f
Merge pull request #11729 from CurtizJ/distinct-combinator
Merging #10930. (Distinct combinator)
2020-06-26 13:40:32 +03:00
feng lv
a159f1be54 Merge branch 'master' of github.com:ClickHouse/ClickHouse into client-not-argue 2020-06-26 17:34:24 +08:00
alesapin
b3c31370c2
Merge pull request #11970 from ClickHouse/fix-estimation-of-the-number-of-marks
Fix estimation of the number of marks while reading from MergeTree
2020-06-26 11:28:36 +03:00
Alexander Kuzmenkov
808713471c
Update AsynchronousMetrics.h 2020-06-26 05:18:57 +03:00
bharatnc
76938b40a4 use std::filesystem::path 2020-06-25 18:30:44 -07:00
Artem Zuikov
54fd9ce76b fix totals 2020-06-26 03:23:11 +03:00
Alexander Kuzmenkov
d77f397b38 review fixes 2020-06-26 03:18:33 +03:00
alexey-milovidov
2163716e45
Merge pull request #11955 from ClickHouse/revive-mmap-2
Allow to use direct_io and mmap_io for secondary indices.
2020-06-26 03:16:56 +03:00
alexey-milovidov
178a5217bc
Merge pull request #11953 from ClickHouse/revive-mmap
Revive mmap IO + add a test
2020-06-26 03:15:07 +03:00
Artem Zuikov
d573005b04 place left join keys in before_join actions 2020-06-26 02:10:37 +03:00
Anton Popov
685d14863b tests with distributed 2020-06-26 01:39:54 +03:00
alexey-milovidov
8f429f6027
Merge pull request #11935 from zlobober/allocated_bytes
Consider allocatedBytes() instead of bytes() in Storage{Buffer,Memory}.
2020-06-26 00:57:47 +03:00
alexey-milovidov
6a45f3e960
Merge pull request #11936 from ClickHouse/fix_11918
Fix query parameter visitor
2020-06-26 00:54:37 +03:00
alexey-milovidov
b041479d90
Merge pull request #11949 from ClickHouse/fix-race-condition-extract-all-groups
Fix race condition in extractAllGroups
2020-06-26 00:52:29 +03:00
Artem Zuikov
9637dad462 keep ArrayJoin optimisation 2020-06-25 23:59:10 +03:00
Alexander Kuzmenkov
477fbc70f8
Update AsynchronousMetrics.cpp 2020-06-25 23:46:18 +03:00
Alexander Kuzmenkov
059a2704d0 Add CPU frequencies to system.asynchronous_metrics 2020-06-25 23:43:57 +03:00
Alexander Kuzmenkov
7ee2e68f5b better error messages 2020-06-25 23:42:31 +03:00
Alexander Kuzmenkov
a8db0b40d0 add page fault perf events 2020-06-25 23:42:31 +03:00
Artem Zuikov
2d7d389b77 better ExpressionAction::execute() 2020-06-25 23:28:41 +03:00
Alexey Milovidov
8eed47857b Fix estimation of the number of marks for various thresholds 2020-06-25 23:20:22 +03:00
Andrew Onyshchuk
9364d42eb0 Add CANNOT_PARSE_UUID extern const 2020-06-25 14:50:07 -05:00
Alexey Milovidov
875369676f Added a comment #11949 2020-06-25 22:46:43 +03:00
Alexey Milovidov
8872417d00 Respect direct_io/mmap settings while reading secondary indices 2020-06-25 22:31:54 +03:00
Artem Zuikov
bfe30a9723 remove a trick with expression continuation 2020-06-25 22:26:03 +03:00
Andrew Onyshchuk
fc1ae85600 Avro UUID support 2020-06-25 14:25:45 -05:00
Alexey Milovidov
5608f15749 Revive mmap IO 2020-06-25 22:15:41 +03:00
Artem Zuikov
0e49a9ed4d fix crash 2020-06-25 21:44:05 +03:00
Artem Zuikov
ae5ed098f4 remove useless logic 2020-06-25 21:18:27 +03:00
Artem Zuikov
801efc387a extract JOIN in own plan step 2020-06-25 20:40:25 +03:00
Alexey Milovidov
9dc43fc435 Fix race condition in extractAllGroups 2020-06-25 19:57:30 +03:00
alexey-milovidov
a34032cace
Merge pull request #11300 from blinkov/sentry
Opt-in support for sending crash reports
2020-06-25 17:20:50 +03:00
alexey-milovidov
9de5db9025
Merge pull request #11856 from zhang2014/feature/uuid_without_separator
Support parse UUID without separator
2020-06-25 16:26:55 +03:00
alexey-milovidov
40755de412
Merge pull request #11908 from ClickHouse/zookeeper-modernize
Slightly modernize code around ZooKeeper
2020-06-25 16:25:50 +03:00
alexey-milovidov
bc585c7c33
Merge pull request #11901 from BohuTANG/mysql_global_variables
Change MySQL global variables query to globalVariable function
2020-06-25 16:15:41 +03:00
Anton Popov
14e09e5650 Merge remote-tracking branch 'upstream/master' into HEAD 2020-06-25 14:59:15 +03:00
tavplubix
0260358253
Merge pull request #11934 from ClickHouse/fix_some_logical_errors
Fix some logical errors
2020-06-25 14:20:58 +03:00
alesapin
36eb2c3028 Simplify code around locks 2020-06-25 13:25:22 +03:00
Nikita Mikhaylov
1934240064 remove useless const 2020-06-25 13:22:48 +03:00
feng lv
6f3b78c774 client exit with unrecognized arguments
format code

fix
2020-06-25 18:09:35 +08:00
alesapin
d5847d29d6 Avoid memory leaks 2020-06-25 12:44:39 +03:00
alesapin
e5fc792d6b
Merge pull request #11919 from ClickHouse/fix_unitialized_memory
Fix unitialized memory
2020-06-25 12:16:00 +03:00
alesapin
78ddeff1bc
Merge pull request #11920 from vitlibar/access-check-fix-using-current-database
Fix using current database while checking access rights.
2020-06-25 11:56:15 +03:00
Alexander Kuzmenkov
5bf30b1c1f
Merge pull request #11931 from ClickHouse/aku/local-tmp
Put clickhouse-local data to /tmp by default
2020-06-25 10:06:38 +03:00
Alexander Kuzmenkov
593a0181bd
Merge pull request #11616 from ClickHouse/aku/perf-benchmark
Add concurrent benchmark to performance test
2020-06-25 09:36:52 +03:00
BohuTANG
53997f23e6 Merge remote-tracking branch 'ck/master' into mysql_global_variables 2020-06-25 14:04:10 +08:00
Alexander Tokmakov
ae9aaa006d fix query parameter visitor 2020-06-25 00:36:18 +03:00
Maxim Akhmedov
29d2928f93 Consider allocatedBytes() instead of bytes() in Storage{Buffer,Memory}. 2020-06-25 00:27:53 +03:00
alesapin
addee61bcb Trying to do everything on top of libuv, add heartbeats 2020-06-25 00:14:49 +03:00
Alexander Tokmakov
a6b7010531 fix some logical errors 2020-06-24 23:51:17 +03:00
alexey-milovidov
cd7382abf2
Merge pull request #11897 from azat/jemalloc-darwin
Fix jemalloc under OSX (by registering it as default zone explicitly)
2020-06-24 23:06:07 +03:00
alexey-milovidov
3e3ac66349
Merge pull request #11922 from bharatnc/ncb/remove-unused-headers
remove unused headers
2020-06-24 22:19:11 +03:00
Alexander Kuzmenkov
c678708c0c Put clickhouse-local data to /tmp by default
This fixes https://github.com/ClickHouse/ClickHouse/issues/9848
Also fixes https://github.com/ClickHouse/ClickHouse/issues/11926
2020-06-24 22:03:28 +03:00
Bharat Nallan
325a515e90 remove clang-format tag comments 2020-06-24 12:01:12 -07:00
Artem Zuikov
2391ac22b7
Rewrite arithmetic in aggregate functions optimisation (#11899) 2020-06-24 21:49:55 +03:00
Azat Khuzhin
236cac3d52 Fix jemalloc under OSX (by registering it as default zone explicitly)
In case of OSX jemalloc register itself as a default zone allocator.

But when you link statically then zone_register() will not be called,
and even will be optimized out:

  $ nm clickhouse.patched  | grep -c zone_register
  0

Fix this, by manually calling it.

v2: extern C
2020-06-24 21:05:35 +03:00
alesapin
cb30dbfe28 Correct merge with master 2020-06-24 20:32:57 +03:00
alesapin
3fc65b3269 Merge branch 'master' into kssenii-rabbit-mq 2020-06-24 20:14:28 +03:00
Bharat Nallan
3d23c51d6a Merge https://github.com/ClickHouse/ClickHouse into ncb/remove-unused-headers 2020-06-24 09:16:46 -07:00
alesapin
63f8f89ca0
bump CI 2020-06-24 19:06:01 +03:00
Bharat Nallan
1244ca5627 fix style check - clang format for lambdas 2020-06-24 07:34:32 -07:00
Vitaly Baranov
29a9d4187f Fix using current database while checking access rights. 2020-06-24 17:31:05 +03:00
alesapin
08f5ed6da3 Fix unitialized memory 2020-06-24 17:12:44 +03:00
Nikita Mikhaylov
e55577ba65 Merge branch 'nikvas0/ssd_dict' of git://github.com/nikvas0/ClickHouse into merging-ssh-cache 2020-06-24 16:45:18 +03:00
Nikita Mikhaylov
8bbf1ce167
fix + bump tests 2020-06-24 16:36:02 +03:00
BohuTANG
2aa92a8563 Add SELECT @@Version fake value '5.7.30' #11089 2020-06-24 21:32:33 +08:00
Alexey Milovidov
cd34cacee2 Keep alias after substitution of query parameters #11914 2020-06-24 16:14:04 +03:00
Alexander Kuzmenkov
2da7b356ab
Merge pull request #11668 from bharatnc/bnc/config-max-num-threads
max_thread_pool_size setting for changing max Threads in Global Thread Pool
2020-06-24 16:11:21 +03:00
BohuTANG
6f28d7b8b5 Fix @@session.variables AS 2020-06-24 20:09:32 +08:00
Nikolai Kochetov
f7f16fdbf7
Merge pull request #11895 from ClickHouse/fix-nullable-prewhere-type-3
Fix nullable prewhere type 3
2020-06-24 14:32:08 +03:00
Alexey Milovidov
5a7e921135 Slightly modernize code around ZooKeeper 2020-06-24 14:02:14 +03:00
BohuTANG
71f1a3120e Fix JDBC @@session.variables 2020-06-24 18:28:14 +08:00
Anton Popov
faa5d7e0f1 fix arcadia build 2020-06-24 13:01:44 +03:00
alexey-milovidov
18eb141ea1
Merge pull request #11715 from azat/dist-optimize_skip_unused_shards-fixes
Control nesting level for shards skipping and disallow non-deterministic functions
2020-06-24 12:54:58 +03:00
alexey-milovidov
c2fba5179b
Merge pull request #11875 from ClickHouse/fix-fpe-datetime64
Fix strange and wrong code around DateTime64
2020-06-24 12:54:04 +03:00
Vxider
c118f806ed Remove unused code 2020-06-24 16:56:31 +08:00
tavplubix
2401bc9143
Merge pull request #11896 from ClickHouse/merging_drop_replica
Merging #10679
2020-06-24 11:42:39 +03:00
BohuTANG
4d96a25655 Change MySQL global variables query to globalVariable function 2020-06-24 13:40:18 +08:00
bharatnc
4f10873c22 cleanup few unused headers
The following files had some unused headers and caught my eyes, so
cleaning them up:

```bash
programs/obfuscator/Obfuscator.cpp
src/Databases/DatabaseAtomic.cpp
```
2020-06-23 22:08:05 -07:00
Bharat Nallan
ea40e7b403 construct path using boost::filesystem::path 2020-06-23 18:43:36 -07:00
Bharat Nallan
6a9f3d768a clang format file 2020-06-23 18:31:25 -07:00
Bharat Nallan
ce391c84c5 remove unused imports 2020-06-23 18:11:06 -07:00
Anton Popov
8c3f496826 add test with alters and in-memory parts 2020-06-24 01:16:29 +03:00
Ivan Blinkov
3ed76a388e send build_id to sentry as well + fix some minor issues 2020-06-24 00:27:04 +03:00
Ivan Blinkov
45d1ca2567 merge master 2020-06-24 00:18:16 +03:00
Ivan Blinkov
87d56d700f restore old toStringImpl signature 2020-06-24 00:15:54 +03:00
Artem Zuikov
92016e8bfb
Fix if function with NULLs (#11807) 2020-06-24 00:06:32 +03:00
bharatnc
9be7ab0341 fix style check - removed unused LOGICAL_ERROR 2020-06-23 13:06:22 -07:00
Alexey Milovidov
cda2687195 Merge branch 'master' into fix-fpe-datetime64 2020-06-23 22:45:45 +03:00
alexey-milovidov
55eee9bfa1
Merge pull request #11745 from ClickHouse/atomic_metadata5
Atomic metadata.
2020-06-23 22:28:40 +03:00
alexey-milovidov
33dfbdcbe9
Update StorageSystemTables.cpp 2020-06-23 22:28:26 +03:00
Alexander Tokmakov
7b5de16da9 minor improvements 2020-06-23 22:15:01 +03:00
Nikolai Kochetov
658a2d0dc0 Fix anotehr one nullable prewhere column. 2020-06-23 21:52:32 +03:00
Alexey Milovidov
c51c2656eb Fix bad code 2020-06-23 20:39:30 +03:00
Alexander Kuzmenkov
f0fbba5522 allow implicit initialization 2020-06-23 20:31:46 +03:00
Alexander Kuzmenkov
1a63972a4b Merge remote-tracking branch 'origin/master' into bnc/config-max-num-threads 2020-06-23 20:25:07 +03:00