thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
98,159 Commits 9,168 Branches 1,781 Tags 2.1 GiB
021b882455
Commit Graph

98159 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Amos Bird
d2601b8192
Add a comment 2022-09-19 14:41:34 +08:00
Alexey Milovidov
e20bc9953c
Merge pull request #41481 from ClickHouse/alexey-milovidov-patch-5 
Update geo.md
 2022-09-19 09:34:24 +03:00
Alexey Milovidov
3c0961c48b
Merge branch 'master' into fix-map-combinator 2022-09-19 09:32:16 +03:00
Alexey Milovidov
b01f5bdca8
Merge pull request #39354 from ClickHouse/window-order-by 
Respect ORDER BY clause in window functions
 2022-09-19 09:22:37 +03:00
Amos Bird
09b75901f0
Fix nullptr deref 2022-09-19 14:07:31 +08:00
Alexey Milovidov
6a09340f11
Merge pull request #41459 from azat/io/threadpoolreader-elapsed 
Account any IO that is done from ThreadPoolReader
 2022-09-19 09:04:20 +03:00
Azat Khuzhin
00d4ac542d tests: fix test_hive_query flakiness 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-19 07:54:49 +02:00
Alexey Milovidov
2e5fa7880e
Update geo.md 2022-09-19 07:52:24 +03:00
Alexey Milovidov
81e8cb4be6
Merge branch 'master' into fix-bug-orc 2022-09-19 06:38:17 +03:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5 
Remove trash from Field
 2022-09-19 06:36:48 +03:00
Alexey Milovidov
57a1f47972
Merge pull request #41441 from ClickHouse/pod-array-overflow 
Fix overflow in `PODArray`
 2022-09-19 06:34:21 +03:00
Alexey Milovidov
ce130d0dc0
Merge pull request #41462 from ClickHouse/kerberos-remove-noise 
Remove noise from the build process
 2022-09-19 06:32:46 +03:00
Alexey Milovidov
4719ed6f2c
Merge pull request #41466 from ClickHouse/add_missed_throw 
Add missed throw expression
 2022-09-19 06:31:29 +03:00
Alexey Milovidov
ac193facde
Merge branch 'master' into add_missed_throw 2022-09-19 06:31:12 +03:00
Alexey Milovidov
51a847af11
Merge pull request #41469 from azat/build/tidy-fix 
Fix clang-tidy build
 2022-09-19 06:29:42 +03:00
Alexey Milovidov
036e882097
Merge pull request #41460 from ClickHouse/add-test-31631 
Add a test for #31631
 2022-09-19 06:28:56 +03:00
Alexey Milovidov
df52df83f9
Merge pull request #41463 from ClickHouse/add-test-38383 
Add a test for #38383
 2022-09-19 06:27:38 +03:00
Alexey Milovidov
790cb730d6 Fix clang-tidy 2022-09-19 00:34:41 +02:00
Alexey Milovidov
cc28120761 Merge branch 'master' into pod-array-overflow 2022-09-19 00:34:38 +02:00
Alexey Milovidov
f3fd5ef845 Fix clang-tidy 2022-09-19 00:32:52 +02:00
Alexey Milovidov
36aaeecc2f Fix clang-tidy 2022-09-19 00:32:11 +02:00
Alexey Milovidov
041d2f7dee Fix clang-tidy 2022-09-19 00:31:37 +02:00
Alexey Milovidov
f78d028177 Fix clang-tidy 2022-09-19 00:31:02 +02:00
Alexey Milovidov
5d9e125c71 Fix clang-tidy 2022-09-19 00:28:32 +02:00
Igor Nikonov
e888859396 Fix: correct sort description for ReadFromMergeTree with read in order 
optimization
 2022-09-18 22:21:13 +00:00
Azat Khuzhin
2141665c68 Fix clang-tidy build 
Tidy report [1]:

    src/AggregateFunctions/CMakeFiles/clickhouse_aggregate_functions.dir/AggregateFunctionCategoricalInformationValue.cpp.o -c ../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:38:15: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        Counter & counter(AggregateDataPtr __restrict place, size_t i, bool what) const
                  ^                                                               ~~~~~
        static
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:43:21: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        const Counter & counter(ConstAggregateDataPtr __restrict place, size_t i, bool what) const
                        ^                                                                    ~~~~~
        static
    178520 warnings generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/41459/64b44be513607d59e4b89dd9fb518b8cf4acba21/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 22:04:12 +02:00
alesapin
e4c120742e Add missed throw expression 2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch 
Fix redundant fetch in zero copy replication
 2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert 
One more validation for broken config in keeper
 2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes 
Don't output totals/extremes in all row formats, update docs
 2022-09-18 14:55:07 +02:00
Kseniia Sumarokova
d6748b182f
Update CachedOnDiskWriteBufferFromFile.cpp 2022-09-18 14:48:24 +02:00
Vitaly Baranov
e7e51ab2d9 Add comments. 2022-09-18 12:44:05 +02:00
Vitaly Baranov
69996c960c Add retries for the initialization of ReplicatedAccessStorage. 2022-09-18 12:44:05 +02:00
Vitaly Baranov
5365b105cc Add SYSTEM RELOAD USERS command. 2022-09-18 12:44:00 +02:00
Vitaly Baranov
1b40f94c6b Move common code from MemoryAccessStorage and DiskAccessStorage to IAccessStorage. 2022-09-18 12:17:15 +02:00
Alexey Milovidov
56fd38de44 Add a test for #38383 2022-09-18 10:38:10 +02:00
Alexey Milovidov
3eb7ee8308 Remove noise from build process 2022-09-18 10:35:25 +02:00
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader 
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 10:05:21 +02:00
Alexey Milovidov
4f75d818e8 Add a test for #31631 2022-09-18 09:56:29 +02:00
Alexey Milovidov
ca7b4a8737 Merge branch 'fix-trash-schema-inference' into pod-array-overflow 2022-09-18 09:26:05 +02:00
Alexey Milovidov
7e6da853cd Merge branch 'master' into pod-array-overflow 2022-09-18 09:24:23 +02:00
Alexey Milovidov
a6e3ab5515 Fix error 2022-09-18 09:21:57 +02:00
Alexey Milovidov
5c75a7d661 Fix error 2022-09-18 09:20:48 +02:00
Alexey Milovidov
c41e37fa8e Code simplification 2022-09-18 08:58:32 +02:00
Alexey Milovidov
3c43d6516b Fix style 2022-09-18 08:56:52 +02:00
Alexey Milovidov
bafc5f24c7 Merge branch 'master' into remove-trash-5 2022-09-18 08:56:02 +02:00
Alexey Milovidov
7e0f617910 Fix tests 2022-09-18 08:54:48 +02:00
Alexey Milovidov
12e950ae95 Fix tests 2022-09-18 08:49:48 +02:00
Alexey Milovidov
1d279ad6b6 Fix tests 2022-09-18 08:47:55 +02:00
Alexey Milovidov
76aaecf1aa
Merge pull request #41450 from ClickHouse/remove-s3-sample-block-cache 
Remove too long test from the test suite with S3
 2022-09-18 09:44:07 +03:00