Commit Graph

134862 Commits

Author SHA1 Message Date
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Alexey Milovidov
b9d3ae3b0a
Merge pull request #58195 from Unalian/feat-58127
Add InitialQuery event
2024-02-13 23:51:03 +01:00
jsc0218
84e8755aae rename a setting 2024-02-13 19:27:29 +00:00
Nikolai Kochetov
68f72de6f0
Merge pull request #59928 from kitaisreal/uniq-exact-set-read-crash-fix
UniqExactSet read crash fix
2024-02-13 19:45:52 +01:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Dmitry Novik
30ef68d78f Analyzer: Fix test_mutations_with_merge_tree 2024-02-13 18:59:23 +01:00
Nikolai Kochetov
d697c12a44 Fixing build. 2024-02-13 17:57:35 +00:00
Nikolai Kochetov
72bcadb7d5 Trying to fix settings change 2024-02-13 17:37:25 +00:00
Kruglov Pavel
48a3b8e675
Merge pull request #58292 from ucasfl/negtive-position
Resubmit: Support negtive position arguments
2024-02-13 18:35:28 +01:00
Nikolai Kochetov
c2ad7693db Review fixes. 2024-02-13 17:32:24 +00:00
Dmitry Novik
262e8af909 Analyzer: Fix test_user_defined_object_persistence 2024-02-13 17:37:20 +01:00
Kruglov Pavel
42628fdd38
Merge branch 'master' into #31363_format_template_configure_in_settings 2024-02-13 17:24:54 +01:00
Kruglov Pavel
39f091bffb
Merge pull request #59487 from azat/dist/fix-uncaught-exception
Fix possible uncaught exception during distributed query cancellation
2024-02-13 17:22:09 +01:00
Nikolai Kochetov
476bec4baf Fixing tests. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
134837d6fb Fixing tests. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
431aee4de3 Rename back. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
253abd1643 Refactor Squashing for inserts. 2024-02-13 16:16:53 +00:00
Dmitry Novik
45d359cb93
Use version with execution names 2024-02-13 16:33:54 +01:00
Antonio Andelic
2389cd5e61 Fix style 2024-02-13 16:27:29 +01:00
Antonio Andelic
0d151e3f0d Send only specific events/metrics for Keeper prometheus 2024-02-13 16:01:50 +01:00
Alexander Gololobov
037bc043e6 Removed lambdas 2024-02-13 16:01:17 +01:00
Maksim Kita
4dc6ed3a39 Register StorageMergeTree exception message fix 2024-02-13 17:53:35 +03:00
Smita Kulkarni
8f71d7817c Fix clang build 2024-02-13 14:57:45 +01:00
Smita Kulkarni
d7056d642d Addressed review comments 2024-02-13 13:53:40 +01:00
Maksim Kita
4577975923 Fixed code review issues 2024-02-13 15:41:17 +03:00
Maksim Kita
2caf3f0fbb Fixed tests 2024-02-13 15:41:17 +03:00
Maksim Kita
bfa7938df9 Fixed tests 2024-02-13 15:41:17 +03:00
Maksim Kita
a359ceecb5 ASOF JOIN use trySort with RadixSort 2024-02-13 15:41:17 +03:00
Kseniia Sumarokova
daf1ca0625
Merge pull request #59370 from valbok/attach-db-tests
MaterializedMySQL: Fix gtid_after_attach_test to retry on detach
2024-02-13 13:27:29 +01:00
Smita Kulkarni
3526d7982c Merge branch 'master' into Support_parameterized_view_with_analyzer 2024-02-13 13:08:35 +01:00
Pablo Marcos
a4562ea013
Fix description for allow_prefetched_read_pool_for_local_filesystem
allow_prefetched_read_pool_for_local_filesystem wrongly used the same description as allow_prefetched_read_pool_for_remote_filesystem
2024-02-13 12:56:32 +01:00
alesapin
f48c5973cc
Merge pull request #59901 from ClickHouse/fix-partition-expression-parsing-with-parens
Fix parsing of partition expressions surrounded by parens
2024-02-13 12:52:24 +01:00
Nikolai Kochetov
5daab7a862 Fixing test. 2024-02-13 11:37:40 +00:00
Maksim Kita
ddf0f22819 UniqExactSet read crash fix 2024-02-13 14:36:46 +03:00
Kseniia Sumarokova
bb12fb45c4
Merge pull request #59873 from azat/file-log-shutdown-fix
Fix long shutdown of FileLog storage
2024-02-13 12:08:12 +01:00
Nikita Mikhaylov
4b85f6b39a
Revert "Less error prone interface of read buffers" (#59911) 2024-02-13 12:02:46 +01:00
Nikolai Kochetov
86bb67812f
Merge pull request #59907 from ClickHouse/fix-index-hint-tests-with-analyzer
Update tests with indexHint for analyzer.
2024-02-13 11:18:42 +01:00
Nikolai Kochetov
666b3d6664
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-13 11:11:03 +01:00
avogar
743f2410c1 Fix crash in JSONColumnsWithMetadata format over http 2024-02-13 09:54:36 +00:00
Azat Khuzhin
7c01705231 Run ValidationChecker for sanitizers build as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 10:50:45 +01:00
Dmitry Novik
06f089c480
Analyzer: Update broken integration tests list 2024-02-13 10:49:04 +01:00
Azat Khuzhin
f3f7f5ca31 tests: fix 02981_vertical_merges_memory_usage flakiness
Note, that I've checked this change by reverting #59340, i.e.

    diff --git a/src/Processors/Transforms/ColumnGathererTransform.h b/src/Processors/Transforms/ColumnGathererTransform.h
    index 4e56cffa46a..dd3c555f361 100644
    --- a/src/Processors/Transforms/ColumnGathererTransform.h
    +++ b/src/Processors/Transforms/ColumnGathererTransform.h
    @@ -195,7 +195,7 @@ void ColumnGathererStream::gather(Column & column_res)
             }

             source.pos += len;
    -    } while (column_res.size() < block_preferred_size_rows && column_res.byteSize() < block_preferred_size_bytes);
    +    } while (true);
     }

     }

And it fails:

    02981_vertical_merges_memory_usage:                                     [ FAIL ] - result differs with reference:
    --- /src/ch/clickhouse/tests/queries/0_stateless/02981_vertical_merges_memory_usage.reference   2024-02-13 10:37:54.771393874 +0100
    +++ /src/ch/clickhouse/tests/queries/0_stateless/02981_vertical_merges_memory_usage.stdout      2024-02-13 10:41:06.781109565 +0100
    @@ -1 +1 @@
    -Vertical       OK
    +Vertical       FAIL: memory usage: 626.59 MiB

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 10:42:26 +01:00
Dmitry Novik
21770b9d17
Bump server version 2024-02-13 10:39:45 +01:00
xuzifu666
12599c4b8e Commands node args should add rvalue to push_back 2024-02-13 17:35:55 +08:00
vdimir
f438d35dad
Merge pull request #59892 from ClickHouse/vdimir/02988_join_using_prewhere_pushdown
Add test 02988_join_using_prewhere_pushdown
2024-02-13 09:59:15 +01:00
Dmitry Novik
d5fd7402f8 Merge remote-tracking branch 'origin/master' into analyzer-fix-test_wrong_db_or_table_name 2024-02-13 08:52:42 +00:00
Azat Khuzhin
f62405b234 tests: suppress http retriable errors in 00157_cache_dictionary
CI reports [1]:

    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:01.596769 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin` failed at try 1/10 with bytes read: 311149/378695. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>NSG3VKK6GWDFXMFJ</RequestId><HostId>9WhFfHfE6XtL2+InOZMJWv5ZCUY25Z3P+2EjoMx3I7UxACzLzFSHOUTT4v3EJ+ZTSAklw6Ech7E=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:02.527290 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/RefererCategories.size0.bin` failed at try 1/10 with bytes read: 1110527/1246029. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/RefererCategories.size0.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>GRRAYKKM9E73JG6A</RequestId><HostId>Ej/aHS4E6GujLjeZugLqgRhpQYLQrZtn4ZwTTz01Z0J3DJmbGQ5Ch6qzXB0NeNLmsSP6BeTy3O8=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:04.415182 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/SearchPhrase.bin` failed at try 1/10 with bytes read: 1615554/1843636. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/SearchPhrase.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>WP6PWQCNPK22CH2S</RequestId><HostId>gwYgmcnihSvFDXK3mhDfmXpDIebs39EJGCNcsghxwqqWIkvgsWOu5rSqv837589yB7Mmf+2qTcM=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:06.228120 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/HistoryLength.bin` failed at try 1/10 with bytes read: 373045/430913. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/HistoryLength.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>
    2024-02-12 21:25:24 <Error><Code>InternalError</Code><Message>We encountered an internal error. Please try again.</Message><RequestId>YMA18Y2A0Z9GKD1H</RequestId><HostId>RzI1ju46ixNRgjffHJNW8fndeSAARUKjyYh1T8a73ehCuyWqES/HpsEQNsc728dUL10cI0A6viU=</HostId></Error>. (Current backoff wait is 100/10000 ms)
    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:07.742813 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/OpenstatCampaignID.bin` failed at try 1/10 with bytes read: 16494/20267. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/OpenstatCampaignID.bin. HTTP status code: 500 Internal Server Error, body: <?

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59895/c7c05c9881362079fa6a02430fc5cd63dfa65bb7/stateful_tests__debug_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:34:17 +01:00
Azat Khuzhin
4228eaf44a Decrease logging level for http retriable errors to Warning
Messages like this:

    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:01.596769 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin` failed at try 1/10 with bytes read: 311149/378695. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:31:28 +01:00
Azat Khuzhin
58e5d7876b Allow uuid in replica_path if CREATE TABLE explicitly has it
Right now the query with {uuid} macro without ON CLUSTER fails:

    CREATE TABLE x UUID 'aaaaaaaa-1111-2222-3333-aaaaaaaaaaaa' (key Int) ENGINE = ReplicatedMergeTree('/tables/{database}/{uuid}', 'r1') ORDER BY tuple();

There is a workaround right now to use ATTACH instead of CREATE, but
ATTACH is not CREATE.

CREATE still useful for proper RESTORE without ON CLUSTER.

So this patch allows this syntax, but only if UUID had been explicitly
passed in the query. This looks safe.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:01:09 +01:00
Alexey Milovidov
025d82f47e
Merge pull request #59906 from ClickHouse/fix-selfextracting-mac
Fix self-extracting: macOS doesn't allow to run renamed executable - copy instead
2024-02-13 04:36:02 +01:00