Commit Graph

141 Commits

Author SHA1 Message Date
Azat Khuzhin
6d8706e692
clickhouse-client: fix --help without tty
stdin_is_not_tty is detected too late when the --help message is
printed, so fix this and do not call ioctl if stdin is not tty.

Before this patch:
  $ clickhouse-client --help < /dev/null

debug build:
  $ dbms/programs/clickhouse-client --help < /dev/null
  Main options:
    --help
  clickhouse-client: ../contrib/boost/libs/program_options/src/options_description.cpp:542:
  void boost::program_options::{anonymous}::format_description(std::ostream&, const string&, unsigned int, unsigned int): Assertion `line_length > first_column_width' failed.
  Aborted (core dumped)

release build:
  $ dbms/programs/clickhouse-client --help < /dev/null
  .... print lots of empty lines and so forth ...

v2: add a test and bsdutils into image for tests
v3: adjust minimal cols to the length of one of the longest arguments,
since with line_length=3 boost will bail anyway (under script(1)
ioctl(TIOCGWINSZ) returnes ws_col=0)
2019-03-23 02:01:32 +03:00
Alexey Zatelepin
304c67da99 Merge branch 'master' into fix-add-materialized-column-after
Conflicts:
	dbms/src/Interpreters/InterpreterCreateQuery.cpp
	dbms/src/Interpreters/InterpreterDescribeQuery.cpp
	dbms/src/Interpreters/interpretSubquery.cpp
	dbms/src/Storages/ColumnsDescription.cpp
2019-03-17 00:46:53 +03:00
Alexey Zatelepin
b5a0a3fa23 store all kinds of columns in the same list in ColumnsDescription [#CLICKHOUSE-3101] 2019-03-15 19:37:52 +03:00
Ivan Lezhankin
61c24e0844 Overload template method |as<>()| with reference type.
Move promotion logic to a separate class
2019-03-15 16:12:11 +03:00
Ivan Lezhankin
67eefa7b12 Revert wrong replacements of dynamic_cast.
dynamic_cast to intermediate type is not equivalent to typeid_cast
2019-03-12 15:41:57 +03:00
Ivan Lezhankin
d1ead22073 Rename As<…> → as<…> 2019-03-11 16:22:51 +03:00
Ivan Lezhankin
a7e838e328 Replace all other casts to method IAST::As<Derived>
Also remove some redundant methods like IsIdentifier() et. al.
2019-03-11 15:49:39 +03:00
Ivan Lezhankin
0e325c7a4a Replace const typeid_casts with As<Derived>() method invocations 2019-03-08 12:48:20 +03:00
proller
d2e18d47fb
Fix link in split mode (#4574) 2019-03-04 20:47:31 +03:00
Vitaly Baranov
76aae5f5d0 Add support for settings 'format_schema' in a "INSERT INTO table FORMAT" query. 2019-02-20 05:32:29 +03:00
alexey-milovidov
81a184c47f
Merge pull request #4301 from yandex/input-data-in-perf-test
Fix perf-test input data and refactor two tests
2019-02-11 12:52:03 +03:00
alexey-milovidov
4f2b35cb10
Merge pull request #4215 from abyss7/CLICKHOUSE-3729
Report progress from server-side to keep client connections alive
2019-02-11 02:07:57 +03:00
Alexey Milovidov
a1754f76b5 Added one more keyword for command line completions #4328 2019-02-10 23:30:28 +03:00
Alexey Milovidov
5b97abe693 Fixed use after free in clickhouse-client (suggestion thread) 2019-02-08 21:15:54 +03:00
alesapin
0a4c99efe4 More effective 2019-02-07 19:09:06 +03:00
alesapin
15488a21eb Really process single query instead of preparsed multiquery 2019-02-07 19:03:02 +03:00
Ivan Lezhankin
92769a2460 Don't update "arrow" on client-side for nothing 2019-02-07 16:47:16 +03:00
Ivan Lezhankin
8c640f54f8 Fix clang-7 warnings 2019-02-05 13:19:34 +03:00
Ivan Lezhankin
994926e568 Merge remote-tracking branch 'upstream/master' into CLICKHOUSE-3729 2019-02-04 20:13:50 +03:00
alexey-milovidov
450c575c7e
Merge pull request #4230 from bsd-conqueror/missing_password_value
Fixed the issue when --password was used without a value
2019-02-02 20:53:15 +03:00
alexey-milovidov
fb297b78ba
Update ConnectionParameters.h 2019-02-02 20:52:57 +03:00
alexey-milovidov
69c18786cb
Update Client.cpp 2019-02-02 20:50:57 +03:00
Sergei Semin
adfc3bf5b3 fix typo 2019-02-02 17:43:36 +03:00
Sergei Semin
3f92350c2b rename config file parameter name 2019-02-02 17:40:29 +03:00
BSD_Conqueror
fbb3fee9af Fixed a mistype 2019-02-02 17:35:51 +03:00
Sergei Semin
f3bbb07337 remove extra brackets 2019-02-02 17:29:54 +03:00
Sergei Semin
21cc1f6488 add another option for client configuration file 2019-02-02 17:28:37 +03:00
Sergei Semin
c7b52af1f8 Revert "treat "-C" as "-c" parameter for clickhouse-client"
This reverts commit 6ed2a4d4
2019-02-02 17:01:10 +03:00
Sergei Semin
959952114c move client creation and run under try to show exception message 2019-02-02 16:49:24 +03:00
BSD_Conqueror
5a7e4c863d Added a comment to explain why '\n' is used as the implicit value for the --password option 2019-02-02 16:43:08 +03:00
BSD_Conqueror
171f54a1f6 Merge branch 'missing_password_value' of https://github.com/bsd-conqueror/ClickHouse into missing_password_value 2019-02-02 16:21:55 +03:00
BSD_Conqueror
d2d11d4e96 Removed code duplication in --password handling 2019-02-02 16:20:51 +03:00
BSD_Conqueror
375be7b881
Merge branch 'master' into missing_password_value 2019-02-02 16:10:38 +03:00
BSD_Conqueror
c0f72d18d0 Fixed the issues with the --password option and the user name in the prompt
- if --password was used without any value, ask for the password in the prompt
- fixed the issue when a blank user name is shown in the prompt if no user was provided
2019-02-02 16:04:08 +03:00
Sergei Semin
6ed2a4d47d treat "-C" as "-c" parameter for clickhouse-client 2019-02-02 15:36:04 +03:00
BSD_Conqueror
baa504f524 Fixed the issue when --password was used without a value 2019-02-02 14:48:06 +03:00
Alexey Milovidov
7f8ac2d26b Fixed bad function name 2019-02-02 03:25:12 +03:00
Ivan
e22a271034
Fix style 2019-02-01 17:22:27 +03:00
proller
5d4c1d9a88 Install fixes 2019-01-28 19:36:39 +03:00
proller
22549cc43b Merge remote-tracking branch 'upstream/master' into fix10 2019-01-28 15:44:25 +03:00
Vitaly Baranov
e9721c9548 Add support for absolute format schema paths. 2019-01-27 12:15:32 +03:00
Alexander GQ Gerasiov
aac21c5f57 Fix install of binaries when SPLIT_BINARIES is set. 2019-01-25 23:19:45 +03:00
Alexey Milovidov
854817c232 Fixed -Wshadow-field #4005 2019-01-24 22:37:32 +03:00
alexey-milovidov
f96b8e4ed6
Merge pull request #4005 from vitlibar/add-protobuf-output-format
Add protobuf output format
2019-01-24 22:05:23 +03:00
Vitaly Baranov
b7ee466cd7 Added possibility to set 'format_schema_path' parameter in the client config too. 2019-01-24 17:32:01 +03:00
Vitaly Baranov
67fca7e029 Add support for settings 'format_schema' in an output query.
This fixes syntax error when executing 'SELECT ... FORMAT ... SETTINGS format_schema=...'
2019-01-23 22:23:37 +03:00
maiha
6c83beafdd dbms: Fixed misspells in comments 2019-01-23 04:56:53 +09:00
Alexey Milovidov
2eb7b15273 Addition to prev. revision #4103 2019-01-21 19:14:26 +03:00
Alexey Milovidov
c7b95b5175 Miscellaneous changes for PVS-Studio 2019-01-20 02:27:52 +03:00
proller
7cefef6983
Fix linking in all modes (unbundled, split, ...) (#4037) 2019-01-11 19:52:46 +03:00