Commit Graph

127033 Commits

Author SHA1 Message Date
Raúl Marín
dd640cba72 Provide a better message for common MV pitfalls 2023-10-19 13:21:57 +02:00
Mikhail f. Shiryaev
170925cb3c
Merge pull request #55793 from ClickHouse/improve-enrich-image
Improve enrich image
2023-10-19 12:31:32 +02:00
Azat Khuzhin
d5c960ceb6 Fix data race in CreatingSetsTransform
The problem is that findOrPromiseToBuild() can also call
shared_future::get():

    (lldb) bt 10
    * thread 194, name = 'MergeMutate', stop reason = step over
      * frame 0: 0x0000564126046bd2 clickhouse`std::rethrow_exception(p=(__ptr_ = 0x00007b5000130c80)) at exception_pointer_cxxabi.ipp:68:39
        frame 1: 0x000056411c4c5ddd clickhouse`std::__1::__assoc_state<std::__1::shared_ptr<DB::Set>>::copy(this=<unavailable>) at future:701:9
        frame 2: 0x000056411c4c0e3f clickhouse`DB::PreparedSetsCache::findOrPromiseToBuild(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&) [inlined] std::__1::shared_future<std::__1::shared_ptr<DB::Set>>::get[abi:v15000](this=0x00007b0c00154eb8) const at future:2243:46
        frame 3: 0x000056411c4c0e2e clickhouse`DB::PreparedSetsCache::findOrPromiseToBuild(this=0x00007b1c00077018, key="__set_10438532338982543705_15680061365857338647") at PreparedSets.cpp:349:116

Note, that my test did not find the problem because of #55261 had not
been merged yet.

Follow-up for: #55338
Fixes: #55279
v2: s/createDeprecated/createRuntime/

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-19 12:26:02 +02:00
Raúl Marín
297eda83fc Attemp to fix test_dictionaries_redis flakiness 2023-10-19 11:59:13 +02:00
Mikhail f. Shiryaev
d8b899d22b
Use a proper tag from default.checks for enriched images 2023-10-19 11:35:35 +02:00
Mikhail f. Shiryaev
d957d60a52
Use publicly available play.clickhouse.com to search built images 2023-10-19 11:35:10 +02:00
Robert Schulze
f18622b48b
Bump gRPC to 1v.36.4 2023-10-19 09:12:14 +00:00
Antonio Andelic
111c658385
Merge pull request #55718 from aalexfvk/use_pool_for_proxified_s3_sessions
Use pool for proxied S3 disk http sessions
2023-10-19 09:22:13 +02:00
Aleksandr Musorin
9a155ba747 Added test to check CapnProto cache
Since current getting schema for CapnProto doesn't use cache, the
integration test was for the future if someone add cache.

Also, I was curious how schema cache affects performance and I compared reading binary files
with Protobuf (I guess it works the same for CapnProto).

```
for i in {1..1000}; do clickhouse-client -q \
  "select * from test.simple format Protobuf settings format_schema='/format_schemas/simple:KeyValuePair'" > simple-protobuf${i}.bin; done

clickhouse-client --time -q "select * from file('simple-protobuf{1..999}.bin', 'Protobuf') format Null settings format_schema = 'simple:KeyValuePair'"
```

Protobuf with cache and without works with approximately the same
time.
2023-10-19 09:00:39 +02:00
Duc Canh Le
d8f73e7240 Merge branch 'master' into rocks_db_serialization
Fix a mysterious style check fail
2023-10-19 06:26:16 +00:00
Michael Kolupaev
70711b0898
Remove temporary debug logging in MultiplexedConnections (#55764) 2023-10-18 23:05:03 -07:00
Alexey Milovidov
7cd10e1c4b
Merge pull request #55780 from ClickHouse/correct-grep-fuzzer
Correctly grep fuzzer.log
2023-10-19 05:50:38 +02:00
Alexey Milovidov
cf418f8230
Merge pull request #55791 from Algunenano/enable_test_mutation_simple
Enable test_mutation_simple with the analyzer
2023-10-19 05:50:00 +02:00
Sema Checherinda
1308f26ccc Update test.py 2023-10-19 01:34:36 +02:00
Mikhail f. Shiryaev
48a9056b4e
Merge pull request #54857 from ClickHouse/speedup-images-enrich
Use `--filter` to reduce checkout time
2023-10-18 23:31:26 +02:00
Robert Schulze
8b1e7a1ea1
Merge pull request #55771 from zhongyuankai/only_cache_initial_query
Query Cache: Only cache initial query
2023-10-18 22:55:52 +02:00
Kseniia Sumarokova
4e0122a299
Merge pull request #54422 from kssenii/s3-queue-fixes
Fixes for storage `S3Queue`
2023-10-18 21:51:51 +02:00
Kseniia Sumarokova
998e068d73
Merge pull request #55774 from kssenii/fix-mat-pg-test
Fix test test_postgresql_replica_database_engine_2/test.py::test_replica_consumer
2023-10-18 21:49:29 +02:00
Igor Nikonov
9087572204
Merge pull request #55781 from ClickHouse/pr-cleanup-annoucement-less-copying
Parallel replicas: cleanup, less copying during announcement
2023-10-18 20:41:18 +02:00
Mikhail f. Shiryaev
224edf26fe
Merge branch 'master' into speedup-images-enrich 2023-10-18 19:05:28 +02:00
Mikhail f. Shiryaev
8935c6ce5d
Merge pull request #55717 from ClickHouse/tune-dockerfiles
Improve Dockerfiles for keeper and server images
2023-10-18 19:04:27 +02:00
Raúl Marín
6f349038bb Enable test_mutation_simple with the analyzer 2023-10-18 17:24:41 +02:00
Antonio Andelic
482a484a9c
Merge pull request #55766 from ClickHouse/keeper-feature-flag-random-env
Control Keeper feature flag randomization with env
2023-10-18 17:19:38 +02:00
zhongyuankai
d73afed7d5 fix style 2023-10-18 23:09:38 +08:00
Sema Checherinda
dfdd2ee77c fix tests, to avoid timeouts do less retries 2023-10-18 16:36:45 +02:00
Kseniia Sumarokova
e4e92913cf
Merge pull request #55261 from azat/tests/fix-integration-results-parser
Do not allow tests with state ERROR be overwritten by PASSED
2023-10-18 16:13:19 +02:00
kssenii
f90e31eb31 Enable log by default 2023-10-18 15:23:16 +02:00
Yakov Olkhovskiy
a517c49d59
Merge pull request #55756 from ClibMouse/max_intersection_fix
Big endian platform max intersection fix
2023-10-18 09:13:03 -04:00
monchickey
3ef092f83f
Fix the compilation error that occurs when opening avx series instructions (#55049)
* fix the compilation error that occurs when opening avx series instructions

cmake command example:
```shell
cmake .. -DCMAKE_BUILD_TYPE=Release -DENABLE_AVX=ON -DENABLE_AVX2=ON -DENABLE_AVX2_FOR_SPEC_OP=ON
```

* Update snappy CMakeLists.txt add SNAPPY_HAVE_X86_CRC32 parameter
2023-10-18 15:04:27 +02:00
Igor Nikonov
38895ad2da Less copying in DefaultCoordinator 2023-10-18 12:59:12 +00:00
Sinan
c7f78ac73a
Add aggregation function for Largest-Triangle-Three-Buckets (#53145)
* Added a simple lttb aggregate function

* Added support for multiple datatypes

* Added support for Date and Date32, updated LTTBData struct

* Updated code to handle bucket size 0 and 1

* Added sort for LTTBData

* Added tests and documentation

* Added some code style fixes

* Added function to new func ref file

* Removed function from new func ref file

* Apply suggestions from code review

* Updated unit tests

* updated LTTB data code

* Minor style fixes

* Updated code with std sort

* updated tests

* Renamed lttb to largestTriangleThreeBuckets

* Added alias lttb

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2023-10-18 14:47:18 +02:00
kssenii
c4bad255b7 Fix 2023-10-18 14:37:33 +02:00
Mikhail f. Shiryaev
af31224ecd
Write only filename to sha512 files for tarballs 2023-10-18 14:20:21 +02:00
Mikhail f. Shiryaev
e4e1aac154
Move comment about created user to a proper place 2023-10-18 14:20:21 +02:00
Mikhail f. Shiryaev
8b49a94713
Check sha512 sums for alpine server and keeper images 2023-10-18 14:20:20 +02:00
Igor Nikonov
01fa15c33f Less copying while handling annoucement 2023-10-18 12:20:14 +00:00
Mikhail f. Shiryaev
726c370d08
Replace temporary REPORITORY url by a proper one 2023-10-18 14:20:11 +02:00
Antonio Andelic
2eabb260a7 Correctly grep fuzzer.log 2023-10-18 12:09:22 +00:00
Kseniia Sumarokova
b09e0d2591
Merge branch 'master' into fix-mat-pg-test 2023-10-18 14:02:31 +02:00
Antonio Andelic
344c95cfdf
Merge pull request #55765 from ClickHouse/fix-undefined-behaviour-partition
Check if partition ID is `nullptr`
2023-10-18 13:49:49 +02:00
Robert Schulze
2167345c53
Merge pull request #55693 from rschu1ze/grpc-1.34.1-try-2
Bump gRPC to 1.34.1
2023-10-18 13:36:02 +02:00
avogar
be9e84c194 Fix style 2023-10-18 11:09:39 +00:00
Kseniia Sumarokova
56e62cb3fc
Merge pull request #55779 from kssenii/fix-black-check
Fix black check
2023-10-18 13:07:32 +02:00
kssenii
663c2611ee Fix 2023-10-18 13:05:29 +02:00
kssenii
33118442dd Fix black check 2023-10-18 13:01:35 +02:00
kssenii
babbdd9202 Fxi 2023-10-18 12:08:47 +02:00
Duc Canh Le
2d638d6470 rocksdb: not creating block during writing
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2023-10-18 09:43:54 +00:00
Kseniia Sumarokova
608a752490
Merge pull request #55772 from ClickHouse/kssenii-patch-6
Temporarily disable flaky test
2023-10-18 11:39:24 +02:00
Kseniia Sumarokova
fff6a8dcc8
Temporarily disable flaky test 2023-10-18 11:35:53 +02:00
Antonio Andelic
71adb434e3 Remove f-string 2023-10-18 09:19:09 +00:00