Commit Graph

31268 Commits

Author SHA1 Message Date
Roman Vasin
02e08fa301 Use another approach for timeSlot() 2022-09-29 15:44:56 +00:00
Roman Vasin
e0099d52de Use C++20 format() syntax for exceptions 2022-09-29 14:07:02 +00:00
Roman Vasin
53b34c7e0a Put enable_extended_results_for_datetime_functions into private; correct if/else braces 2022-09-29 11:04:13 +00:00
Roman Vasin
22ccce6946 Remove WithContext; Rename execute_extended_result to executeExtendedResult 2022-09-29 09:29:07 +00:00
Roman Vasin
e66e70870a Fix timezone issues 2022-09-28 16:05:59 +00:00
Roman Vasin
36274baba9 Code cleanup 2022-09-26 15:36:32 +03:00
Roman Vasin
2a92c2aae9 Fix timeSlot() for DateTime64 argument 2022-09-26 15:26:07 +03:00
Roman Vasin
348f28a3e7 Fix toStartOfFiveMinutes, toStartOfTenMinutes, toStartOfFifteenMinutes 2022-09-22 13:30:40 +00:00
Roman Vasin
cdd20241bf Finish toStartOfDay; fix toStartOfMinute 2022-09-22 13:16:46 +00:00
Roman Vasin
4ddd6f3c60 Fix timeSlot(); partial fix StartOfDay 2022-09-22 09:19:22 +00:00
Roman Vasin
49b0da0273 Add date32IsNotSupported() 2022-09-22 07:15:03 +00:00
Roman Vasin
f6ebd94ce1 Add execute_extended_result for Date32 argument 2022-09-22 07:07:04 +00:00
Roman Vasin
30c4719f7b Add FunctionDateOrDateTimeToDateTimeOrDateTime64; function toStartOfHour works 2022-09-21 12:58:57 +00:00
Antonio Andelic
1763af37b9
Merge pull request #41403 from ClickHouse/keeper-fix-shutdown-without-server
Fix Keeper segfault during shutdown when RAFT server failed to start
2022-09-19 12:03:58 +02:00
Vladimir C
b6b5932efc
Merge pull request #41223 from ClickHouse/vdimir/exponential_rewrite_21557 2022-09-19 10:07:24 +02:00
Alexey Milovidov
b9bd2c8373
Merge pull request #41458 from ClickHouse/fix-bug-orc
Fix very strange behavior of Apache ORC
2022-09-19 10:43:17 +03:00
Alexey Milovidov
b01f5bdca8
Merge pull request #39354 from ClickHouse/window-order-by
Respect ORDER BY clause in window functions
2022-09-19 09:22:37 +03:00
Alexey Milovidov
6a09340f11
Merge pull request #41459 from azat/io/threadpoolreader-elapsed
Account any IO that is done from ThreadPoolReader
2022-09-19 09:04:20 +03:00
Alexey Milovidov
81e8cb4be6
Merge branch 'master' into fix-bug-orc 2022-09-19 06:38:17 +03:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5
Remove trash from Field
2022-09-19 06:36:48 +03:00
Alexey Milovidov
57a1f47972
Merge pull request #41441 from ClickHouse/pod-array-overflow
Fix overflow in `PODArray`
2022-09-19 06:34:21 +03:00
Alexey Milovidov
ac193facde
Merge branch 'master' into add_missed_throw 2022-09-19 06:31:12 +03:00
Alexey Milovidov
df52df83f9
Merge pull request #41463 from ClickHouse/add-test-38383
Add a test for #38383
2022-09-19 06:27:38 +03:00
Alexey Milovidov
790cb730d6 Fix clang-tidy 2022-09-19 00:34:41 +02:00
Alexey Milovidov
cc28120761 Merge branch 'master' into pod-array-overflow 2022-09-19 00:34:38 +02:00
Alexey Milovidov
f3fd5ef845 Fix clang-tidy 2022-09-19 00:32:52 +02:00
Alexey Milovidov
36aaeecc2f Fix clang-tidy 2022-09-19 00:32:11 +02:00
Alexey Milovidov
5d9e125c71 Fix clang-tidy 2022-09-19 00:28:32 +02:00
alesapin
e4c120742e Add missed throw expression 2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch
Fix redundant fetch in zero copy replication
2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert
One more validation for broken config in keeper
2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes
Don't output totals/extremes in all row formats, update docs
2022-09-18 14:55:07 +02:00
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-18 10:05:21 +02:00
Alexey Milovidov
7e6da853cd Merge branch 'master' into pod-array-overflow 2022-09-18 09:24:23 +02:00
Alexey Milovidov
a6e3ab5515 Fix error 2022-09-18 09:21:57 +02:00
Alexey Milovidov
5c75a7d661 Fix error 2022-09-18 09:20:48 +02:00
Alexey Milovidov
c41e37fa8e Code simplification 2022-09-18 08:58:32 +02:00
Alexey Milovidov
3c43d6516b Fix style 2022-09-18 08:56:52 +02:00
Alexey Milovidov
bafc5f24c7 Merge branch 'master' into remove-trash-5 2022-09-18 08:56:02 +02:00
Alexey Milovidov
8764fa4439 Fix very strange behavior of Apache ORC 2022-09-18 08:25:25 +02:00
Alexey Milovidov
a958751c98
Merge pull request #40219 from den-crane/test/zvonand-monotonic
test for datetime64 monotonic #39864
2022-09-18 07:48:49 +03:00
Alexey Milovidov
32efe6952e
Merge pull request #41429 from ClickHouse/forbid-dlopen-2
Forbid invocations of `dlopen`
2022-09-18 07:05:56 +03:00
Alexey Milovidov
791de6592b Remove trash from Field 2022-09-18 05:16:08 +02:00
Alexey Milovidov
c8c728e740
Merge pull request #41449 from ClickHouse/fix-categorial-information
Fix incorrect properties of `categorialInformationValue` function
2022-09-18 05:26:26 +03:00
Alexey Milovidov
7f68f2c7df Remove trash from LowCardinality 2022-09-18 04:13:21 +02:00
Alexey Milovidov
15e5fc96a1 Add a trap 2022-09-18 02:24:56 +02:00
Alexey Milovidov
dc76677eb2
Merge pull request #41440 from ClickHouse/remove-cruft
Remove cruft about gcc
2022-09-18 03:15:26 +03:00
Alexey Milovidov
e3dafdb865 More hardening 2022-09-18 02:10:06 +02:00
Alexey Milovidov
e5e3bca3ae More hardening and tests 2022-09-18 02:05:13 +02:00
Alexey Milovidov
6c74c54cb5 Merge branch 'master' into pod-array-overflow 2022-09-18 01:24:52 +02:00