Commit Graph

8435 Commits

Author SHA1 Message Date
alexey-milovidov
0400070924
Merge pull request #23822 from excitoon-favorites/equalsignins3path
Better handling of URI's in `PocoHTTPClient`
2021-05-10 20:25:18 +03:00
alexey-milovidov
ab33b80edc
Merge pull request #23962 from azat/external-group-by-overflow-row-fix
Fix SIGSEGV for external GROUP BY and overflow row
2021-05-10 20:02:05 +03:00
Maksim Kita
742434a0cd
Merge pull request #23903 from azat/fix-flaky-tests-21.6
Fix test_insert_into_distributed flaps
2021-05-10 00:44:46 +03:00
alexey-milovidov
4ada91574b
Merge branch 'master' into fixing_testflows_window_function_distributed_tests 2021-05-09 18:29:33 +03:00
Maksim Kita
e517436ba4
Merge pull request #23961 from kitaisreal/array-difference-decimal-math-overflow
Function arrayDifference decimal math overflow
2021-05-09 14:04:35 +03:00
alexey-milovidov
a34c927fb2
Merge branch 'master' into tests_dt64_ext 2021-05-08 23:29:18 +03:00
Vitaliy Zakaznikov
b85205aa30 Enabling testflows window function tests. 2021-05-08 15:22:03 -04:00
Vitaliy Zakaznikov
b303ebc7e3 Fixing window functions distributed tests by moving to using deterministic sharding key. 2021-05-08 15:06:31 -04:00
Maksim Kita
290e1ec307 Functional stateless tests fix numbers 2021-05-08 21:13:27 +03:00
Azat Khuzhin
f1aebbe927 Check that totals correctly calculated in 01865_aggregator_overflow_row
Change aggregation function to uniqCombined() to check this.
2021-05-08 20:43:01 +03:00
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate
Measure found rate for dictionaries
2021-05-08 19:23:52 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Azat Khuzhin
bdb5dad3a3 Cover system.dictionaries.found_count
v2: fix for ANTRL
v3: add all dictionaries layouts
2021-05-08 17:09:01 +03:00
Maksim Kita
108c2022d9 Function arrayDifference decimal math overflow 2021-05-08 17:01:30 +03:00
Alexey Milovidov
b64f5b0419 Disable unreliable TestFlows 2021-05-08 16:40:54 +03:00
tavplubix
f8c7725ef5
Merge pull request #23742 from ClickHouse/update_metadata_on_replica_recovery
Update metadata on replica recovery
2021-05-08 16:34:03 +03:00
Maksim Kita
80dbb7ca4f
Merge pull request #23948 from azat/dict-range-min-max-check
Check MIN/MAX attributes in the list of dictionary attributes
2021-05-08 16:07:26 +03:00
Maksim Kita
b617c57ce8
Merge pull request #23929 from azat/dict-cache-source-dups-fix
Fix keys metrics accounting for CACHE() dictionary with duplicates in the source
2021-05-08 11:56:20 +03:00
Azat Khuzhin
8e9655d513 Check MIN/MAX attributes in the list of dictionary attributes
This way there will be proper exception instead of std::out_of_range
2021-05-08 08:59:47 +03:00
Azat Khuzhin
c1b213b96e Fix 01863_dictionary_cache_duplicates under ANTLR parser
By do not start name of table/dict from number.
2021-05-08 00:59:55 +03:00
Kseniia Sumarokova
e6ac136c32
Merge pull request #23909 from kssenii/postgres-fixes
Fix postgres connections issue
2021-05-08 00:07:21 +03:00
Vladimir Chebotarev
a39314949e
Added solution for host network mode in Ubuntu 20.10+. 2021-05-07 23:36:15 +03:00
Anton Popov
01e99ab72e
Merge pull request #23871 from CurtizJ/cast-operator
Add postgres-like cast operator
2021-05-07 16:29:22 +03:00
Anton Popov
576728829d fix perf test 2021-05-07 16:23:46 +03:00
alexey-milovidov
fd56e0a984
Merge pull request #23919 from ucasFL/hint-enum
Add hints for enum names
2021-05-07 16:12:16 +03:00
kssenii
8662078b35 Review fixes 2021-05-07 09:55:18 +00:00
alexey-milovidov
617e71b3f2
Merge pull request #23704 from vzakaznikov/testflows_window_functions_tests
TestFlows window functions tests
2021-05-07 03:57:05 +03:00
Anton Popov
efd64c6d57 add test to skip list 2021-05-07 02:52:51 +03:00
Vitaliy Zakaznikov
f067237fdd Fixing range frame tests for distributed tables. 2021-05-06 18:16:24 -04:00
Anton Popov
a8259a6158 fix perf test 2021-05-06 21:26:55 +03:00
Anton Popov
e51cd90c6f better cast operator 2021-05-06 21:21:10 +03:00
Azat Khuzhin
e7027e0529 Fix keys metrics accounting for CACHE() dictionary with duplicates in the source 2021-05-06 21:03:20 +03:00
feng lv
59f5f2d03c Add hints for enum names
add test
2021-05-06 14:22:54 +00:00
Maksim Kita
a979a86930
Merge pull request #23824 from kitaisreal/hashed-dictionary-complex-key-update-field-initial-load-fix
HashedDictionary complex key update field initial load fix
2021-05-06 17:12:04 +03:00
Vladimir Chebotarev
524113f497 Fixed bug with S3 URLs containing + symbol, data with such keys could not be read previously. 2021-05-06 11:28:55 +03:00
kssenii
8900e93bd8 New impl 2021-05-06 00:52:59 +00:00
Vitaliy Zakaznikov
bb2213fdac Updating range datetime tests for distributed tables. 2021-05-05 18:31:16 -04:00
Alexey Milovidov
d283870f3d Fix test that depends on configuration too much 2021-05-06 01:14:32 +03:00
Alexey Milovidov
8827857fc3 Fix bad test 2021-05-06 01:09:50 +03:00
Alexey Milovidov
969649c4e5 Fix bad test (tabs) 2021-05-06 01:09:50 +03:00
Vitaliy Zakaznikov
75bd55073d Fixing rows frame tests for distributed tables. 2021-05-05 18:01:12 -04:00
Maksim Kita
ae47a7ccce Integration test increase wait before dictionary update 2021-05-05 23:39:40 +03:00
Vitaliy Zakaznikov
89de7c5847 Updates to tests. 2021-05-05 15:47:32 -04:00
Vitaliy Zakaznikov
0d67461f2d Updates. 2021-05-05 15:00:08 -04:00
Vitaliy Zakaznikov
ee4296510d Updates to fix more tests with distributed tables. 2021-05-05 14:34:51 -04:00
Azat Khuzhin
a958f4178b Fix test_insert_into_distributed flaps
In [1] the order of the tests was different:

    Running pytest container as: 'docker run --net=host  --rm --name clickhouse_integration_tests --privileged         --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse-odbc-bridge:/clickhouse-odbc-bridge --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse:/clickhouse         --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse-library-bridge:/clickhouse-library-bridge --volume=/place/sandbox-data/tasks/7/4/962738347/clickhouse:/clickhouse         --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/programs/server:/clickhouse-config --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/tests/integration:/ClickHouse/tests/integration         --volume=/place/sandbox-data/tasks/7/4/962738347/ClickHouse/src/Server/grpc_protos:/ClickHouse/src/Server/grpc_protos         --volume=clickhouse_integration_tests_volume:/var/lib/docker -e DOCKER_MYSQL_GOLANG_CLIENT_TAG=latest -e DOCKER_MYSQL_JAVA_CLIENT_TAG=latest -e DOCKER_MYSQL_JS_CLIENT_TAG=latest -e DOCKER_MYSQL_PHP_CLIENT_TAG=latest -e DOCKER_POSTGRESQL_JAVA_CLIENT_TAG=latest -e DOCKER_BASE_TAG=latest -e DOCKER_KERBEROS_KDC_TAG=latest -e PYTEST_OPTS='-ss test_insert_into_distributed/test.py::test_inserts_batching test_insert_into_distributed/test.py::test_inserts_local test_insert_into_distributed/test.py::test_inserts_low_cardinality test_insert_into_distributed/test.py::test_inserts_single_replica_internal_replication test_insert_into_distributed/test.py::test_inserts_single_replica_local_internal_replication test_insert_into_distributed/test.py::test_inserts_single_replica_no_internal_replication test_insert_into_distributed/test.py::test_prefer_localhost_replica test_insert_into_distributed/test.py::test_reconnect test_insert_into_distributed/test.py::test_table_function -rfEp --color=no --durations=0 ' yandex/clickhouse-integration-tests-runner:latest '.

  [1]: https://clickhouse-test-reports.s3.yandex.net/23874/80065b08f8182936ac57408bd84492d95f2322c1/integration_tests_(asan).html#fail1

So the table should be TRUNCATEd to avoid failures in this case.
2021-05-05 21:18:43 +03:00
alexey-milovidov
542c940941
Merge pull request #23874 from filimonov/librdkafka161
Update librdkafka 1.6.0-RC3 to 1.6.1
2021-05-05 13:48:14 +03:00
alexey-milovidov
bf8c28a17f
Merge pull request #23885 from azat/dist-broken-metrics
Add metrics for broken files during async distributed sends
2021-05-05 13:41:15 +03:00
Azat Khuzhin
74269882f7 Add broken_data_files/broken_data_compressed_bytes into distribution_queue 2021-05-04 22:48:07 +03:00
Alexey Milovidov
af41344cf5 @CurtizJ convinced me that this test has to be deleted 2021-05-04 20:59:42 +03:00