Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types
2023-01-02 21:58:53 +03:00
Nikita Mikhaylov
ffaff7167b
Fix flaky tests ( #44690 )
2022-12-29 14:32:10 +01:00
Azat Khuzhin
b7f92454bf
Move LineReader/ReplxxLineReader out from base
...
This will simplify linking dependencies, and anyway this classes are not
base in any sense.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
83cad3625b
Remove unused setTerminalEcho()
...
It had been replaced with readpassphrase in #5092
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
4d17510fca
Use already written part of the query for fuzzy search (pass to skim)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-26 14:52:38 +01:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types
2022-12-21 23:56:24 -05:00
Azat Khuzhin
cf0e0436be
skim: do not panic if terminal is not available
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
082f57c40d
clickhouse-client: rebind original non-fuzzy search to C-T
...
I decided to bind fuzzy to a regular C-R, so that everyone will notice
it, and keep an old behaviour for expect tests, or if someone do not
need fuzzy search (or want blasignly fast search, since skim is slightly
slower).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
82aaad61aa
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC. But anyway
this will be resolved in a different way, but separatelly.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:41 +01:00
Azat Khuzhin
67fa185611
Revert "Builtin skim"
2022-12-14 17:17:19 +03:00
Alexey Milovidov
df17d1b71b
Merge branch 'master' into builtin-skim
2022-12-13 03:33:42 +03:00
Azat Khuzhin
9ed6aa0be1
Fix -Wshorten-64-to-32 on FreeBSD
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-12 08:05:28 +01:00
Azat Khuzhin
de58e9c02d
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:52:00 +01:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support
2022-12-09 20:21:22 -05:00
Yakov Olkhovskiy
0641066183
Merge branch 'master' into refactoring-ip-types
2022-12-08 11:12:05 -05:00
Antonio Andelic
b068119d27
Merge pull request #43498 from azat/client/improve-fuzzy-search
...
Improve fuzzy search in clickhouse-client/clickhouse-local
2022-12-08 14:07:52 +01:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support
2022-12-08 07:40:43 -05:00
Boris Kuschel
623f23f55d
OpenSSL cmake changes
2022-12-07 13:22:46 -05:00
Robert Schulze
3c1a721da4
Merge branch 'master' into hlee-s390x-wide-int-order
2022-12-04 18:47:00 +01:00
Yakov Olkhovskiy
77266ea754
cleanup
2022-11-29 17:34:16 +00:00
Yakov Olkhovskiy
b47cb522b5
revert StrongTypedef and fix test instead
2022-11-28 23:33:47 +00:00
Yakov Olkhovskiy
770b520ded
Merge branch 'master' into refactoring-ip-types
2022-11-28 08:50:19 -05:00
Robert Schulze
a00a020cfb
Merge pull request #42847 from ClibMouse/s390x_bit_cast
...
s390x datetime64 conversion fix
2022-11-28 11:45:43 +01:00
Yakov Olkhovskiy
c47f13afd5
explicit conversion for StrongTypedef
2022-11-26 03:36:01 +00:00
Azat Khuzhin
7a9adbc285
Escape shell arguments for fzf/skim
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 20:15:04 +01:00
Azat Khuzhin
59e647077d
Improve fuzzy search in clickhouse-client/clickhouse-local
...
I found few difference in sk/fzf and after this patch I think that it
should behave better.
So the following commands will be used by default:
- fzf --read0 --tac --tiebreak=index --height=30%
- sk --read0 --tac --tiebreak=-score --height=30%
Those two more or less allows true fuzzy reserve search.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:44:07 +01:00
Azat Khuzhin
14d4980e26
Fix repainting of the client prompt after fuzzy search
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:42:39 +01:00
Yakov Olkhovskiy
ac4b050644
style fix
2022-11-22 13:10:33 +00:00
Yakov Olkhovskiy
988b030bfd
bug fix, refactoring IPv6 to struct with overridden comparison
2022-11-22 12:57:19 +00:00
Suzy Wang
60119a97f7
fix build error
2022-11-17 20:38:22 -08:00
HarryLeeIBM
0133444433
Fix byte order issue of wide integer for s390x
2022-11-14 10:47:32 -08:00
Yakov Olkhovskiy
9aeebf3bdf
Merge branch 'master' into refactoring-ip-types
2022-11-14 09:21:54 -05:00
Yakov Olkhovskiy
4d144be39c
replace domain IP types (IPv4, IPv6) with native
2022-11-14 14:17:17 +00:00
Suzy Wang
f624143532
fix typo
2022-11-10 12:42:38 -08:00
Suzy Wang
84a8c02d78
Update typo and rm whitespaces
2022-11-10 12:32:40 -08:00
Raúl Marín
aaf8cc6ca8
Revert "Add global flags to base/ libraries"
...
This reverts commit 43e065c18e
.
2022-11-10 11:32:27 +01:00
Suzy Wang
73e5cd91c8
rm unnecessary include
2022-11-09 13:59:34 -08:00
Raúl Marín
39f4120655
Fix broken build
2022-11-09 13:21:59 +01:00
Raúl Marín
43e065c18e
Add global flags to base/ libraries
2022-11-09 11:24:20 +01:00
Suzy Wang
ba868801fa
Update as suggested
2022-11-08 20:51:35 -08:00
Raúl Marín
050f3ca7cf
Fix msan warning
2022-11-08 17:25:03 +01:00
Alexander Tokmakov
fc77d53db1
Merge pull request #43009 from azat/fix-tsan
...
Fix TSan errors (correctly ignore _exit interception)
2022-11-07 22:20:53 +03:00
Alexander Tokmakov
b4ecbbf224
Update safeExit.cpp
2022-11-07 21:07:09 +03:00
Azat Khuzhin
d6bfbeb95f
Fix TSan errors (correctly ignore _exit interception)
...
Because safeExit() does not includes header with defines, it does not
know about THREAD_SANITIZER.
And it also fixes Azure blob storage, actually everything is fine with
the sdk itself, the problem is only in TSan that intercepts _exit() and
report leak, even thoug that tread will be joined later.
Refs: #23056 (#23616 )
Fixes : #38474
Closes : #42640
Fixes : #42638
Fixes : #34988
Cc: @alexey-milovidov, @tavplubix
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-07 16:10:35 +01:00
Amos Bird
4c2b3de93d
Fix msan error
2022-11-04 22:08:14 +08:00
Amos Bird
a89e847514
Fix getauxval for sanitizer builds
2022-11-04 22:08:13 +08:00
Suzy Wang
9560306cdb
Update fix
2022-11-03 09:29:15 -07:00
Suzy Wang
80c4d27a89
reverse columnVector change and update new fix
2022-11-02 07:15:00 -07:00
Azat Khuzhin
4eeb7337ed
Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
...
Conflicts:
- src/Common/intExp.h
- src/Functions/DateTimeTransforms.h
- src/Functions/FunctionsConversion.h
2022-10-21 22:51:56 +02:00
Azat Khuzhin
1e739791a4
Fix type error in itoa (wrong static_cast<>)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
0625a866f0
Add a note about incorrect wide_integer with Decimal
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:43 +02:00
Azat Khuzhin
7b28a80ad7
Fix -Wshorten-64-to-32 for amd64sse2 build
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:42 +02:00
Azat Khuzhin
4e76629aaf
Fixes for -Wshorten-64-to-32
...
- lots of static_cast
- add safe_cast
- types adjustments
- config
- IStorage::read/watch
- ...
- some TODO's (to convert types in future)
P.S. That was quite a journey...
v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Alexey Milovidov
445487e073
Merge branch 'master' into add-test-658
2022-10-20 23:55:15 +02:00
Sema Checherinda
52f57cd1ee
Merge pull request #42080 from azat/client-fuzzy-history
...
Avoid adding extra new line after using fuzzy history search
2022-10-12 10:50:26 +02:00
Alexey Milovidov
8a066b5eef
Fix test
2022-10-11 01:28:36 +02:00
Alexander Tokmakov
ff03181d31
Update safeExit.cpp
2022-10-10 15:01:03 +03:00
Alexey Milovidov
69a3ddb5cb
Merge pull request #42128 from Algunenano/tsa_build
...
Fix build without TSA
2022-10-09 03:11:47 +03:00
Alexander Tokmakov
8b44e11430
fix
2022-10-08 16:10:46 +02:00
Alexander Tokmakov
4175f8cde6
abort instead of __builtin_unreachable in debug builds
2022-10-07 21:49:08 +02:00
Alexander Tokmakov
1a1a20587e
Update defines.h
2022-10-07 21:26:09 +03:00
Raúl Marín
5d9c4a39c0
Update comment
2022-10-07 14:06:28 +02:00
Raúl Marín
62599e3901
Simpler macro
2022-10-07 11:14:35 +02:00
Raúl Marín
6b0ad85640
Fix build without TSA
2022-10-06 16:26:48 +02:00
Azat Khuzhin
e9d4d15c0d
Add more comments for skim/fzf compatibility
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-05 09:59:48 +02:00
Azat Khuzhin
6e7114128b
Avoid adding extra new line after using fuzzy history search
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-05 09:59:48 +02:00
BoloniniD
55c79230b3
Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3
2022-09-29 23:53:25 +03:00
Azat Khuzhin
8cc53a48ae
clickhouse-client: tune fzf/sk options to be a real reverse search
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
d0f14e1255
clickhouse-client: proper support of vfork() w/o dlsym() in musl
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
aaa36e2b25
clickhouse-client: add support of sk (fzf-like in rust)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
58b61d8207
clickhouse-client: add interactive history search with fzf-like utility
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Azat Khuzhin
6acdeb84be
clickhouse-client: refactor editor execution
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-26 15:09:37 +03:00
Nikita Mikhaylov
e897816572
Evict stale DNS entries from cache in case of network errors ( #41707 )
2022-09-25 14:06:13 +02:00
BoloniniD
55fcb98f29
Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3
2022-09-19 21:53:14 +03:00
BoloniniD
5b4fb4bf66
Merge branch 'master' into BLAKE3
2022-09-18 23:14:37 +03:00
Alexey Milovidov
5c75a7d661
Fix error
2022-09-18 09:20:48 +02:00
Alexey Milovidov
35cce03125
Remove dlopen
2022-09-17 03:02:34 +02:00
BoloniniD
452ef4435b
Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3
2022-09-16 20:05:56 +03:00
BoloniniD
0df426d329
Corrosion fixes + review fixes
2022-09-16 00:05:21 +03:00
Azat Khuzhin
569b4bb631
Add ability to automatically comment SQL queries in clickhouse-client/local
...
This is like Alt-# in readline, it is useful when you need to look
something else, and need to save current query/command somewhere, and
commented lin the history is a good option.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-12 21:57:21 +02:00
Alexey Milovidov
2aedd41023
Remove strange code ( #40195 )
...
* Remove strange code
* Even more code removal
* Fix style
* Remove even more code
* Simplify code by making it slower
* Attempt to do something
* Attempt to do something
* Well do something with this horrible trash
* Add a test
2022-09-12 16:29:23 +02:00
Alexey Milovidov
33635e015d
Fix style
2022-09-11 06:11:02 +02:00
Alexey Milovidov
fa62c7e982
Fix half of trash
2022-09-10 04:08:16 +02:00
BoloniniD
e8bcbcd016
Merge branch 'master' into BLAKE3
2022-09-09 11:48:31 +03:00
BoloniniD
c08b41b611
Clean files and compatibility code
2022-09-08 09:34:59 +03:00
BoloniniD
069fbdd7c5
Fix broken builds
2022-09-05 20:56:03 +03:00
BoloniniD
69588bcebf
Added statx to glibc_compatibility
2022-09-04 20:21:13 +03:00
Ilya Golshtein
74561b40ae
stylecheck renewed
2022-09-02 17:42:18 +03:00
Antonio Andelic
e64436fef3
Fix typos with new codespell
2022-09-02 08:54:48 +00:00
BoloniniD
cba94e106f
Remove posix_spawn for now, add execvpe impl
2022-09-01 20:36:47 +03:00
Robert Schulze
bfa67ffc8c
Update base/base/itoa.h
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-01 10:31:34 +02:00
Robert Schulze
d43f4e6317
fix: typo
2022-08-31 10:57:27 +00:00
Robert Schulze
cedf75ed5e
Enable clang-tidy for headers
...
clang-tidy now also checks code in header files. Because the analyzer
finds tons of issues, activate the check only for directory "base/" (see
file ".clang-tidy"). All other directories, in particular "src/" are
left to future work.
While many findings were fixed, some were not (and suppressed instead).
Reasons for this include: a) the file is 1:1 copypaste of a 3rd-party
lib (e.g. pcg_extras.h) and fixing stuff would make upgrades/fixes more
difficult b) a fix would have broken lots of using code
2022-08-31 10:48:15 +00:00
BoloniniD
8e6dcf18df
Add posix_spawn for posix_file_actions_
2022-08-30 20:18:08 +03:00
BoloniniD
cb32fa4512
Add all posix_spawn_file_actions_ functions
2022-08-30 21:03:45 +03:00
Alexander Tokmakov
44c6c85f75
Merge pull request #40756 from ClickHouse/libuv_update
...
Merging #39398
2022-08-30 14:38:50 +03:00
Suzy Wang
cad4eeb891
Correct __dup3() to dup3()
2022-08-28 18:03:07 -07:00
BoloniniD
14216d1dc0
Move statx to glibc-compatibility
2022-08-28 16:40:10 +03:00
BoloniniD
d1e2267f58
Move statx to glibc-compatibility
2022-08-26 15:18:24 +03:00
BoloniniD
de45f7cf5d
Delete fstatat.c
2022-08-26 15:17:18 +03:00