thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-13 18:02:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
30,842 Commits 9,328 Branches 1,783 Tags 2.1 GiB
055f21c9b7
Commit Graph

16828 Commits

Author SHA1 Message Date
Vladimir Chebotarev
255da8f5e0 Fixed style. 2019-10-24 12:11:06 +03:00
Vladimir Chebotarev
3debdc2119 Added integration tests for ALTER MOVE PARTITION and fixed minor things. 2019-10-24 11:52:33 +03:00
chertus
9818eada69 rename: merge_max_block_size 2019-10-24 02:18:21 +03:00
Artem Zuikov
18a72fa91a
Merge pull request #7392 from amosbird/scalar 
better scalar query
 2019-10-23 22:54:30 +03:00
Azat Khuzhin
ab9d9f8997 Fix INSERT into Distributed non local node with MATERIALIZED columns 
Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891
 2019-10-23 21:54:27 +03:00
Artem Zuikov
bb1c1d0ed9
Merge pull request #7431 from arenadata/master 
fix aggregation (avg and quantiles) over empty decimal columns.
 2019-10-23 20:28:35 +03:00
chertus
20093fa065 extract more logic out of QueryNormalizer 2019-10-23 16:59:03 +03:00
Amos Bird
295864e6e0
better scalar query 2019-10-23 21:37:54 +08:00
alesapin
c3519ff376 Better check of dictionary lifetime for updates 2019-10-23 16:02:40 +03:00
Alexander Kuzmenkov
1a609c27bd
Merge pull request #6243 from ClickHouse/aku/hashtables 
Introduce String Hash Map to speed up aggregation over short string keys.
 2019-10-23 12:52:50 +03:00
alesapin
6a0246f58e Fix if 2019-10-23 12:40:09 +03:00
alesapin
0abb2e538b Remove strange logic 2019-10-23 12:36:20 +03:00
alesapin
fb349757ba Fix ubsan error 2019-10-23 12:27:34 +03:00
akonyaev
7426542b8b up precision for avg result to max of type 2019-10-23 11:22:51 +03:00
alexey-milovidov
5c73a75843
Merge pull request #7439 from volfco/master 
Fixed spelling error in error message
 2019-10-23 07:33:56 +03:00
alexey-milovidov
44d2e1d27c
Merge pull request #7419 from amosbird/dump2 
Resolve DUMP overload resolution ambiguity.
 2019-10-23 07:19:38 +03:00
alexey-milovidov
f8d408e8f4
Merge pull request #7423 from excitoon/patch-1 
Fixed erroneous warning `max_data_part_size is too low`
 2019-10-23 07:17:33 +03:00
Nikolai Kochetov
9abab40512 Added more comments. 2019-10-23 06:45:43 +03:00
Colum
a413770a97 Fixed spelling error in error message 2019-10-22 10:02:51 -07:00
alesapin
c12014ca15 Fix shared build 2019-10-22 19:47:11 +03:00
alesapin
dfa9b0c149 Remove complex logic with lazy load 2019-10-22 19:26:15 +03:00
akonyaev
71dd3a303e fix result type for avg aggregation 2019-10-22 18:31:56 +03:00
Vladimir Chebotarev
9446fd2c4d Allowed to have some parts on destination disk or volume in MOVE PARTITION. #7424 2019-10-22 17:45:01 +03:00
Nikolai Kochetov
bcc4c2f0af Disable processors by default. 2019-10-22 17:11:29 +03:00
Nikolai Kochetov
640da3f512 Try to fix AggregateFunctionGroupBitmap. 2019-10-22 16:59:13 +03:00
alesapin
dc6090a2ac More readable code in external loader 2019-10-22 16:41:17 +03:00
alesapin
ae42dd1cea Better doLoading locking logic 2019-10-22 15:57:58 +03:00
akonyaev
6655eb6358 fix 2019-10-22 15:34:36 +03:00
alesapin
d3461f9d46 TODO comments 2019-10-22 14:03:16 +03:00
alesapin
99fac92b1d Fix comment 2019-10-22 13:49:11 +03:00
alesapin
4c5d150d7a Review fixes 2019-10-22 13:47:43 +03:00
Alexander Kuzmenkov
dfd9f26652 Port the latest dispatch() improvements. 2019-10-22 13:44:08 +03:00
Ivan
7ba4e36e73
Don't push to MVs when inserting into Kafka table (#7265) 
* Do not insert values into MV when inserting directly to Kafka
* Add method noPushingToViews() to IStorage interface
  To separate InterpreterInsertQuery and StorageKafka
 2019-10-22 13:31:28 +03:00
Vladimir Chebotarev
395e63ddf1
Fixed erroneous warning max_data_part_size is too low #7414 2019-10-22 12:24:30 +03:00
Amos Bird
88834bd75a
Resolve DUMP overload resolution ambiguity. 2019-10-22 15:10:59 +08:00
Nikolai Kochetov
dad1e397e2 Fix build. 2019-10-22 02:51:36 +03:00
Nikolai Kochetov
e7ba48ee84 Fix build. 2019-10-22 02:49:44 +03:00
Artem Zuikov
21e4535fbd
Merge pull request #7411 from 4ertus2/some 
Minor Visitors Improvement
 2019-10-21 23:17:05 +03:00
Vitaly Baranov
f611fd4dfa
Merge pull request #7293 from Vdimir/feature/isvalidjson-5910 
Add function isValidJSON
 2019-10-21 21:24:18 +03:00
chertus
f024b007a2 default_merge_block_size setting 2019-10-21 20:57:26 +03:00
alesapin
83dbfe9634 New tests and fixes for them 2019-10-21 20:09:41 +03:00
Nikolai Kochetov
2b334a4adb Review fixes. 2019-10-21 19:26:29 +03:00
chertus
851b00c99f minor visitors improvement 2019-10-21 19:22:54 +03:00
alesapin
10f69eef03 Add tests for non standart dictionaries and fix bugs 2019-10-21 19:05:45 +03:00
Nikolai Kochetov
2893c35930 Merged with master. 2019-10-21 18:33:44 +03:00
Nikolai Kochetov
4ca83a8eb5 Disable processors by default. 2019-10-21 18:24:15 +03:00
Nikolai Kochetov
f7d2e1b758 Added Pipe class. Updated MergeTreeDataSelectExecutor. 2019-10-21 18:16:08 +03:00
alesapin
ff7850cfbd Remove strange code in favor of less strange code 2019-10-21 17:59:35 +03:00
Alexander Kuzmenkov
d865aeba9b Review fixes. 2019-10-21 17:54:53 +03:00
alesapin
307f711500 Fix db mysql dictionaries iterator 2019-10-21 17:25:21 +03:00
alesapin
f7043c38bd Less diff 2019-10-21 17:20:42 +03:00
alesapin
fc05110d66 Better naming 2019-10-21 17:07:47 +03:00
alesapin
17c2f301e2 Remove accident cerr 2019-10-21 17:00:18 +03:00
alesapin
e4a936cf41 Fix add and reload 2019-10-21 16:54:23 +03:00
Vitaly Baranov
a0ca932035
Fix build and add comments. 2019-10-21 16:39:55 +03:00
Amos Bird
a864447802 Introduce String Hash Map. 
It speeds up aggregation over short string keys. Use it as a default
aggregation method for string keys.
 2019-10-21 16:27:35 +03:00
akonyaev
f6bb52637d return for empty avg result over decimal 0 in ResultT type 2019-10-21 16:05:32 +03:00
robot-clickhouse
7381489d5d Auto version update to [19.17.1.1] [54428] 2019-10-21 15:48:00 +03:00
akonyaev
28710b7e42 unexpected behaviour for avg and quantile functions over empty decimal column without group by 2019-10-21 15:46:47 +03:00
chertus
4f0859a5fa Merge branch 'master' into ast 2019-10-21 15:08:05 +03:00
chertus
5ef7376cbf fix distributed join on 2019-10-21 14:22:22 +03:00
alesapin
26c87e46c9 Merge branch 'master' into dictionaries_ddl_loader 2019-10-21 11:46:49 +03:00
alesapin
35e66d6696 Merge with master 2019-10-21 11:46:11 +03:00
alexey-milovidov
8b8cc67873
Merge pull request #7390 from azat/processlist-log-queue_max_wait_ms 
Add a message in case of queue_wait_max_ms wait takes place
 2019-10-20 17:55:36 +03:00
Aleksey Akulovich
a019e45093 fix typos in docs and comment (#7385) 2019-10-20 12:43:54 +08:00
VDimir
797f76a187 Separate class for IsValidJSONImpl 2019-10-19 07:26:19 +00:00
alexey-milovidov
52bfa9927c
Merge pull request #7384 from ClickHouse/fix_ub_in_system_parts 
Fix UB in StoragesInfoStream
 2019-10-19 09:59:39 +03:00
VDimir
f1630b4e2e Merge branch 'master' into feature/isvalidjson-5910 2019-10-19 06:21:21 +00:00
Azat Khuzhin
260a9fba2b StorageDistributed: Drop extra inclusion of materializeBlock.h 2019-10-18 23:38:33 +03:00
Azat Khuzhin
94948c2579 Add a message in case of queue_wait_max_ms wait takes place 
Since there no information about this, while this can be interesting,
for example to tune max_concurrent_queries in some cases.
 2019-10-18 23:36:12 +03:00
chertus
c5a850240c better ambiguous column detection in multiple join rewriter 2019-10-18 20:09:17 +03:00
chertus
2533652847 columns match priority: table alias > table name> aliased table name 2019-10-18 19:16:57 +03:00
alesapin
cdc195727e Fix some races from lazy load and add ugly interface to loader (need to be refactored) 2019-10-18 19:04:09 +03:00
Alexander Kuzmenkov
5e2cc37381
Distinguish Array and Tuple field types when creating from array of Fields. (#7179) 2019-10-18 18:57:05 +03:00
Alexander Tokmakov
06b28f9fe3 fix uninitialized offset for Lazy db 2019-10-18 16:09:24 +03:00
Alexander Kuzmenkov
3143fa37d7
Merge pull request #7371 from CurtizJ/fix-optimize-read-in-order 
Fix optimize_read_in_order with IN and a subquery.
 2019-10-18 15:55:53 +03:00
hcz
502672c973 Add aggregate function combinators: -OrNull & -OrDefault (#7331) 2019-10-18 12:25:39 +03:00
alesapin
71cbe878fc
Merge pull request #7374 from millb/fixed_getMultipleValuesFromConfig 
Fixed function getMultipleValuesFromConfig
 2019-10-18 11:55:41 +03:00
alexey-milovidov
3803d94db6
Merge pull request #7376 from amosbird/helpakuzm 
Fix ubsan introduced by Field refactoring.
 2019-10-18 06:29:27 +03:00
chertus
0f6176cc2d throw on ambiguous qualified column 2019-10-18 00:08:28 +03:00
Mikhail Korotov
a1f417a537
Update gtest_getMultipleValuesFromConfig.cpp 2019-10-18 00:07:27 +03:00
Amos Bird
16d1b4472e Fix ubsan introduced by Field refactoring. 2019-10-18 04:30:33 +08:00
alesapin
b222ec1209 Fix segmentation fault 2019-10-17 20:53:08 +03:00
alesapin
c29b39002d Fix race condition, add test 2019-10-17 20:36:53 +03:00
alesapin
05392fd882 Fix deadlock, add test and refactoring 2019-10-17 20:18:54 +03:00
millb
26d9ee3ae5 Fixed bug with function getMultipleValuesFromConfig and added test which confirms this. 2019-10-17 19:52:47 +03:00
vzakaznikov
66675edf2d Fixing data race with no_users_thread. (#7353) 2019-10-17 17:47:36 +03:00
vzakaznikov
ee1a2ce027 Fixing AddressSanitizer error in the LIVE VIEW getHeader() method. (#7271) 2019-10-17 17:43:11 +03:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00
Alexander Kuzmenkov
b62c9e729d
Merge pull request #7215 from ClickHouse/formats_improvements 
Miscellaneous formats improvements
 2019-10-17 17:37:38 +03:00
Alexander Kuzmenkov
3e662da6f4
Merge pull request #7351 from Enmk/http_keep_alive_timeout 
Fixed issue of using HTTP timeout as TCP timeout value.
 2019-10-17 16:14:29 +03:00
CurtizJ
546414c015 fix optimize_read_in_order with in subquery 2019-10-17 16:11:27 +03:00
akonyaev
22429a699e unexpected behaviour for avg over empty decimal column without group by 2019-10-17 16:08:04 +03:00
alesapin
6dfe5c7142 Better introspection 2019-10-17 16:05:12 +03:00
Ivan
e595df05d9
Fix CREATE TABLE AS from table with virtual columns (#7183) 
* Disable undefined instrumentation for rdkafka
 2019-10-17 14:12:35 +03:00
Alexander Kuzmenkov
e9d7da3dd4
Merge pull request #7359 from amosbird/joingetconst 
Constness-aware JoinGet.
 2019-10-17 13:35:37 +03:00
philip.han
08a348fbd1 Made IN operator support Array(LowCardinality(Nullable(String))) 2019-10-17 19:08:36 +09:00
alesapin
3987a45ea2 Fix build and style 2019-10-17 12:05:48 +03:00
Amos Bird
89247deb64 Constness-aware JoinGet. 2019-10-17 08:52:28 +08:00
tavplubix
c4b46e113e
Merge branch 'master' into formats_improvements 2019-10-16 23:00:17 +03:00