thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-17 03:42:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
112,895 Commits 9,315 Branches 1,783 Tags 2.1 GiB
056268f90b
Commit Graph

40094 Commits

Author SHA1 Message Date
Alexander Gololobov
0b9579bfb8 Reworked, testing 2023-04-14 16:12:18 +02:00
Alexander Gololobov
02876ed87d Share PreparedSet-s between task of the same mutation to reduce mem usage 2023-04-14 16:12:18 +02:00
kssenii
c08e6d6c5f Better processing of relative cache path 2023-04-14 15:52:51 +02:00
Dmitry Novik
352a240a20
Merge pull request #47984 from ClickHouse/optimize-compilation 
Optimize compilation
 2023-04-14 15:34:46 +02:00
Azat Khuzhin
9f694a328b Fix skip_unavailable_shards in case of unavailable hosts 
In #26658 only one excessive connect had been removed, but due to
RemoteQueryExecutor will execute query again in read(), there is one
more, fix this by correctly mark connection in sendQuery()

But note, that there still will be excessive connections due to separate
connections for obtaining structure.

Follow-up for: #26658
Fixes: #48728
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-14 14:15:45 +02:00
Kseniia Sumarokova
9eee7c72fe
Merge pull request #47307 from kssenii/better-tests-for-data-lakes 
deltalake/iceberg/hudi improvements
 2023-04-14 12:13:17 +02:00
Kseniia Sumarokova
6a0d9a37ce
Merge branch 'master' into fix-mysql-named-collection 2023-04-14 12:03:51 +02:00
Sergei Trifonov
ea19c5281c
Merge pull request #48750 from ClickHouse/lower-threadpool-mutex-contention 2023-04-14 12:03:51 +02:00
Robert Schulze
2378df0a47
Merge pull request #48763 from ClickHouse/rs/fix-squashing 
Fix squashing in query cache
 2023-04-14 11:44:58 +02:00
Robert Schulze
adb15b7033
Merge branch 'master' into show-table 2023-04-14 09:52:56 +02:00
lgbo-ustc
3a5e0b2e31 update the result of groupArray(NULL) 2023-04-14 13:12:03 +08:00
Sergei Trifonov
7cb6303e4c
Merge branch 'master' into lower-threadpool-mutex-contention 2023-04-14 03:26:39 +02:00
lgbo-ustc
981c52fa41 groupArray returns cannot be nullable 2023-04-14 09:24:15 +08:00
Igor Nikonov
267cd097bf
Merge pull request #48729 from ClickHouse/fix-memory-order-in-number_mt 
Fix memory order in number_mt
 2023-04-13 23:57:36 +02:00
Kseniia Sumarokova
54518bf928
Merge branch 'master' into better-tests-for-data-lakes 2023-04-13 23:45:12 +02:00
Robert Schulze
a09db7f4f5
Fix squashing in query cache 2023-04-13 20:09:29 +00:00
Robert Schulze
43b8cbc50c
Merge pull request #48737 from ClickHouse/rs/fix-wshadow 
Remove `-Wshadow` suppression which leaked into global namespace
 2023-04-13 21:18:50 +02:00
Alexander Tokmakov
af1bf08663
Revert "Add MemoryTracker for the background tasks" 2023-04-13 21:05:02 +03:00
Anton Popov
5f01b8a2b5
Merge pull request #48517 from CurtizJ/fix-memory-compressed-tables 
Fix storage `Memory` with enabled compression
 2023-04-13 19:52:49 +02:00
pufit
abe3c9b9db
Merge pull request #48758 from ClickHouse/revert-48679-scheme-infer 
Revert "Make Schema inference works for CREATE AS SELECT"
 2023-04-13 13:46:30 -04:00
Anton Popov
4a1c868ca9
Merge pull request #48663 from CurtizJ/fix-async-insert-no-data 
Fix async inserts with empty data
 2023-04-13 19:44:47 +02:00
kssenii
ad48e1d010 Fox 2023-04-13 19:36:25 +02:00
pufit
d717372c6e
Revert "Make Schema inference works for CREATE AS SELECT" 2023-04-13 13:35:32 -04:00
pufit
a8c892f925
Merge pull request #48679 from ucasfl/scheme-infer 
Make Schema inference works for CREATE AS SELECT
 2023-04-13 13:02:04 -04:00
serxa
22b75ec81b fix typo, add coment, dont reset trace 2023-04-13 15:17:39 +00:00
Alexander Tokmakov
0fbc9585f1
Merge pull request #48471 from jrdi/16414-totimezone-throw 
toTimeZone function throw an error when no constant string is provided
 2023-04-13 17:57:37 +03:00
Dmitry Novik
5cc9b46f78 Merge remote-tracking branch 'origin/master' into optimize-compilation 2023-04-13 16:04:09 +02:00
kssenii
6f53784f22 Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes 2023-04-13 15:56:40 +02:00
Alexander Tokmakov
93368b4d55
Merge pull request #48730 from ClickHouse/remove_some_code 
Do not remove broken detached parts on startup
 2023-04-13 16:18:59 +03:00
Sergei Trifonov
c51f1359be
Merge branch 'master' into lower-threadpool-mutex-contention 2023-04-13 14:21:45 +02:00
serxa
32f78afd7e get rid of redundant code 2023-04-13 12:11:06 +00:00
Jordi Villar
eb32b710f0 Merge remote-tracking branch 'origin/master' into 16414-totimezone-throw 2023-04-13 14:03:45 +02:00
Jordi Villar
3e882e0c7d Remove unnecessary logger 2023-04-13 14:03:05 +02:00
serxa
ce2073e58f detach_thread() and notifications order does not matter 2023-04-13 11:45:19 +00:00
kssenii
3ac7f999bc Review fixes 2023-04-13 13:38:16 +02:00
Dmitry Novik
467ecf45e1
Merge pull request #46089 from ClickHouse/background-memory-tracker 
Add MemoryTracker for the background tasks
 2023-04-13 13:29:27 +02:00
serxa
5e8339c2d9 Lock ThreadPool mutex once per job instead of twice 2023-04-13 11:27:11 +00:00
Vitaly Baranov
6b71cb1c35 Fix zero-copy-replication on encrypted disks. 2023-04-13 13:15:18 +02:00
Robert Schulze
3e3344d627
VarInt coding: Always perform sanity check 
This is follow-up for the discussion in #48628. The sanity check against
VAR_UINT_MAX is now unconditional (independent of the build type). Let's
see how that affects performance ... I'll probably add "Unchecked"
overloads later on (to avoid clutter they are avoided for now)
 2023-04-13 09:44:35 +00:00
Robert Schulze
658d6c8870
Merge pull request #48567 from FriendLey/test_soundex 
add soundex function, issue #39880
 2023-04-13 11:20:19 +02:00
Kseniia Sumarokova
b6c17759f4
Merge pull request #48636 from kssenii/fix-error-in-cache 
Fix possible error from cache
 2023-04-13 11:03:11 +02:00
Robert Schulze
f6b24fe058
Merge pull request #48509 from ClibMouse/feature/no-more-strlen-plz 
Use std::string_view to get rid of strlen
 2023-04-13 10:59:05 +02:00
Robert Schulze
7a21d5888c
Remove -Wshadow suppression which leaked into global namespace 2023-04-13 08:46:40 +00:00
Robert Schulze
22c3b10e41
Merge pull request #48628 from ClickHouse/rs/var_uint_max 
Better handling of values too large for VarInt encoding
 2023-04-13 10:17:55 +02:00
Robert Schulze
f41354ccd6
Merge pull request #48671 from ClickHouse/rs/gcc-removal 
Remove GCC remainders
 2023-04-13 10:15:35 +02:00
Sergei Trifonov
86d37916a0
Merge pull request #48146 from azat/threadpool-pipeline-executor 
Use ThreadPool in PipelineExecutor
 2023-04-13 09:45:15 +02:00
FriendLey
50af10771e
Merge branch 'master' into test_soundex 2023-04-13 10:17:08 +08:00
Robert Schulze
700492f6d4
Fixes and refactorings for consistency with the remaining codebase 2023-04-12 22:41:26 +00:00
Alexander Tokmakov
75f18b1198
Revert "Check simple dictionary key is native unsigned integer" 2023-04-13 01:32:19 +03:00
Alexander Tokmakov
5d77bb149e do not remove broken detached parts on startup 2023-04-12 23:26:34 +02:00
Anton Popov
05a93ef123 add flush id and time for async insert with empty data 2023-04-12 20:57:55 +00:00
Robert Schulze
3f7ce60e03
Merge branch 'master' into rs/gcc-removal 2023-04-12 22:17:04 +02:00
robot-ch-test-poll2
d1793a9bc5
Merge pull request #48692 from ClickHouse/rs/mergetree-syntax 
Update MergeTree syntax for optional index granularity argument
 2023-04-12 21:35:40 +02:00
Igor Nikonov
e3b61a4ea7 Fix memory order in number_mt 2023-04-12 19:35:12 +00:00
ltrk2
c3f5da3343 Remove element that used to serve as a sentinel 2023-04-12 12:15:53 -07:00
Alexey Milovidov
9a3030803e
Merge pull request #48596 from azat/ci/second_deadlock_stack 
Add second_deadlock_stack=1 for TSan on CI and fix some lock-order-inversion problems
 2023-04-12 22:11:06 +03:00
Alexander Tokmakov
69790b76b2 fix the same issue in other functions 2023-04-12 20:36:23 +02:00
ltrk2
65e08781a6 Use std::string_view to get rid of strlen 2023-04-12 11:33:11 -07:00
Azat Khuzhin
37d430d68a Use ThreadPool in PipelineExecutor 
PipelineExecutor is one of the heavy user of the threads, by using pool
there number of used threads for query execution can be tracked in
system.metrics.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-12 20:00:51 +02:00
alesapin
8067cfcb51
Merge pull request #46946 from ClickHouse/revert-46909-revert-45911-mutations_rename_hang 
Fix several `RENAME COLUMN` bugs
 2023-04-12 19:07:48 +02:00
Alexander Tokmakov
71258202bb Merge branch 'master' into 16414-totimezone-throw 2023-04-12 17:58:48 +02:00
Kseniia Sumarokova
17bb707752
Merge branch 'master' into fix-error-in-cache 2023-04-12 17:40:15 +02:00
Dmitry Novik
6c11acccc9 Remove unnecessary code 2023-04-12 14:08:09 +00:00
Anton Popov
08aa629e56
Merge branch 'master' into fix-memory-compressed-tables 2023-04-12 15:38:54 +02:00
Anton Popov
1520f3e924
Merge pull request #48335 from lzydmxy/check_sample_dict_key_is_correct 
Check simple dictionary key is native unsigned integer
 2023-04-12 14:27:39 +02:00
MikhailBurdukov
2cd3512a5d
ClickHouse startup error when loading a distributed table that depends on a dictionary (#48419) 
* Test for start failure.

* Handling the dictionary as shard key.

* Added integration test and fixed style

* Revert extra test

* Fix style

* Fix style

* Refactoring

* Fix build

* style fix
 2023-04-12 15:06:02 +03:00
Nikolai Kochetov
f66e9c5a26
Merge pull request #48427 from ClickHouse/update_sort_desc_follow_up 
Update sort desc: more efficient original node search in ActionsDAG
 2023-04-12 13:59:37 +02:00
Nikolay Degterinsky
ff20acf076
Merge pull request #48445 from evillique/array-functions-date-datetime-support 
Add support for Date/DateTime datatypes to arrayMin/Max, arrayDifference functions
 2023-04-12 13:27:17 +02:00
Robert Schulze
6b441b40dd
Update MergeTree syntax for optional index granularity argument 
This is follow up to #45451.
 2023-04-12 11:16:55 +00:00
FriendLey
63928c6df0
Merge branch 'master' into test_soundex 2023-04-12 19:06:05 +08:00
alesapin
8ebad126e2
Merge pull request #48516 from MikhailBurdukov/mburdukov_multi_settings 
"changed" flag in system.settings is calculated incorrectly for settings with multiple values
 2023-04-12 12:54:50 +02:00
Kruglov Pavel
aa57cdb5f3
Merge pull request #48670 from azat/fix-lock-order-inversion-for-remote 
Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1)
 2023-04-12 12:42:12 +02:00
Nikolai Kochetov
bc4755952b
Merge pull request #48405 from ClickHouse/analyzer-additional-filters 
Support additional filters in new planner
 2023-04-12 12:38:57 +02:00
alesapin
55c3f1ee29
Merge pull request #48666 from ClickHouse/remove_strange_code_from_mutation_task 
Remove strange code from MutateTask
 2023-04-12 12:38:43 +02:00
Igor Nikonov
943f9f541b Call IProcessor::onCancel() once 2023-04-12 10:04:31 +00:00
Azat Khuzhin
5277c802f7 Fix table dependencies in case of failed RENAME TABLE 
CI found this [1]

    [ 382620 ] {} <Error> Application: Caught exception while loading metadata: Code: 60. DB::Exception: Table test_25.join doesn\'t exist: While processing _CAST(joinGet(test_25.join, \'m\', CAST(\'42\', \'int\')) AS m_tmp_alter1351896088559986425, \'Int32\') AS m: default expression and column type are incomp
    [ 382620 ] {} <Error> Application: Code: 60. DB::Exception: Table test_25.join doesn\'t exist: While processing _CAST(joinGet(test_25.join, \'m\', CAST(\'42\', \'int\')) AS m_tmp_alter1351896088559986425, \'Int32\') AS m: default expression and column type are incompatible.: Cannot attach table `test_25`.`t

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48670/d7f865037266ed87538cf4df7ec7e8165681871b/stress_test__asan_.html

The problem here is that after failed RENAME dependencies got lost:

    [4e937f39d866] 2023.04.12 00:51:06.833624 [ 13419 ] {61429225-64cb-4fce-b60d-01e0dac6e52c} <Error> executeQuery: Code: 241. DB::Exception: Memory limit (total) exceeded: would use 34.65 GiB (attempt to allocate chunk of 2097419 bytes), maximum: 34.29 GiB. OvercommitTracker decision: Memory overcommit has freed not enough memory. (MEMORY_LIMIT_EXCEEDED) (version 23.4.1.1) (from [::1]:45710) (comment: 01160_table_dependencies.sh) (in query: create database test_25_1), Stack trace (when copying this message, always include the lines below):
    [4e937f39d866] 2023.04.12 00:51:07.351914 [ 5151 ] {66d8bdd4-668e-4239-a8af-6b8f17bb5222} <Error> executeQuery: Code: 81. DB::Exception: Database test_25_1 doesn't exist. (UNKNOWN_DATABASE) (version 23.4.1.1) (from [::1]:45762) (comment: 01160_table_dependencies.sh) (in query: rename table t to test_25_1.t), Stack trace (when copying this message, always include the lines below):

And from the test output:

    OK
    OK
    OK
    OK
    a       []      []      []
    data_02344      []      []      []
    date_table      []      []      []
    dict1   []      ['dict_src']    ['join']
    dict2   []      ['join']        []
    dict_src        []      []      ['dict1']
    dist_02346      []      []      []
    join    []      ['dict1']       ['dict2','s']
                                    ^^^^^^^^^^^^^ no "t"

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-12 11:11:05 +02:00
Robert Schulze
53d0f76762
Fix fasttest 2023-04-12 08:31:13 +00:00
SmitaRKulkarni
dd64eaed66
Merge pull request #47985 from Algunenano/zk_retry_timeout 
Do not continue retrying to connect to ZK if the query is killed or over limits
 2023-04-12 08:49:47 +02:00
Yatsishin Ilya
514bb8aff5 Merge remote-tracking branch 'origin' into clickhouse-help 2023-04-12 06:45:22 +00:00
flynn
ea9187511e Make Schema inference works for CREATE AS SELECT 2023-04-12 04:21:03 +00:00
taiyang-li
e29cce4db9 support map node for json extract 2023-04-12 10:18:07 +08:00
Dmitry Novik
235ad55bad
Merge branch 'master' into analyzer-additional-filters 2023-04-12 01:13:38 +02:00
alesapin
f91309d83d Fix drop in compact parts 2023-04-11 21:21:42 +02:00
Azat Khuzhin
1d9a785b9b Add missing includes (due to removing ThreadPool.h from PipelineExecutor.h) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-11 20:45:46 +02:00
Robert Schulze
05606a8835
Clean up GCC warning pragmas 2023-04-11 18:21:08 +00:00
Azat Khuzhin
d7f8650372 Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1) 
It looks redundant, since sendQuery() cannot be executed in parallel
with processPacket() (hence RemoteQueryExecutor::setPartUUIDs())

This likely will fix the lock-order-inversion in RemoteQueryExecutor,
since I think it is false-positive.

Fixes: #48534
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-11 20:19:32 +02:00
alesapin
a72ee0b85e Merge remote-tracking branch 'origin/master' into revert-46909-revert-45911-mutations_rename_hang 2023-04-11 20:14:43 +02:00
Robert Schulze
dcfd843b2d
Merge pull request #48489 from ClickHouse/rs/date_time-alias 
Register datediff and trim aliases in system.functions
 2023-04-11 19:53:44 +02:00
alesapin
165edd332e Remove strange code from MutateTask 2023-04-11 18:31:53 +02:00
Robert Schulze
1477887259
Initial removal of logic under COMPILER_GCC 2023-04-11 16:27:32 +00:00
Dmitry Novik
52f3406bbb Fix CurrentMetrics::MergesMutationsMemoryTracking value 2023-04-11 16:10:59 +00:00
Sergei Trifonov
7c309a0134
Merge branch 'master' into mburdukov_multi_settings 2023-04-11 17:53:43 +02:00
Dmitry Novik
06e6794fc0 Merge remote-tracking branch 'origin/master' into background-memory-tracker 2023-04-11 15:29:35 +00:00
Alexander Tokmakov
1982e2e040
Merge pull request #48662 from hanfei1991/hanfei/refine-expmsg1 
fix 02504_regexp_dictionary_table_source
 2023-04-11 18:20:10 +03:00
Anton Popov
09c66c3879 fix async inserts with empty data 2023-04-11 15:13:46 +00:00
Han Fei
bf28be8837 fix 02504_regexp_dictionary_table_source 2023-04-11 17:07:44 +02:00
Mikhail f. Shiryaev
89e4509e68
Merge branch 'master' into fix-memory-compressed-tables 2023-04-11 16:38:51 +02:00
Anton Popov
3896375247 fix getting subcolumn from in-memory data 2023-04-11 14:26:31 +00:00
Dmitry Novik
0e417b1a6f Cleanup the code 2023-04-11 14:08:28 +00:00
Yakov Olkhovskiy
6232d17876
Merge pull request #48611 from ClickHouse/fix-ip4-uint-compare 
Fix IPv4 comparable with UInt
 2023-04-11 09:53:33 -04:00
Anton Popov
5b8db57fe8
Merge branch 'master' into retry-loading-of-parts 2023-04-11 15:51:40 +02:00
Robert Schulze
1fc5d92ae2
Merge pull request #48627 from ClickHouse/rs/formatdatetime-refactoring 
Minor refactoring of formatDateTime()
 2023-04-11 15:29:47 +02:00
Kseniia Sumarokova
10bb328d7d
Merge branch 'master' into fix-error-in-cache 2023-04-11 15:25:38 +02:00
Anton Popov
5a77a2aa4c
Merge branch 'master' into CurtizJ-patch-7 2023-04-11 15:06:07 +02:00
FriendLey
e327371297
Merge branch 'master' into test_soundex 2023-04-11 21:02:01 +08:00
Han Fei
7210b50551
Merge pull request #48632 from hanfei1991/hanfei/refine-expmsg 
refine some messages of exception in regexp tree
 2023-04-11 14:45:35 +02:00
Antonio Andelic
b30aff06d8
Merge pull request #48595 from aalexfvk/alexfvk/fix_create_not_auth_problem 
Fix bug in Keeper when a node is not created with scheme `auth` in ACL sometimes.
 2023-04-11 14:41:37 +02:00
Kruglov Pavel
c3482a104f
Merge pull request #48472 from ClickHouse/Avogar-patch-2 
Avoid operation on uninitialised data in readDateTimeTextImpl
 2023-04-11 14:30:26 +02:00
robot-ch-test-poll1
028ccfdc87
Merge pull request #48438 from evillique/add-trailing-commas 
Allow trailing commas in expression list of SELECT query
 2023-04-11 14:21:28 +02:00
Robert Schulze
e08b7c8a53
Merge pull request #48422 from ClickHouse/rs/better-f-in-formatdatetime 
MySQL compat: Align behavior of %f in formatDateTime() with parseDateTime()
 2023-04-11 14:12:16 +02:00
Robert Schulze
4e52dc672e
Merge pull request #48420 from ClickHouse/rs/f 
MySQL compat: Implement %f in parseDateTime()
 2023-04-11 14:12:02 +02:00
SmitaRKulkarni
e2010c0257
Merge branch 'master' into zk_retry_timeout 2023-04-11 14:05:52 +02:00
Han Fei
c857f767fa
Merge branch 'master' into hanfei/refine-expmsg 2023-04-11 14:03:27 +02:00
Robert Schulze
ba67626992
Add comment about used exception code 2023-04-11 11:59:04 +00:00
vdimir
30659c5b48
Fix build ThreadGroupPtr 2023-04-11 11:46:53 +00:00
Kseniia Sumarokova
f4aa62ebc8
Merge branch 'master' into fix-error-in-cache 2023-04-11 13:40:46 +02:00
Sema Checherinda
4b9eff7dab
Merge pull request #48638 from ClickHouse/vdimir/fix-build-48543 
Fix build src/Interpreters/InterpreterInsertQuery.h
 2023-04-11 13:27:51 +02:00
Yatsishin Ilya
b5b65d2149 Merge remote-tracking branch 'origin' into clickhouse-help 2023-04-11 11:24:48 +00:00
Han Fei
6c33180ac8
Merge branch 'master' into hanfei/refine-expmsg 2023-04-11 13:19:38 +02:00
FriendLey
8aa17dbffe remove return in void function. 2023-04-11 19:18:27 +08:00
vdimir
4605d71947
Fix build src/Interpreters/InterpreterInsertQuery.h 2023-04-11 11:17:02 +00:00
FriendLey
c527347736
Merge branch 'master' into test_soundex 2023-04-11 19:16:10 +08:00
Sergei Trifonov
ca6e253fa6
Merge pull request #48526 from ClickHouse/lost-part-count 2023-04-11 13:11:42 +02:00
FriendLey
48463f79fd
Merge branch 'master' into test_soundex 2023-04-11 19:00:51 +08:00
kssenii
6717eab355 Fix 2023-04-11 12:35:59 +02:00
Kruglov Pavel
a0d11fdf53
Merge pull request #48436 from Avogar/fix-generate-random 
Generate valid Decimals and Bools in generateRandom function
 2023-04-11 12:06:08 +02:00
FriendLey
ffa1a75fb5 Merge branch 'master' into test_soundex 2023-04-11 17:52:32 +08:00
Sema Checherinda
4dd86a406a
Merge pull request #48543 from azat/mv-uniq-thread-group 
Use one ThreadGroup while pushing to materialized views (and some refactoring for ThreadGroup)
 2023-04-11 11:47:46 +02:00
Han Fei
363b97fab8 refine some messages of exception in regexp tree 2023-04-11 11:45:29 +02:00
Robert Schulze
bbbb55cd50
Better handling of values too large for VarInt encoding 
PR #48154 introduced a sanity check in the form of a debug assertion
that the input values for VarInt encoding are not too big. Such values
should be exceptionally rare in practice but the AST fuzzer managed to
trigger the assertion regardless. The strategy to deal with such values
until now was to bypass the check by limiting the value to the maximum
allowed value (see #48412). Because a new AST Fuzzer failure appeared
(#48497) and there may be more failures in future, this PR changes the
sanity check from an assert to an exception.

Fixes: #48497
 2023-04-11 07:47:33 +00:00
Aleksei Filatov
dd2364361c
Update src/Coordination/tests/gtest_coordination.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2023-04-11 10:45:30 +03:00
Robert Schulze
4b61685c64
Minor refactoring of formatDateTime() 
Don't explicitly specify literal length when the called functions can
compute it.
 2023-04-11 07:43:24 +00:00
Robert Schulze
c3f976c58a
Move space check out of loop 2023-04-11 06:19:10 +00:00
Robert Schulze
b7d5df7aa1
Merge branch 'master' into rs/better-f-in-formatdatetime 2023-04-11 08:11:04 +02:00
FriendLey
910bd8a15f bugfix: fix access illegal address bugs. 2023-04-11 13:01:53 +08:00
Alexey Milovidov
9e1db557e0
Merge pull request #48612 from ClickHouse/remove-strange-code-2 
Remove strange code
 2023-04-11 06:17:45 +03:00
FriendLey
6a3eb19821
Update src/Functions/soundex.cpp 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
 2023-04-11 09:49:52 +08:00
FriendLey
3d4c6e5a48
Update src/Functions/soundex.cpp 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
 2023-04-11 09:49:42 +08:00
FriendLey
baa29a5a2c
Update src/Functions/soundex.cpp 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
 2023-04-11 09:49:34 +08:00
FriendLey
0ac9f78c43
Update src/Functions/soundex.cpp 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
 2023-04-11 09:49:16 +08:00
FriendLey
a5d4a2065e
Update src/Functions/soundex.cpp 
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
 2023-04-11 09:49:06 +08:00
Alexey Milovidov
d259217cf3
Merge pull request #48570 from azat/build/logger_useful 
Remove superfluous includes of logger_userful.h from headers
 2023-04-11 03:56:39 +03:00
Alexey Milovidov
93b8fc74ef
Merge pull request #48571 from azat/dict/hashed/uncaught-exception-fix 
Fix uncaught exception in case of parallel loader for hashed dictionaries
 2023-04-10 23:11:01 +03:00
Alexey Milovidov
f4d6596eaa
Merge pull request #48577 from ClickHouse/evillique-patch-2 
Don't use type conversion with String query parameters
 2023-04-10 22:18:39 +03:00
Alexey Milovidov
23a0879452 Remove strange code 2023-04-10 21:17:08 +02:00
Yakov Olkhovskiy
e6d96c27f2 unnecessary include 2023-04-10 19:16:02 +00:00
Yakov Olkhovskiy
a6c99e8e84 add IPv4 to supertype calculation 2023-04-10 18:59:50 +00:00
Azat Khuzhin
013a3ed269 Fix possible lock order inversion in Context::setTemporaryStorageInCache() 
TSan report [1]:

    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=1)
      Cycle in lock order graph: M0 (0x7b9000000008) => M1 (0x7b90000000a8) => M0

      Mutex M1 acquired here while holding mutex M0 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ccb3a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getDisk() const build_docker/./src/Interpreters/Context.cpp:3281:21 (clickhouse+0x1d0ccb3a)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:927:21 (clickhouse+0x1d0cc188) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Mutex M0 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0cc148) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0cc148)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:922:17 (clickhouse+0x1d0cc148)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Muex M0 acquired here while holding mutex M1 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0c7ce1) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0c7ce1)
        5 DB::Context::getPath() const build_docker/./src/Interpreters/Context.cpp:713:17 (clickhouse+0x1d0c7ce1)
        6 DB::loadDiskLocalConfig() build_docker/./src/Disks/DiskLocal.cpp:75:30 (clickhouse+0x1ce7ed8a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        7 DB::DiskLocal::applyNewSettings() build_docker/./src/Disks/DiskLocal.cpp:491:5 (clickhouse+0x1ce7e7ef) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        8 DB::DiskSelector::updateFromConfig() const build_docker/./src/Disks/DiskSelector.cpp:92:19 (clickhouse+0x1d14088e) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        9 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3388:49 (clickhouse+0x1d0ec002) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        ..
        17 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

      Mutex M1 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ebf25) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3384:21 (clickhouse+0x1d0ebf25)
        ..
        12 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

    SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) (/usr/bin/clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280) in pthread_mutex_lock
    ==================

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[6/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2023-04-10 19:56:52 +02:00
Nikolai Kochetov
ba468eac45
Merge pull request #48485 from ClickHouse/read-step-for-system-zookeeper 
Add reading step for system zookeeper. Analyze path from filter DAG.
 2023-04-10 19:28:18 +02:00
Kseniia Sumarokova
65259d964b
Merge pull request #48167 from lzydmxy/add_columns_for_system_storage_policies 
Add columns for table `system.storage_policies`
 2023-04-10 18:32:13 +02:00