Commit Graph

86556 Commits

Author SHA1 Message Date
Anton Popov
0595b5c22b fix reading of empty arrays in reverse order 2022-04-13 21:50:57 +00:00
Alexander Gololobov
fcb83a12ff
Merge pull request #35953 from azat/ttl-mutations
Require mutations for per-table TTL only when it had been changed
2022-04-13 17:14:04 +02:00
Maksim Kita
ca89af89a1
Merge pull request #36088 from israelg99/fix_executable
Fix CH silently failing when it cannot execute a file
2022-04-13 16:53:00 +02:00
tavplubix
151399b6a0
Merge pull request #36194 from ClickHouse/tavplubix-patch-4
Follow-up to #36138
2022-04-13 17:27:58 +03:00
Vladimir C
3517064b60
Merge pull request #36191 from ClickHouse/extend-tls-documentation
Extend documentation about TLS configuration options
2022-04-13 16:07:43 +02:00
Vladimir C
77dac8e490
Merge pull request #36179 from CurtizJ/dynamic-columns-10 2022-04-13 15:57:32 +02:00
mergify[bot]
6c94ba3663
Merge branch 'master' into tavplubix-patch-4 2022-04-13 12:45:45 +00:00
tavplubix
43de4827d7
Merge pull request #36074 from ClickHouse/zookeeper_log_thread_query_id
Add thread_id and query_id to zookeeper_log
2022-04-13 15:34:04 +03:00
Mikhail f. Shiryaev
71dc0f0616
Merge pull request #36193 from ClickHouse/fix-fasttest
Dirty fix fasttest after addressing CVE-2022-24765
2022-04-13 14:23:50 +02:00
Mikhail f. Shiryaev
693711544c
Use a proper image in fasttest 2022-04-13 14:06:50 +02:00
tavplubix
7af954cef9
Update clickhouse-test 2022-04-13 14:37:44 +03:00
Mikhail f. Shiryaev
51685e0956
Dirty fix fasttest after addressing CVE-2022-24765 2022-04-13 13:36:28 +02:00
Kruglov Pavel
03fc08cec3
Merge pull request #36137 from azat/client-profile-events
ProfileEvents fixes
2022-04-13 12:27:39 +02:00
Michael Lex
7b0f1fbb88 Extend TLS documentation.
Information about used defaults.
Better explanation of the extendedVerification option (which enables hostname verification)
Better explanation of the caConfig option and how files vs. paths are treated.
Mention TLS config in CLI documentation and link to server-side settings (which are the same).
2022-04-13 12:07:37 +02:00
Kruglov Pavel
96a73a3392
Merge pull request #36169 from Avogar/fix-parallel-read-buffer
Fix crash in ParallelReadBuffer
2022-04-13 12:07:05 +02:00
Nikolai Kochetov
362fcfd2b8
Merge pull request #36075 from ClickHouse/fix-limit-push-down-over-window
Disable LIMIT push down through WINDOW functions.
2022-04-13 11:57:37 +02:00
Kseniia Sumarokova
d9ce08915a
Merge pull request #36130 from yuuch/support_MySQL_style_FORMAT_Vertical_before_semicolon
support  '\G;' at the end of query
2022-04-13 10:39:40 +02:00
Kseniia Sumarokova
6b6671e89f
Merge pull request #36164 from azat/client-local-format-error
clickhouse-client: properly cancel query in case of error during formatting data
2022-04-13 10:37:35 +02:00
Kseniia Sumarokova
9c0e96f111
Merge pull request #36175 from kssenii/fixing-s3-tests-1
Fix flacky test 01161_all_system_tables under s3 storage
2022-04-13 10:34:42 +02:00
Anton Popov
b066585cae
Apply suggestions from code review
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-04-12 22:12:58 +02:00
Azat Khuzhin
891c601589 Fix ProfileEvents overlaps (for multiple queries) in clickhouse-local
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 22:27:12 +03:00
Azat Khuzhin
54a1cea7fd Send ProfileEvents in clickhouse-local on query finish (like server does)
v2: send only for pulling pipelines
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 22:26:44 +03:00
Anton Popov
0679d4814d allow to convert empty string to objects 2022-04-12 18:58:40 +00:00
tavplubix
303ecc6f7d
Merge pull request #36136 from ClickHouse/transactions_fix_1
Minor fix for transactions
2022-04-12 21:38:47 +03:00
Azat Khuzhin
1a8b49b535 Remove redundant check from LocalConnection::finishQuery()
It is called from only one place, and under state->is_finished, so state
is there.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 21:18:52 +03:00
Azat Khuzhin
097e2f626d Do not overlap profile events snapshots for queries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
e38057ddb0 Fix code alignment in ProfileEventsExt
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
d9dd8f5f65 Fix filtering out snapshots from profile events
This fixes POSITION_OUT_OF_BOUND error:

    $ clickhouse-client --print-profile-events --profile-events-delay-ms=-1 -n -q 'select sleep(1); select 1'
    0
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] ContextLock: 9 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] FunctionExecute: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] MemoryTrackerUsage: 2132102 (gauge)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkReceiveElapsedMicroseconds: 139 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkSendBytes: 4850 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] NetworkSendElapsedMicroseconds: 1844 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] Query: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] RWLockAcquiredReadLocks: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectQuery: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectedBytes: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:48 [ 0 ] SelectedRows: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSCPUVirtualTimeMicroseconds: 1842 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSReadChars: 426 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] OSWriteChars: 322 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] RealTimeMicroseconds: 1002689 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] SleepFunctionCalls: 1 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] SleepFunctionMicroseconds: 1000000 (increment)
    [p1.azat.localdomain] 2022.04.12 19:31:49 [ 0 ] UserTimeMicroseconds: 1843 (increment)
    1
    Error on processing query: Code: 11. DB::Exception: Position out of bound in Block::erase(), max position = 5. (POSITION_OUT_OF_BOUND) (version 22.4.1.1)
    (query: select 1)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
1fa3e6a426 Fix printing ProfileEvents on client for multiple queries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
d46eaadacc tests: do not use process substution in 02050_client_profile_events
bash does not waits then and so if the next line will be executed fast
enough, result of process substituted command can appers in stdout after
it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
Azat Khuzhin
75789eb9a7 tests: improve 02050_client_profile_events
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 20:54:56 +03:00
kssenii
cefa64a846 Fix 2022-04-12 17:56:22 +02:00
Julian Gilyadov
a4f56f3330
Throw exception when file cant be executed instead of displaying success 2022-04-12 17:52:44 +02:00
Kruglov Pavel
fead4c184f
Merge pull request #35237 from olejeglejeg/patch-1
Kafka engine kafka_num_consumers prop upper bound doc update
2022-04-12 17:09:42 +02:00
Kruglov Pavel
5b46e9655a
Merge pull request #36067 from ClickHouse/Avogar-patch-4
Try to turn off always green backward compatibility checks
2022-04-12 16:20:07 +02:00
Kruglov Pavel
2436ab8990
Merge pull request #36083 from Avogar/fix-tests
Try to avoid timeoutes in parallel parsing tests
2022-04-12 16:19:42 +02:00
avogar
de9c9462e5 Fix crash in ParallelReadBuffer 2022-04-12 13:54:53 +00:00
tavplubix
c14c9329bb
Merge pull request #36138 from ClickHouse/tavplubix-patch-4
Minor improvement for hung check
2022-04-12 16:54:35 +03:00
tavplubix
090506a572
Merge pull request #36161 from ClickHouse/fix_mongo_test
Fix mongodb test with new cert
2022-04-12 15:48:08 +03:00
Azat Khuzhin
b91281455c clickhouse-client: properly cancel query in case of error during formatting data
One example of such error is NO_ROW_DELIMITER [1]:

    $ clickhouse-client --stacktrace --multiquery <<<"SELECT * FROM no_length_delimiter_protobuf_00825 FORMAT ProtobufSingle SETTINGS format_schema = '$PWD/tests/queries/0_stateless/format_schemas/00825_protobuf_format_no_length_delimiter:Message'"
    Error on processing query: Code: 546. DB::Exception: The ProtobufSingle format can't be used to write multiple rows because this format doesn't have any row delimiter. (NO_ROW_DELIMITER), Stack trace (when copying this message, always include the lines below):

    ...
    3. /build/build_docker/../src/Common/Exception.cpp:56: DB::Exception::Exception()
    4. /build/build_docker/../src/Processors/Formats/Impl/ProtobufRowOutputFormat.cpp:43: DB::ProtobufRowOutputFormat::write()
    5. /build/build_docker/../src/Processors/Formats/IRowOutputFormat.cpp:34: DB::IRowOutputFormat::consume()
    6. /build/build_docker/../src/Processors/Formats/IOutputFormat.cpp:115: DB::IOutputFormat::write()
    7. /build/build_docker/../src/Client/ClientBase.cpp:398: DB::ClientBase::onData()

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35865/b862fa7f3ede7d30b7c606c06e7fe1e273b49d32/stateless_tests__thread__actions__[3/3].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-12 15:22:16 +03:00
alesapin
1b7b6af268
Merge pull request #36157 from bigo-sg/fixut_coo
Fix UT error sometimes
2022-04-12 14:12:24 +02:00
tavplubix
2e95e0db3b
Merge pull request #36133 from Algunenano/osx_atomic_exchange
Add support for atomic exchange in OSX
2022-04-12 14:10:36 +03:00
Kseniia Sumarokova
abb498c9a5
Update ClientBase.cpp 2022-04-12 12:51:19 +02:00
Kseniia Sumarokova
97baa250b6
Merge pull request #36131 from ClickHouse/kssenii-patch-3
Update 01171_mv_select_insert_isolation_long.sh
2022-04-12 11:56:13 +02:00
tavplubix
82713f347b
Update clickhouse-test 2022-04-12 12:55:57 +03:00
alesapin
8f822af358 Fix mongodb test with new cert 2022-04-12 11:47:22 +02:00
Nikolay Degterinsky
3547e3a376
Merge pull request #35978 from nic11/pr/runner-typo
Remove arg duplication and fix a typo
2022-04-12 11:45:52 +02:00
Alexander Tokmakov
6e4787560b fix another issue 2022-04-12 11:44:25 +02:00
tavplubix
ccb45ae943
Update stress 2022-04-12 12:42:45 +03:00
Nikolay Degterinsky
0a382c28e4
Merge pull request #36155 from bharatnc/ncb/fix-typo
fix typo in cmake message
2022-04-12 11:42:20 +02:00