Commit Graph

77230 Commits

Author SHA1 Message Date
kssenii
7c2315638c Remove checks for profile events because they are not updated the same way with async reads 2021-11-13 13:37:00 +03:00
Azat Khuzhin
11be942bb0 Fix possible data-race in case of query cancellation with async_socket_for_remote
RemoteQueryExecutor::cancel() (that is called in another thread), steal
the fiber, and process any pending packets, to leave the connection in
the correct state (so that it can be reused for further queries).

However this requires processing pending packets, and this will update
the RemoteQueryExecutorReadContext::packet field, which can be read in
another thread by the RemoteQueryExecutor::read().

This was pretty tricky due to fibers, but AFAICS I understand this
correctly and this should fix the race.

Note, that if you will look at the logs from the #28854, you will see,
that all those data races was triggered after query cancellation.

Fixes: #28854
Refs: #18715

v2: fix daedlock in case of duplicated parts
v3: do not hold the mutex, since was_cancelled is atomic
2021-11-13 12:44:02 +03:00
Kseniia Sumarokova
c7be79b4e7
Merge pull request #31136 from LiuYangkuan/IDiskRemote_metadata_disk
use DiskPtr instead of OS's file system API in class IDiskRemote
2021-11-13 12:16:05 +03:00
Azat Khuzhin
48b1b7b7ec Fix test_kafka_insert_avro by pinning avro version
New avro version has a code that does not allow to use BytesIO [1].

  [1]: https://github.com/apache/avro/commit/e8c61ba4f0#diff-ca721cc66db80ff81dcd7b8ad1bb0e83b2e5c2de80c207ebec79f5495d38db98R318-R319
2021-11-13 12:01:13 +03:00
alexey-milovidov
f653473083
Merge pull request #31007 from zhanghuajieHIT/master
support compile in arm machine with parameter "-DENABLE_TESTS=OFF"
2021-11-13 01:57:58 +03:00
mergify[bot]
5d0306ed0c
Merge branch 'master' into notlike-fix 2021-11-12 22:35:10 +00:00
alexey-milovidov
e0cf4bf568
Update iotest_nonblock.cpp 2021-11-13 01:31:37 +03:00
alexey-milovidov
558a1257e7
Merge pull request #31279 from RainbowDashy/patch-1
docs: Add descriptions for string aliases
2021-11-13 01:28:07 +03:00
Maksim Kita
38be11a622
Merge pull request #31334 from kitaisreal/bloom-filter-index-check-fix
BloomFilter index check fix
2021-11-13 01:26:08 +03:00
alexey-milovidov
cd42d55d06
Merge pull request #31362 from den-crane/patch-42
Doc. CREATE DICTIONARY / SETTINGS
2021-11-13 01:25:53 +03:00
alexey-milovidov
babf171a1d
Merge pull request #31366 from ClickHouse/remove-pdf
Remove PDF documentation
2021-11-13 01:22:15 +03:00
Kseniia Sumarokova
c6fd56ede9
Update DiskLocal.cpp 2021-11-13 00:00:32 +03:00
alexey-milovidov
f82fd18511
Merge pull request #31348 from depyronick/patch-1
add nestjs-clickhouse library
2021-11-12 23:40:31 +03:00
Alexey Milovidov
4f8646d54b Remove PDF documentation 2021-11-12 23:25:55 +03:00
alesapin
63a4d0b6a2 Debugging broken checks 2021-11-12 22:57:26 +03:00
Yatsishin Ilya
4d0a3ee283 better test_dictionaries_dependency 2021-11-12 22:42:23 +03:00
alexey-milovidov
7c95cfc76a
Merge pull request #31109 from thomoco/master
Updated adopters with Jitsu and Open Targets; minor adopters editing; and added benchmark for Intel Core i5-9600K
2021-11-12 21:37:47 +03:00
mergify[bot]
22e7efa8b0
Merge branch 'master' into add_oss_support 2021-11-12 18:25:26 +00:00
Thom O'Connor
e5a6242759
Merge branch 'ClickHouse:master' into master 2021-11-12 10:46:15 -07:00
Denny Crane
22a32c46bd
Update dictionary.md 2021-11-12 13:00:34 -04:00
Denny Crane
4302b0504e
Update dictionary.md 2021-11-12 12:51:20 -04:00
tavplubix
e8f745da24
Merge pull request #31347 from lavrinenkoe/patch-2
Update http.md
2021-11-12 17:58:37 +03:00
LiuYangkuan
4366fcbc83 fix build check and make rename robust in DiskS3::restoreFileOperations 2021-11-12 22:54:10 +08:00
alesapin
fe44b167d1
Merge pull request #31110 from sevirov/sevirov-DOCSUP-15458-document_the_alter_table_modify_comment
DOCSUP-15458: Document the SQL-statement ALTER TABLE ... MODIFY COMMENT
2021-11-12 16:45:00 +03:00
alesapin
aae000372f Fix build config 2021-11-12 16:43:13 +03:00
tavplubix
26b6412d1f
Update http.md 2021-11-12 16:41:16 +03:00
Ali Demirci
95793d7227
add nestjs-clickhouse library 2021-11-12 16:38:52 +03:00
alesapin
78c44976a4 Fix ci config 2021-11-12 16:34:33 +03:00
Maksim Kita
59c855c038
Merge pull request #31012 from karnevil13/karnevil-DOCSUP-16608
DOCSUP-16608: Documented JSONExtractKeys function
2021-11-12 16:29:43 +03:00
Maksim Kita
42ecb28788
Merge pull request #31082 from sevirov/sevirov-DOCSUP-16607-update_the_sql_statement_create_dictionary
DOCSUP-16607: Update the SQL-statement CREATE DICTIONARY
2021-11-12 16:29:27 +03:00
Evgeny
eee2aab424
Update http.md
<method> tag throws error in config. It seems <methods> should be there
2021-11-12 16:28:36 +03:00
Tomáš Hromada
445b0ba7cc
Expose all GlobalThreadPool config params (#31285) 2021-11-12 16:24:47 +03:00
alesapin
17f2e61cd6 Underscores everywhere 2021-11-12 16:16:17 +03:00
alesapin
43c70c1c36 Fix build check 2021-11-12 16:08:06 +03:00
alesapin
40c323af5f Fix style 2021-11-12 16:01:41 +03:00
alesapin
d139ed5663 Fix 2021-11-12 15:50:56 +03:00
Kruglov Pavel
051a9e7c69
Merge pull request #31249 from vitlibar/fix-show-grants
Fix SHOW GRANTS when partial revokes are used.
2021-11-12 15:49:12 +03:00
alesapin
373fda6eb8 More fixes 2021-11-12 15:36:25 +03:00
tavplubix
8916d3bebf
Merge pull request #31305 from ClickHouse/rename_support_ifexists
Merging #31081
2021-11-12 15:22:43 +03:00
alesapin
2e6da9ea71 Fixes 2021-11-12 15:13:13 +03:00
Anton Popov
7769ed76ce
Merge pull request #31261 from CurtizJ/tuple-element-to-subcolumn
Optimize tupleElement to reading of subcolumn
2021-11-12 15:00:53 +03:00
alesapin
7a62338b0e Remove moar 2021-11-12 14:39:00 +03:00
alesapin
dc9a8f55c5 Add missed config 2021-11-12 14:12:42 +03:00
alesapin
45410b7032 Remove duplicated from CI 2021-11-12 14:11:44 +03:00
kssenii
6f895036e6 Disable for hdfs until tested, adjust tests with profile events 2021-11-12 14:09:19 +03:00
alesapin
9a437980e8 Merge branch 'master' into get_rid_of_build_number 2021-11-12 14:08:09 +03:00
alesapin
c1c1985e36 Get rid of build number 2021-11-12 14:07:54 +03:00
Vitaly Baranov
79a93c819f
Merge pull request #31262 from vitlibar/initial-user-role-row-policy
Initial user's roles are used now to find row policies
2021-11-12 13:51:20 +03:00
alesapin
8d7e500c5d
Merge pull request #31299 from ClickHouse/add_compatibility_check
Add split build check
2021-11-12 13:42:36 +03:00
alesapin
e94b359bca Remove 2021-11-12 12:40:33 +03:00