Commit Graph

112344 Commits

Author SHA1 Message Date
Alexander Tokmakov
851fdf7f46
Update 00002_log_and_exception_messages_formatting.sql 2023-04-06 18:55:36 +03:00
Alexey Milovidov
4ab8b35b00
Merge pull request #48444 from ClickHouse/better-exception-messages-from-keeper-client
Better exception messages from Keeper client
2023-04-06 18:36:39 +03:00
Alexey Milovidov
3066d5df52
Merge pull request #48195 from ClickHouse/disable-compile-aggregations
Remove a feature
2023-04-06 18:09:48 +03:00
Anton Popov
b5a3723c88
Merge pull request #48395 from ClickHouse/with_fill_clarification
WITH FILL clarification and cleanup
2023-04-06 17:02:57 +02:00
Azat Khuzhin
e91c8bfea3 Fix deadlock due to debug tracking of memory allocations
Since memory tracker should be blocked globally (by default it is blocked only
for VariableContext::User).

<details>

<summary>stacktrace</summary>

    * thread 11, name = 'Collector', stop reason = trace
        frame 1: 0x00007ffff7e37ea2 libc.so.6`pthread_mutex_lock + 274
        frame 6: 0x000000001ee10298 clickhouse`toStringCached(pointers=0x00007fffedfef068, offset=0, size=45) + 88 at StackTrace.cpp:425
        frame 7: 0x000000001ee1128e clickhouse`StackTrace::toString(this=0x00007fffedfef058) const + 46 at StackTrace.cpp:444
        frame 8: 0x000000001ede58ff clickhouse`(anonymous namespace)::debugLogBigAllocationWithoutCheck(size=25187648) + 479 at MemoryTracker.cpp:98
        frame 9: 0x000000001ede5481 clickhouse`MemoryTracker::allocImpl(this=0x0000000030729e68, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x00007ffff3c22440) + 3937 at MemoryTracker.cpp:352
        frame 10: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007ffff3c1e530, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x00007ffff3c22440) + 607 at MemoryTracker.cpp:198
        frame 11: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007ffff3c22440, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 607 at MemoryTracker.cpp:198
        frame 12: 0x000000001ede477f clickhouse`MemoryTracker::allocImpl(this=0x00007fffedff3bf0, size=25187648, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 607 at MemoryTracker.cpp:198
        frame 13: 0x000000001ed6c4c9 clickhouse`CurrentMemoryTracker::allocImpl(size=25165824, throw_if_memory_exceeded=false) + 265 at CurrentMemoryTracker.cpp:58
        frame 14: 0x000000001ed6c6a1 clickhouse`CurrentMemoryTracker::allocNoThrow(size=25165824) + 33 at CurrentMemoryTracker.cpp:91
        frame 15: 0x000000001ed63079 clickhouse`operator new(unsigned long) [inlined] void Memory::trackMemory<>(size=25165824) + 89 at memory.h:177
        frame 16: 0x000000001ed63034 clickhouse`operator new(size=25165824) + 20 at new_delete.cpp:74
        ...
        frame 27: 0x000000001ee15895 clickhouse`DB::(anonymous namespace)::collectSymbols(info=0x00007ffff7062000, (null)=<unavailable>, data_ptr=0x00007fffec2b7000) + 53 at SymbolIndex.cpp:483
        frame 28: 0x000000002e1a5d57 clickhouse`::dl_iterate_phdr(callback=(clickhouse`DB::(anonymous namespace)::collectSymbols(dl_phdr_info*, unsigned long, void*) at SymbolIndex.cpp:480), data=0x00007fffec2b7000)(dl_phdr_info *, size_t, void *), void *) + 183 at phdr_cache.cpp:76
        frame 29: 0x000000001ee15549 clickhouse`DB::SymbolIndex::update(this=0x00007fffec2b7000) + 41 at SymbolIndex.cpp:515
        frame 30: 0x000000001ee1be35 clickhouse`DB::SymbolIndex::SymbolIndex(this=<unavailable>) + 53 at SymbolIndex.h:23
        frame 31: 0x000000001ee17a6c clickhouse`DB::SymbolIndex::instanceImpl() + 108 at SymbolIndex.cpp:555
        frame 32: 0x000000001ee17b4a clickhouse`DB::SymbolIndex::instance() + 10 at SymbolIndex.cpp:561
        frame 33: 0x000000001ee1070f clickhouse`void toStringEveryLineImpl<toStringCached(std::__1::array<void*, 45ul> const&, unsigned long, unsigned long)::$_0>(fatal=false, stack_trace=0x00007fffedff1ef8, callback=0x00007fffedff1ee0)::$_0&&) + 207 at StackTrace.cpp:349
        frame 34: 0x000000001ee1040b clickhouse`toStringCached(pointers=0x00007fffedff2928, offset=0, size=43) + 459 at StackTrace.cpp:436
        frame 35: 0x000000001ee1128e clickhouse`StackTrace::toString(this=0x00007fffedff2918) const + 46 at StackTrace.cpp:444
        frame 36: 0x000000001ede58ff clickhouse`(anonymous namespace)::debugLogBigAllocationWithoutCheck(size=25165824) + 479 at MemoryTracker.cpp:98
        frame 37: 0x000000001ede5481 clickhouse`MemoryTracker::allocImpl(this=0x00007fffedff3bf0, size=25165824, throw_if_memory_exceeded=false, query_tracker=0x0000000000000000) + 3937 at MemoryTracker.cpp:352
        frame 38: 0x000000001ed6c4c9 clickhouse`CurrentMemoryTracker::allocImpl(size=25165824, throw_if_memory_exceeded=false) + 265 at CurrentMemoryTracker.cpp:58
        frame 39: 0x000000001ed6c6a1 clickhouse`CurrentMemoryTracker::allocNoThrow(size=25165824) + 33 at CurrentMemoryTracker.cpp:91
        frame 40: 0x000000001ed63079 clickhouse`operator new(unsigned long) [inlined] void Memory::trackMemory<>(size=25165824) + 89 at memory.h:177
        frame 41: 0x000000001ed63034 clickhouse`operator new(size=25165824) + 20 at new_delete.cpp:74
        ...
        frame 55: 0x0000000025badace clickhouse`DB::WriteBufferFromS3::nextImpl(this=0x00007ffff3c58f00) + 366 at WriteBufferFromS3.cpp:110

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-06 16:03:46 +02:00
Rich Raposa
d3d9b21c7b
Merge pull request #48447 from justindeguzman/patch-1
Add why clickhouse-local overview
2023-04-06 07:57:59 -06:00
Sema Checherinda
b8729be97a
Merge pull request #47104 from CheSema/thead-group-for-merge
merge and mutation make thread group for setting memory trackers right
2023-04-06 15:46:56 +02:00
kssenii
2d335f82cc Fix another test 2023-04-06 15:43:16 +02:00
Vitaly Baranov
b45b662fe3
Merge pull request #48431 from Algunenano/system_referential_table
Don't check dependencies when renaming system tables automatically
2023-04-06 15:28:37 +02:00
Nikolai Kochetov
6c6335b686
Merge pull request #48357 from ClickHouse/fix-projections-analysis-with-analyzer
Batch fix for projections analysis with analyzer.
2023-04-06 15:13:56 +02:00
Nikolai Kochetov
54180851ab Fix name 2023-04-06 13:13:17 +00:00
Yakov Olkhovskiy
d2e897d4b8
Merge branch 'master' into imp-use-structure-from-insertion 2023-04-06 08:52:38 -04:00
Vitaly Baranov
1b1fdeddd2
Merge pull request #48297 from murfel/fix-forgotten-showsecrets-in-semi-copy-ctor
Fix: copy forgotten show_secrets in FormatSettings semi-copy-ctor
2023-04-06 14:27:16 +02:00
Nikolai Kochetov
b199219ec1 Add reading step for system zookeeper. Analyze path from filter DAG. 2023-04-06 12:24:22 +00:00
Vitaly Baranov
2fc40834f5
Merge branch 'master' into fix-forgotten-showsecrets-in-semi-copy-ctor 2023-04-06 14:20:57 +02:00
Nikolai Kochetov
e04abef6b3
Merge pull request #48469 from ClickHouse/kssenii-patch-7
Fix possible segfault in cache
2023-04-06 13:56:45 +02:00
avogar
56c5104378 Update tests 2023-04-06 11:43:56 +00:00
Kruglov Pavel
fb33d6bedb
Merge pull request #48126 from Avogar/orc-arrow-parquet-more-types
Support more ClickHouse types in ORC/Arrow/Parquet formats
2023-04-06 13:32:46 +02:00
Kseniia Sumarokova
3fc952a56a
Update CachedOnDiskReadBufferFromFile.cpp 2023-04-06 13:01:24 +02:00
Alexander Tokmakov
005f233848
Merge pull request #48467 from ClickHouse/tavplubix-patch-6
Update 00002_log_and_exception_messages_formatting.sql
2023-04-06 13:50:31 +03:00
Alexander Tokmakov
2cc7d52bdf
Update 00002_log_and_exception_messages_formatting.reference 2023-04-06 13:49:44 +03:00
Alexander Tokmakov
f9fa293421
Update 00002_log_and_exception_messages_formatting.sql 2023-04-06 13:49:03 +03:00
Antonio Andelic
28a33f0a47
Merge pull request #48435 from ClickHouse/kv-update-only-affected-rows
Update only affected rows in KV storage
2023-04-06 12:33:54 +02:00
Vladimir C
e7a5c96353
Merge pull request #48219 from ClickHouse/vdimir/lock_order_47072 2023-04-06 11:54:33 +02:00
Robert Schulze
ef85a54f03
Merge pull request #48463 from ClickHouse/rs/doc-follow-up
Small documentation follow-up to #47246
2023-04-06 11:52:27 +02:00
Robert Schulze
4b7c0f42f4
Small documentation follow-up to #47246 2023-04-06 09:49:58 +00:00
Vladimir C
a2b71a0054
Merge pull request #48386 from ClickHouse/vdimir/reset-downloader-tmp-data-cache 2023-04-06 11:23:16 +02:00
Antonio Andelic
46c6395fa4
Merge pull request #48434 from ClickHouse/dont-replicate-more-keepermap
Don't replicate DELETE and TRUNCATE for KeeperMap
2023-04-06 09:37:43 +02:00
Antonio Andelic
a52fc83e14
Merge branch 'master' into dont-replicate-more-keepermap 2023-04-06 09:35:37 +02:00
Robert Schulze
ce2692ba79
Merge pull request #47246 from ClickHouse/rs/m
Change the behavior of formatter %M in function formatDateTime() from minutes to month name
2023-04-06 09:19:50 +02:00
Yakov Olkhovskiy
8a19ac4e73
Merge branch 'master' into imp-use-structure-from-insertion 2023-04-06 00:51:44 -04:00
Justin de Guzman
22af013184
Add why clickhouse-local overview 2023-04-05 20:49:24 -07:00
Anton Popov
166a63c36c
Merge pull request #46589 from ClickHouse/rs/nonconst-replace
replace[Regexp]{One,All}(): allow non-const pattern and replacement arguments
2023-04-06 03:08:28 +02:00
Alexey Milovidov
785ea8213b Better exception messages from Keeper client 2023-04-06 02:29:37 +02:00
robot-ch-test-poll3
3ad0a6ac18
Merge pull request #48433 from ClickHouse/some-fixes-for-parallel-replicas
Some fixes for parallel replicas
2023-04-06 02:00:06 +02:00
Mikhail f. Shiryaev
14d6373bc7
Merge pull request #48393 from ClickHouse/kerberized-kafka-error
Kerberized kafka error
2023-04-05 23:56:35 +02:00
robot-ch-test-poll1
9466cec1fc
Merge pull request #48342 from ClickHouse/Backup_Restore_concurrency_check_node_2
Check node for Backup Restore concurrency
2023-04-05 23:49:32 +02:00
Alexey Milovidov
32c696e39d
Merge pull request #48400 from ClickHouse/vitlibar-fix-test-backup-all
Fix test_backup_all
2023-04-06 00:48:16 +03:00
Alexey Milovidov
6d9cc3eeed
Merge branch 'master' into vitlibar-fix-test-backup-all 2023-04-06 00:48:06 +03:00
Yakov Olkhovskiy
224f4f92e0 fix test 2023-04-05 21:26:53 +00:00
Alexander Tokmakov
a154fa73f4
Merge pull request #48401 from ClickHouse/fix_00002_log_messages
Find big allocations without memory limits checks
2023-04-05 23:52:39 +03:00
Robert Schulze
65609340cc
Yet another fix 2023-04-05 20:23:41 +00:00
Rich Raposa
7638320fee
Merge pull request #48437 from ClickHouse/style-fix
Update replication.md
2023-04-05 14:14:42 -06:00
robot-ch-test-poll2
bf003c7595
Merge pull request #48390 from Avogar/protobuf-tuple
Allow write/read unnamed tuple as nested Message in Protobuf format
2023-04-05 22:14:28 +02:00
Robert Schulze
3e84be5f3a
Fix stuff 2023-04-05 20:10:27 +00:00
Robert Schulze
809a7fbb7a
Incorporate more review feedback 2023-04-05 19:43:30 +00:00
Nikolay Degterinsky
3b9e8a8630 Override user and password environment variables with client parameters 2023-04-05 19:40:43 +00:00
Sema Checherinda
554c928534
Merge branch 'master' into thead-group-for-merge 2023-04-05 21:09:38 +02:00
Alexander Gololobov
0ebfdbdf69
Merge pull request #48413 from azat/tests/02352_lightweight_delete
Fix possible flakiness of lightweight delete tests (due to index granularity randomization)
2023-04-05 20:58:20 +02:00
Alexander Gololobov
7e1dfbb72e
Merge branch 'master' into tests/02352_lightweight_delete 2023-04-05 20:57:38 +02:00