Commit Graph

93786 Commits

Author SHA1 Message Date
Denny Crane
27326da00b
Update partition.md 2022-07-17 21:12:53 -03:00
Denny Crane
577978026a
Update partition.md 2022-07-17 21:09:01 -03:00
Dmitry Novik
4e9adc5211 Add test 2022-07-17 23:12:37 +00:00
Alexey Milovidov
1cf17a0454
Merge pull request #39302 from ClickHouse/fix-universal-script
Fix universal installation script for FreeBSD
2022-07-18 00:38:24 +03:00
Alexey Milovidov
f1256c3aef
Merge pull request #37891 from guowangy/lz4-decompress-vbmi
LZ4 decompress: add VBMI optimized copyOverlap32Shuffle
2022-07-18 00:37:59 +03:00
Alexey Milovidov
13a8f85ed0
Merge branch 'master' into nullable-partition-fix1 2022-07-18 00:34:58 +03:00
Alexey Milovidov
03aec06da1 Whitespaces 2022-07-17 23:20:05 +02:00
Alexey Milovidov
5f18640215 Fix universal installation script 2022-07-17 23:16:54 +02:00
Robert Schulze
01b40d5a45
Split 00233_position_function_family to avoid test timeouts
+ remove the five most expensive queries
2022-07-17 18:11:37 +00:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
Robert Schulze
fffeab2e86
Merge pull request #39262 from ClickHouse/stringref-by-value
Pass const StringRef by value, not by reference
2022-07-17 16:53:15 +02:00
Azat Khuzhin
d99851bcbe Fix googletest contrib compilation (due to GTEST_HAS_POSIX_RE=0)
By some reason cmake rules for googletest sets GTEST_HAS_POSIX_RE=0
(Compatibilty? But which platform that does support ClickHouse does not
have it?)

But everything will be okay, if these macros was set PUBLIC (i.e. for
compiling googletest library itself and it's users), however it was
added as INTERFACE only (so library itself does not know about
GTEST_HAS_POSIX_RE=0), and this leads to UB, here ASan report (while I
was trying to use ASSERT_EXIT()).

<details>

<summary>ASan report</summary>

    [ RUN      ] Common.LSan
    =================================================================
    ==7566==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030005b2388 at pc 0x00000d00924c bp 0x7ffcd3b7cfb0 sp 0x7ffcd3b7c770
    WRITE of size 64 at 0x6030005b2388 thread T0
        0 0xd00924b in regcomp (/bld/src/unit_tests_dbms+0xd00924b) (BuildId: 40d3fa83125f9047)
        1 0x29ca243b in testing::internal::RE::Init(char const*) /bld/./contrib/googletest/googletest/src/gtest-port.cc:750:15
        2 0xd4d92b3 in testing::internal::RE::RE(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) /bld/./contrib/googletest/googletest/include/gtest/internal/gtest-port.h:896:36
        3 0xd4d92b3 in testing::PolymorphicMatcher<testing::internal::MatchesRegexMatcher> testing::ContainsRegex<char const*>(char const* const&) /bld/./contrib/googletest/googletest/include/gtest/gtest-matchers.h:868:28
        4 0xd4d813a in testing::internal::MakeDeathTestMatcher(char const*) /bld/./contrib/googletest/googletest/include/gtest/internal/gtest-death-test-internal.h:173:10
        5 0xd4d813a in Common_LSan_Test::TestBody() /bld/./src/Common/tests/gtest_lsan.cpp:11:5

    0x6030005b2388 is located 0 bytes to the right of 24-byte region [0x6030005b2370,0x6030005b2388)
    allocated by thread T0 here:
        0 0xd066fbd in operator new(unsigned long) (/bld/src/unit_tests_dbms+0xd066fbd) (BuildId: 40d3fa83125f9047)
        1 0xd4d913d in testing::PolymorphicMatcher<testing::internal::MatchesRegexMatcher> testing::ContainsRegex<char const*>(char const* const&) /bld/./contrib/googletest/googletest/include/gtest/gtest-matchers.h:868:24
        2 0xd4d813a in testing::internal::MakeDeathTestMatcher(char const*) /bld/./contrib/googletest/googletest/include/gtest/internal/gtest-death-test-internal.h:173:10
        3 0xd4d813a in Common_LSan_Test::TestBody() /bld/./src/Common/tests/gtest_lsan.cpp:11:5

</details>
2022-07-17 17:24:02 +03:00
Jordi Villar
d86abba2c6 Fix macosx compilation due to endian.h 2022-07-17 14:58:27 +02:00
Mikhail f. Shiryaev
9cc06ea0e4
Fix found points during the review 2022-07-17 14:05:21 +02:00
zvonand
91be72dbb4 updated 2022-07-17 12:17:16 +02:00
Kseniia Sumarokova
4b11a718cb
Update fetchPostgreSQLTableStructure.cpp 2022-07-17 11:55:34 +02:00
Azat Khuzhin
30018ce5d3 Fix running cmake with predefined cache (for development only)
Right now cmake add the following options only if USE_STATIC_LIBRARIES
is OFF:
- SPLIT_SHARED_LIBRARIES
- CLICKHOUSE_SPLIT_BINARY

And this breaks the following usage:

    $ cmake ..
    $ cat > debug-build-cache.cmake
    set(USE_STATIC_LIBRARIES              OFF CACHE BOOL "")
    set(SPLIT_SHARED_LIBRARIES            ON  CACHE BOOL "")
    set(CLICKHOUSE_SPLIT_BINARY           ON  CACHE BOOL "")
    ^D
    $ cmake -C debug-build-cache.cmake ..
    CMake Error at CMakeLists.txt:83 (message):
      Defining SPLIT_SHARED_LIBRARIES=1 without USE_STATIC_LIBRARIES=0 has no
      effect.

Since with this initial cache we have the following:

- USE_STATIC_LIBRARIES=OFF (because it was already set)
- SPLIT_SHARED_LIBRARIES=ON (was not set before, so new value)
- CLICKHOUSE_SPLIT_BINARY (was not set before, also new value)

Yes this is not the common usage, but it seems that it is pretty easy to
avoid.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-17 12:18:24 +03:00
Wangyang Guo
c07c65615d fix ENABLE_MULTITARGET_CODE not defined warning in some builds 2022-07-17 12:21:10 +08:00
Vitaly Baranov
e0fb03d1b6
Merge pull request #38970 from vitlibar/select-from-system-db-requires-grant
SELECT from the system database requires grant now
2022-07-16 22:37:47 +02:00
Anton Popov
b0333f463e
Merge pull request #39288 from ClickHouse/kssenii-patch-4
Fix clang tidy
2022-07-16 20:16:35 +02:00
zvonand
9ac7e41e07 updated docs 2022-07-16 19:45:33 +02:00
zvonand
283b598000 fix unused changes 2022-07-16 19:29:57 +02:00
zvonand
3089da16be fix identation 2022-07-16 19:07:42 +02:00
zvonand
d07a652883 merge 2022-07-16 19:05:07 +02:00
zvonand
4ab52b6873 added new DataType + fixes 2022-07-16 18:58:47 +02:00
Kseniia Sumarokova
3f43641b18
Update MergedColumnOnlyOutputStream.cpp 2022-07-16 16:32:33 +02:00
Wangyang Guo
7ef3f56066 lz4 decompress: coding style fix 2022-07-16 22:10:16 +08:00
Mikhail f. Shiryaev
533c788803
Merge pull request #39281 from azat/fix-builder
Fix builder image for releases w/o diagnostics tool
2022-07-16 15:59:37 +02:00
Alexey Milovidov
e37caa5bd6
Merge pull request #39216 from Algunenano/rotational_error
Don't report system.errors when the disk is not rotational
2022-07-16 16:16:52 +03:00
alesapin
afd5c40335
Merge pull request #39190 from ClickHouse/fix_race_with_concurrent_hardlinks
Fix extremely rare race condition in hardlinks creation
2022-07-16 13:57:02 +02:00
Azat Khuzhin
accb0e38da Remove superior atomic from MergeTreeBackgroundExecutor and annotations for TSA
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-16 14:00:39 +03:00
kssenii
9bba55110c Fix 2022-07-16 12:44:47 +02:00
Azat Khuzhin
1ef9910453 Fix builder image for releases w/o diagnostics tool
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-16 12:07:58 +03:00
Sergei Trifonov
82f98cfe6b remove initial linear growth, increase avg period to 3 sec 2022-07-16 02:17:18 +02:00
Igor Nikonov
ef0ef9e03b
Merge pull request #39191 from ClickHouse/sort_transform_cleanup
Cleanup: done during #38719 (SortingStep: deduce way to sort based on input stream sort)
2022-07-16 01:53:58 +02:00
Sergei Trifonov
8a5286ea4c fix cpu usage metric in client 2022-07-16 00:27:26 +02:00
Ilya Yatsishin
43ed3df474
Merge pull request #39225 from qoega/query-log-fix-result-bytes 2022-07-15 23:46:03 +02:00
jinjunzh
dbac3a35b2 fixed cosmetic issues 2022-07-15 17:23:37 -04:00
jinjunzh
f05f3cb69a fixed cosmetic issues 2022-07-15 17:04:27 -04:00
jinjunzh
e3735f7464 fixed cosmetic issues 2022-07-15 16:12:26 -04:00
jinjunzh
5104e4200a fixed cosmetic issues 2022-07-15 15:32:10 -04:00
Kruglov Pavel
559d507f5a
Merge branch 'master' into compatibility-setting 2022-07-15 21:11:05 +02:00
jinjunzh
d3d0605c00 add words of caution into documentation 2022-07-15 14:33:51 -04:00
Alexander Tokmakov
4fd92ad2e7
Merge pull request #39276 from ClickHouse/tavplubix-patch-1
Another supression for BC check
2022-07-15 21:02:45 +03:00
Alexander Tokmakov
b770f9903d
Update run.sh 2022-07-15 20:03:00 +03:00
alesapin
ec15be2798 Add missed file 2022-07-15 19:00:50 +02:00
Kruglov Pavel
3436fcfda6
Update tests/performance/low_cardinality_argument.xml
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2022-07-15 18:24:44 +02:00
avogar
7508448275 Better 2022-07-15 16:23:56 +00:00
kssenii
9f1d6814fc Fix 2022-07-15 18:01:54 +02:00
alesapin
39d61e9a37
Merge pull request #39064 from quickhouse/patch-1
More stable `test_s3_zero_copy_ttl`, weakened requirement to move data to S3 in 0-5 seconds
2022-07-15 17:58:58 +02:00