Commit Graph

22505 Commits

Author SHA1 Message Date
Nikolai Kochetov
3f8cc216a8 Update memory limit for external aggregation test. 2019-11-06 19:50:19 +03:00
Mikhail Korotov
317af908fd Merge branch 'master' into decimal_hex_function 2019-11-06 18:20:05 +03:00
Mikhail Korotov
ed7971ea25 Fixed small bug 2019-11-06 18:15:24 +03:00
Mikhail Korotov
26f1cc6494 Merge branch 'decimal_hex_function' of https://github.com/millb/ClickHouse into decimal_hex_function 2019-11-06 18:07:01 +03:00
millb
254c94ebfa Fixed bugs 2019-11-06 18:06:15 +03:00
philip.han
16ea323fff Removed undefined behavior of signed integer overflow. 2019-11-07 00:00:59 +09:00
Mikhail Korotov
4326a35cc4 Merge branch 'decimal_hex_function' of https://github.com/millb/ClickHouse into decimal_hex_function 2019-11-06 17:49:30 +03:00
millb
7d46d359ea Working commit 2019-11-06 17:48:23 +03:00
philip.han
300062e91a Fixed type conversions in javaHashUTF16LE 2019-11-06 23:17:38 +09:00
Mikhail Korotov
29747b5511 Merge branch 'decimal_hex_function' of https://github.com/millb/ClickHouse into decimal_hex_function 2019-11-06 16:11:27 +03:00
millb
7863b7f3c9 Working commit 2019-11-06 16:08:02 +03:00
Alexey Milovidov
3f0476b522 Disabled "trap" function back 2019-11-06 15:36:56 +03:00
Nikolai Kochetov
3bde663681 Wailt for AsynchronousBlockInputStream inner thread before getting totals to avoid possible race. 2019-11-06 15:34:51 +03:00
Nikolai Kochetov
ec8f160859 Wailt for AsynchronousBlockInputStream inner thread before getting totals to avoid possible race. 2019-11-06 15:26:51 +03:00
Azat Khuzhin
81aeff2d2a Add _shard_num virtual column for the Distributed engine
With JOIN from system.clusters one can figure out from which server data
came.

TODO:
- optimization to avoid communicating with unrelated shards (for queries
  like "AND _shard_num = n")
- fix aliases (see tests with serverError expected)

v0: AddingConstColumnBlockInputStream
v2: VirtualColumnUtils::rewriteEntityInAst
v3: fix remote(Distributed) by appending _shard_num only if has been requested
2019-11-06 15:26:12 +03:00
Vasily Nemkov
9c62209978 Added missing support of formatDateTime() for DateTime64 2019-11-06 15:01:39 +03:00
millb
4f6197c370 Working commit 2019-11-06 14:48:17 +03:00
Nikolai Kochetov
a34023192d Fix limits for pipe. 2019-11-06 14:36:33 +03:00
alexey-milovidov
a120fba929
Update FunctionsHashing.h 2019-11-06 14:20:31 +03:00
Alexey Milovidov
83c63171ad Added another mode for function "trap" #7601 2019-11-06 14:17:12 +03:00
Alexander Kuzmenkov
233212ac68
Merge pull request #7531 from amosbird/getkeymapped
Unify hash tables interface (separated for review)
2019-11-06 13:49:39 +03:00
philip.han
68a82f78b4 Implemented javaHashUTF16LE() 2019-11-06 19:46:37 +09:00
sundy-li
76b75dc0e8 args to supertype 2019-11-06 18:19:08 +08:00
Nikolai Kochetov
86a9c2b98e Try to fix tests. 2019-11-06 12:45:47 +03:00
Mikhail Korotov
281b0062bc
Working commit 2019-11-06 11:48:51 +03:00
Mikhail Korotov
556f6fbdc5
Working commit 2019-11-06 11:47:25 +03:00
millb
043ca0d470 Working commit 2019-11-06 11:42:34 +03:00
millb
9308ea5d33 Merge branch 'decimal_hex_function' of github.com:millb/ClickHouse into decimal_hex_function 2019-11-06 11:29:43 +03:00
millb
695f3c58cc Working Commmit 2019-11-06 11:29:18 +03:00
alexey-milovidov
33edb0929b
Merge pull request #7641 from 4ertus2/joins
Support RIGHT | FULL JOIN with expressions in ON section
2019-11-06 11:17:52 +03:00
Mikhail Korotov
0168620fad
Fixed style commit 2019-11-06 11:17:31 +03:00
alexey-milovidov
78f7826a09
Update InterpreterSelectQuery.cpp 2019-11-06 11:17:26 +03:00
millb
0226ba406c Functions tryExecuteFloat and tryExecuteDecimal are combined 2019-11-06 10:42:10 +03:00
millb
5c478dfe02 Merge branch 'master' into decimal_hex_function 2019-11-06 09:43:30 +03:00
Vladimir Chebotarev
9446edb42a
Fixed bug with keep_free_space_ratio not being read from disks configuration. 2019-11-06 07:59:35 +03:00
alexey-milovidov
687be5f7af
Merge pull request #7618 from excitoon-favorites/looks-like-wrong-copy-paste
Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages
2019-11-06 02:11:38 +03:00
alexey-milovidov
678d88ed45
Merge pull request #7640 from nvartolomei/nv/docs-on-cluster-alter-replicated-variant-b
Remove note about unsupported ON CLUSTER alter for replicated tables and enable tests
2019-11-06 02:08:55 +03:00
chertus
950e95c178 support JOIN ON expression 2019-11-05 23:22:20 +03:00
alexey-milovidov
56c89349d3
Merge pull request #7639 from CurtizJ/final_mark_without_primary_key
Fix final mark with empty primary key.
2019-11-05 22:53:52 +03:00
Alexey Milovidov
9ac4e4c7fb Little better #7600 2019-11-05 22:31:07 +03:00
alexey-milovidov
1bfade54c2
Merge pull request #7600 from azat/DirectoryMonitor-current_batch.txt-corruption
Write current batch for distributed send atomically (using .tmp + rename)
2019-11-05 22:24:15 +03:00
Nicolae Vartolomei
ffa69441ae Remove duplication between distributed_ddl and distributed_ddl_secure tests 2019-11-05 19:06:52 +00:00
alexey-milovidov
8fc84e93ff
Merge pull request #7635 from ClickHouse/fix_concat_return_data_type
Now concat always return string column
2019-11-05 21:39:48 +03:00
alexey-milovidov
40a8216294
Merge pull request #7625 from ClickHouse/array-compact-improve
Improvement of arrayCompact function.
2019-11-05 21:39:06 +03:00
alexey-milovidov
eb6add45ea
Merge pull request #7626 from ClickHouse/char-test-utf8
Added a test for function "char" that proves that it's applicable for non-ASCII.
2019-11-05 21:38:37 +03:00
Alexey Milovidov
c6ac30e450 Added another test case by Sundy-Li request 2019-11-05 21:38:16 +03:00
CurtizJ
c958662c6e add test for empty primaty key 2019-11-05 21:21:49 +03:00
CurtizJ
3d968b0259 fix final mark with empty primary key 2019-11-05 20:42:35 +03:00
Nikolai Kochetov
055f21c9b7 Less wrappers for procesors pipeline. 2019-11-05 20:33:03 +03:00
Amos Bird
fbfbe161ec
Unify hash tables interface. 2019-11-06 00:08:04 +08:00
alexey-milovidov
a44d08bea9
Merge pull request #7634 from ClickHouse/aku/macros-verbose-error
More verbose error message in macros.
2019-11-05 19:02:34 +03:00
Vladimir Chebotarev
7b93641a10
Fixed comment in configuration. 2019-11-05 18:08:37 +03:00
Alexander Kuzmenkov
36a9ac86b8 More verbose error message in macros. 2019-11-05 17:02:38 +03:00
Vasily Nemkov
e924ae6d15 Better parsing of DateTime64
Fractional part is optional, correctly scaling fractional part to match
the scale.
2019-11-05 16:41:15 +03:00
Vasily Nemkov
5150a3e586 Simplified and renamed basic DateTime64 test. 2019-11-05 16:40:23 +03:00
alesapin
2d7ae27232 Now concat always return string column 2019-11-05 16:23:09 +03:00
Nikolai Kochetov
a0e9f9fdcf Skip empty totals in SourceFromInputStream. 2019-11-05 15:50:47 +03:00
Nicolae Vartolomei
d9d73fe783 Simplify integration test for distributed alter 2019-11-05 12:29:30 +00:00
Vasily Nemkov
61ad74bc58 Fixed parsing DateTime and/or DateTime64 with parseXXXOrNull 2019-11-05 14:59:46 +03:00
Nikolai Kochetov
abccddb6b9 Check number of rows in OneBlockInputStream. 2019-11-05 12:26:23 +03:00
Vasily Nemkov
9d3c819897 Fixed compilation of unit-tests and utility binaries
By removing extern template declarations for Decimal<T> and explicit instantiations in Types.cpp
2019-11-05 12:02:27 +03:00
sundy-li
71ec49cc2f add range performance tests 2019-11-05 15:07:25 +08:00
alexey-milovidov
6a871f579f
Merge pull request #7598 from infinivision/bitmap_replace
added bitmapTransform
2019-11-05 02:23:50 +03:00
alexey-milovidov
2fe5f23025
Update FunctionsBitmap.h 2019-11-05 02:21:22 +03:00
alexey-milovidov
0c1510d3e3
Update FunctionsBitmap.h 2019-11-05 02:20:16 +03:00
alexey-milovidov
f9d14f78c0
Update FunctionsBitmap.h 2019-11-05 02:09:28 +03:00
alexey-milovidov
3ee7de2d52
Merge pull request #7620 from millb/integration_test_for_part_log_table
Integration test for part_log table
2019-11-05 02:05:33 +03:00
alexey-milovidov
c081c8aacb
Update AggregateFunctionGroupBitmapData.h 2019-11-05 01:59:02 +03:00
Alexey Milovidov
4f83b56c14 Added another test case 2019-11-05 01:47:46 +03:00
Vladimir Chebotarev
8556b2cee3 Added tests to check that ClickHouse don't crash on insufficient arguments of S3, URL and HDFS storages. 2019-11-05 01:47:26 +03:00
Alexey Milovidov
0a3b7068fd Added a test for function "char" 2019-11-05 01:45:51 +03:00
alexey-milovidov
7d2a16ee39
Merge pull request #7486 from sundy-li/char_function
functions: add char function
2019-11-05 01:40:18 +03:00
Alexey Milovidov
92824e14e7 Added a test 2019-11-05 01:18:59 +03:00
Alexey Milovidov
979db8c965 Improve "arrayCompact" function 2019-11-05 01:13:10 +03:00
alexey-milovidov
fbed472018
Update 00076_ip_coding_functions.sql 2019-11-05 00:53:35 +03:00
Azat Khuzhin
4dfffdd24a Write current batch for distributed send atomically (using .tmp + rename)
Otherwise the following can happen after reboot:

    2019.11.01 11:46:12.217143 [ 187 ] {} <Error> dist.Distributed.DirectoryMonitor: Code: 27, e.displayText() = DB::Exception: Cannot parse input: expected \n before: S\'^A\0^]\0\0<BE>4^A\0r<87>\0\0<A2><D7>^D^Y\0<F2>{^E<CD>\0\0Hy\0\0<F2>^_^C\0^_&\0\0<FF><D3>\0\0
    <8D><91>\0\0<C0>9\0\0<C0><B0>^A\0^G<AA>\0\0<B5><FE>^A\0<BF><A7>^A\0<9B><CB>^A\0I^R^A\0<B7><AB>^A\0<BC><8F>\0\0˲^B\0Zy\0\0<94><AA>\0\0<98>
    <8F>\0\0\f<A5>\0\0^QN\0\0<E3><C6>\0\0<B1>6^B\0ɳ\0\0W<99>\0\0<B9><A2>\0\0:<BB>\0\0)<B1>\0\0#<8B>\0\0aW\0\0<ED>#\0\0<F1>@\0\0ˀ^B\0<D7><FC>\0\0<DF>, Stack trace:

    0. 0x559e27222e60 StackTrace::StackTrace() /usr/bin/clickhouse
    1. 0x559e27222c45 DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) /usr/bin/clickhouse
    2. 0x559e26de4473 ? /usr/bin/clickhouse
    3. 0x559e272494b5 DB::assertString(char const*, DB::ReadBuffer&) /usr/bin/clickhouse
    4. 0x559e2a5dab45 DB::StorageDistributedDirectoryMonitor::processFilesWithBatching(std::map<unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&) /usr/bin/clickhouse
    5. 0x559e2a5db5fa DB::StorageDistributedDirectoryMonitor::processFiles() /usr/bin/clickhouse
    6. 0x559e2a5dba78 DB::StorageDistributedDirectoryMonitor::run() /usr/bin/clickhouse
    7. 0x559e2a5ddbbc ThreadFromGlobalPool::ThreadFromGlobalPool<void (DB::StorageDistributedDirectoryMonitor::*)(), DB::StorageDistributedDirectoryMonitor*>(void (DB::StorageDistributedDirectoryMonitor::*&&)(), DB::StorageDistributedDirectoryMonitor*&&)::{lambda()#1}::operator()() const /usr/bin/clickhouse
    8. 0x559e2726b07c ThreadPoolImpl<std::thread>::worker(std::_List_iterator<std::thread>) /usr/bin/clickhouse
    9. 0x559e2bbc3640 ? /usr/bin/clickhouse
    10. 0x7fbd62b3cfb7 start_thread /lib/x86_64-linux-gnu/libpthread-2.29.so
    11. 0x7fbd62a692ef __clone /lib/x86_64-linux-gnu/libc-2.29.so
     (version 19.17.1.1)

v2: remove fsync, to avoid possible stalls (https://github.com/ClickHouse/ClickHouse/pull/7600#discussion_r342010874)
2019-11-05 00:24:38 +03:00
alexey-milovidov
5aceca9e17
Merge pull request #7615 from amosbird/fix21
Global context should be unique.
2019-11-05 00:16:37 +03:00
Mikhail Korotov
0781065bd8 improved changes 2019-11-04 22:10:02 +03:00
Nicolae Vartolomei
ac6472b03f Try and enable test_replicated_alters 2019-11-04 17:15:28 +00:00
Mikhail Korotov
dd99468e7b Created integration test for part_log table 2019-11-04 20:13:49 +03:00
Vladimir Chebotarev
9869ee141c Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages. 2019-11-04 20:11:50 +03:00
Amos Bird
e2cfc3ecab
Global context should be unique. 2019-11-04 23:43:13 +08:00
Vasily Nemkov
c6eb0fcff7 Merge remote-tracking branch 'upstream/master' into DateTime64 2019-11-04 17:06:22 +03:00
Vasily Nemkov
1237976021 Minor: style fix and removed debug output. 2019-11-04 14:54:17 +03:00
alexey-milovidov
81e33ca817
Merge pull request #7586 from 4ertus2/joins
Rewrite NonJoinedBlockInputStream
2019-11-04 14:49:47 +03:00
alexey-milovidov
b261e6033a
Merge pull request #7602 from excitoon-favorites/cloneAndLoadDataPartOnSameDisk
Made `MergeTreeData::cloneAndLoadDataPart` only work for the same disk.
2019-11-04 14:42:30 +03:00
alexey-milovidov
1354d1079a
Merge pull request #7605 from zhang2014/fix/is_local_show
fix cluster system is_local
2019-11-04 14:35:37 +03:00
alexey-milovidov
782e2f6c13
Merge pull request #7606 from amosbird/nullformat
Better Null format for tcp handler.
2019-11-04 14:27:27 +03:00
Zhichang Yu
da2d05802c added bitmapTransform 2019-11-04 14:55:31 +08:00
Amos Bird
8f902dc2a9
Better null format for tcp handler. 2019-11-04 11:53:26 +08:00
zhang2014
08894484ee fix cluster system is_local 2019-11-04 10:56:12 +08:00
alexey-milovidov
a8d6843723
Merge pull request #7599 from azat/__getScalar-fix
Check column for __getScalar() (avoids assertion)
2019-11-04 02:28:42 +03:00
Vladimir Chebotarev
e76bbfc5ad Made MergeTreeData::cloneAndLoadDataPart only work for the same disk. 2019-11-04 01:27:05 +03:00
Azat Khuzhin
920572915e Add regression test for the __getScalar() 2019-11-04 00:31:10 +03:00
alexey-milovidov
d9c02b652f
Merge pull request #7594 from amosbird/fix20
early constant folding improvement
2019-11-04 00:30:16 +03:00
chertus
b7b664845d return right x in RIGHT|FULL JOIN .. USING(x) from NonJoinedBlockInputStream if not qualified 2019-11-03 23:30:49 +03:00
chertus
d4e1468022 fix Join.saved_block_sample columns' nullability 2019-11-03 22:33:59 +03:00
Azat Khuzhin
842f4e2ca0 Check column for __getScalar() (avoids assertion)
Can be triggered using the following query:
  CREATE TABLE foo (key String, macro String MATERIALIZED __getScalar(key)) Engine=Null();

Trace:
    3. 0x00007ffff6d5d526 __assert_fail (libc.so.6)
    4. 0x00007ffff41fd931 boost::intrusive_ptr<DB::IColumn const>::operator*() const (libclickhouse_functionsd.so)
    5. 0x00007ffff41fcd64 COW<DB::IColumn>::IntrusivePtr<DB::IColumn const>::operator*() const & (libclickhouse_functionsd.so)
    6. 0x00007ffff4dc5944 DB::FunctionGetScalar::getReturnTypeImpl() const (libclickhouse_functionsd.so)

(Even though it is internal I guess it is better to fix it)

Refs: #7392
Cc: @amosbird
2019-11-03 21:44:56 +03:00
Amos Bird
f0b3c1f7c7
early constant folding improvement 2019-11-03 21:17:46 +08:00
Vasily Nemkov
98235e9202 Fixed now64 2019-11-03 08:42:48 +03:00