Commit Graph

57753 Commits

Author SHA1 Message Date
alexey-milovidov
71acb2ffda
Merge pull request #20475 from ClickHouse/intdiv-ubsan-2
Fix UBSan report in intDiv
2021-02-15 04:05:16 +03:00
Alexander Tokmakov
320fd6b264 startup without zk 2021-02-15 03:04:46 +03:00
alexey-milovidov
bde4da0ff0
Merge pull request #20465 from azat/write-abnormal-server-termination-fixes
Fix abnormal server terminations due to write failures
2021-02-15 00:05:48 +03:00
Alexey Milovidov
459ea4132d Merge branch 'master' into in-memory-compression 2021-02-15 00:00:47 +03:00
Alexey Milovidov
96dc69609c Fix Arcadia 2021-02-15 00:00:18 +03:00
Alexey Milovidov
d529db5498 Adjustments 2021-02-14 23:57:25 +03:00
alexey-milovidov
8be8746643
Merge pull request #20461 from azat/join_use_nulls-logical-error-fix
Fix LOGICAL_ERROR for join_use_nulls=1 when JOIN contains const from SELECT
2021-02-14 23:28:50 +03:00
Alexey Milovidov
f409a6d4a7 Fix build 2021-02-14 19:00:47 +03:00
Alexey Milovidov
3bba2cc8b7 Merge branch 'master' into improve-performance-group-by-multiple-fixed-keys 2021-02-14 19:00:04 +03:00
Daria Mozhaeva
00bb72735e add text 2021-02-14 15:55:40 +03:00
Daria Mozhaeva
c68f0477c6 Merge branch 'dmozhaeva-DOCSUP-2042-edit-and-translate' of https://github.com/damozhaeva/ClickHouse into dmozhaeva-DOCSUP-2042-edit-and-translate 2021-02-14 14:50:50 +03:00
Daria Mozhaeva
7f9436381f fixed conflict 2021-02-14 14:48:26 +03:00
tavplubix
89f2cf52f3
Update skip_list.json 2021-02-14 14:24:54 +03:00
Daria Mozhaeva
bc7663f757 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into dmozhaeva-DOCSUP-2042-edit-and-translate 2021-02-14 14:23:46 +03:00
damozhaeva
48d38e4978
Update docs/ru/operations/settings/settings.md
Co-authored-by: Ilya Yatsishin <2159081+qoega@users.noreply.github.com>
2021-02-14 14:19:26 +03:00
robot-clickhouse
37807e1a18 Update version_date.tsv after release 20.12.6.29 2021-02-14 11:51:46 +03:00
robot-clickhouse
09a5b7a055 Update version_date.tsv after release 21.1.4.46 2021-02-14 11:35:34 +03:00
robot-clickhouse
607b57ea28 Update version_date.tsv after release 21.2.3.15 2021-02-14 10:57:52 +03:00
alesapin
17dce00136 Temporary disable 00992_system_parts_race_condition_zookeeper 2021-02-14 10:45:52 +03:00
Amos Bird
ed49367fc7
Fix global-with with subqueries 2021-02-14 14:20:23 +08:00
Alexey Milovidov
55c17ac93f Fix UBSan report in intDiv 2021-02-14 06:11:12 +03:00
alexey-milovidov
d39398baa6
Merge pull request #20468 from ClickHouse/speedup-memory
Performance improvement of StorageMemory by Nikolai Kochetov
2021-02-14 06:07:04 +03:00
Alexey Milovidov
b13d1f3142 Fix integration test 2021-02-14 04:34:42 +03:00
Alexey Milovidov
ddb2cbcf6d Merge branch 'master' into in-memory-compression 2021-02-14 04:32:41 +03:00
alexey-milovidov
9db6f4a452
Merge pull request #20466 from azat/mt-logging
Improve logging during reading from MergeTree
2021-02-14 04:30:31 +03:00
alexey-milovidov
6359d21dbf
Merge pull request #20474 from holadepo/patch-1
Minor link fix in delete-old-data.md
2021-02-14 04:28:45 +03:00
alexey-milovidov
a0fbc0656b
Merge pull request #20206 from ClickHouse/tavplubix-patch-3
Suppress signed overflow in AggregateFunctionGroupArrayMoving
2021-02-14 03:32:16 +03:00
Habibullah Oladepo
320ce101e1
Minor link fix in delete-old-data.md
Minor link fix in delete-old-data.md
2021-02-14 00:26:10 +01:00
alexey-milovidov
36421bae67
Merge pull request #20473 from ramazanpolat/patch-1
Added the RENAME COLUMN statement
2021-02-14 02:23:08 +03:00
Ramazan Polat
9b319af965
Added the RENAME COLUMN statement 2021-02-14 02:09:34 +03:00
Alexey Milovidov
5bdc570046 Improve performance of GROUP BY multiple fixed size keys 2021-02-14 01:56:04 +03:00
Alexander Tokmakov
b0f2a84306 fix bad test 2021-02-14 01:12:10 +03:00
Alexander Tokmakov
96cc01926c Merge branch 'master' into better_ddl_queue_cleanup 2021-02-14 00:22:09 +03:00
Alexander Tokmakov
652ede5af9 add test 2021-02-14 00:06:40 +03:00
Alexey Milovidov
179a0f9d8b Performance improvement by Nikolai Kochetov 2021-02-13 22:51:38 +03:00
Azat Khuzhin
790c210e51 Mark 01508_partition_pruning as long
https://clickhouse-test-reports.s3.yandex.net/20466/ff647ad176ad32718fcfc87677effa0ab37e3f10/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-13 20:33:03 +03:00
alexey-milovidov
024d8491d6
Merge pull request #20454 from ClickHouse/aggregation-common-non-significant-change
Non significant change in AggregationCommon
2021-02-13 19:36:33 +03:00
alexey-milovidov
3e9f1dc83b
Merge pull request #20458 from ClickHouse/array-difference-ubsan
Fix UBSan report in arrayDifference
2021-02-13 19:34:44 +03:00
Azat Khuzhin
ff647ad176 Update 01508_partition_pruning expectations 2021-02-13 18:08:55 +03:00
Azat Khuzhin
68f23b7087 Improve logging during MergeTree reading
- Remove "Not using primary index on part {}" message (too noisy)
- Add number of total marks before filtering by primary key into the
  common message
- Make "Index {} has dropped {} / {} granules." not per-part, but
  per-query
2021-02-13 18:08:55 +03:00
Amos Bird
a551edd8d6
Do not parse view function in expression 2021-02-13 22:12:44 +08:00
Vladimir
3f7128d8e7
Merge pull request #20085 from gyuton/gyuton-DOCSUP-6295-Update_isIPv4String-andisIPv6String-functions 2021-02-13 17:10:39 +03:00
Amos Bird
69d4120982
Disable table function view in expression 2021-02-13 21:39:37 +08:00
Azat Khuzhin
33f54cdb3c Fix abnormal server termination when http client goes away
In [1] stress tests found:

    2021.02.12 14:20:58.800988 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Debug> executeQuery: (from [::1]:45792, using production parser) (comment: /usr/share/clickhouse-test/queries/0_stateless/01520_client_print_query_id.expect) SELECT * FROM numbers(34599)
    2021.02.12 14:20:58.916484 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Trace> ContextAccess (default): Access granted: CREATE TEMPORARY TABLE ON *.*
    2021.02.12 14:20:59.071980 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Trace> InterpreterSelectQuery: FetchColumns -> Complete
    2021.02.12 14:21:10.708202 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Information> executeQuery: Read 34599 rows, 270.30 KiB in 11.876294055 sec., 2913 rows/sec., 22.76 KiB/sec.
    2021.02.12 14:22:10.506261 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Debug> DynamicQueryHandler: Done processing query
    2021.02.12 14:22:18.238037 [ 375 ] {} <Fatal> BaseDaemon: (version 21.3.1.5996, build id: 8DBCED54529C989F7AD4D991F51410774D55DE6C) (from thread 17728) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 262994, Stack trace (when copying this message, always include the lines below):

    0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x15c976cb in /usr/bin/clickhouse
    1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:56: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x8c9320e in /usr/bin/clickhouse
    2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x8d54da5 in /usr/bin/clickhouse
    3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x8d551d7 in /usr/bin/clickhouse
    4. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:44: DB::Write

    2021.02.12 14:22:18.811071 [ 18134 ] {} <Fatal> BaseDaemon: ########################################
    2021.02.12 14:22:18.878935 [ 18134 ] {} <Fatal> BaseDaemon: (version 21.3.1.5996, build id: 8DBCED54529C989F7AD4D991F51410774D55DE6C) (from thread 17728) (query_id: de3e7894-b401-4f7d-8530-90cd5ab06682) Received signal Aborted (6)
    2021.02.12 14:22:18.943148 [ 18134 ] {} <Fatal> BaseDaemon:
    2021.02.12 14:22:19.007073 [ 18134 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f109932018b 0x7f10992ff859 0x8bb33ae 0x8e301dd 0x17dac8c4 0x17dac7c7 0x8c3fe0b 0x8d552c5 0x8d552ea 0x11a29914 0x11a2a2ca 0x12f96092 0x12f8c65e 0x12f84300 0x15b84110 0x15bc0913 0x15bc103f 0x15d29a12 0x15d27fb0 0x15d267b8 0x8badbad 0x7f10994d5609 0x7f10993fc293
    2021.02.12 14:22:19.255998 [ 18134 ] {} <Fatal> BaseDaemon: 5. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.02.12 14:22:19.270203 [ 18134 ] {} <Fatal> BaseDaemon: 6. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.02.12 14:22:50.108918 [ 370 ] {} <Fatal> Application: Child process was terminated by signal 6.

  [1]: https://clickhouse-test-reports.s3.yandex.net/19580/6aecb62416ece880cbb8ee3a803e14d841388dde/stress_test_(thread).html#fail1

Verified locally by commenting out->next() call in
WriteBufferFromHTTPServerResponse::nextImpl(), adding a sleep(1) and
canceling HTTP request before it finished, the stacktrace as follow:

    [ 6351 ] {} <Fatal> BaseDaemon: (version 21.3.1.1, build id: 9B40466BF3D2F5AED78A52A995A4A2FD3116787C) (from thread 6677) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 4, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/.cmake/../src/Common/StackTrace.cpp:298: StackTrace::tryCapture() @ 0x30a52a in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    1. /src/ch/clickhouse/.cmake/../src/Common/StackTrace.cpp:260: StackTrace::StackTrace() @ 0x30a4e5 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    2. /src/ch/clickhouse/.cmake/../src/Common/Exception.cpp:53: DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, bool) @ 0x2a61ae in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    3. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:22: DB::WriteBufferFromOStream::nextImpl() @ 0x3b468a in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    4. /src/ch/clickhouse/.cmake/../src/IO/WriteBuffer.h:47

    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 7. __cxxabiv1::__terminate(void (*)()) @ 0x1784ca in /src/ch/clickhouse/.cmake/contrib/replxx-cmake/libreplxxd.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 10. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x3b48c1 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    [ 8966 ] {} <Fatal> BaseDaemon: 11. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:44: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x3b48ec in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 14. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromHTTPServerResponse.cpp:218: DB::WriteBufferFromHTTPServerResponse::~WriteBufferFromHTTPServerResponse() @ 0x3b33cd in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 22. /src/ch/clickhouse/.cmake/../src/Server/HTTPHandler.h:43: DB::HTTPHandler::Output::~Output() @ 0x260421 in /src/ch/clickhouse/.cmake/src/libclickhouse_serverd.so
    [ 8966 ] {} <Fatal> BaseDaemon: 23. /src/ch/clickhouse/.cmake/../src/Server/HTTPHandler.cpp:778: DB::HTTPHandler::handleRequest(Poco::Net::HTTPServerRequest&, Poco::Net::HTTPServerResponse&) @ 0x253fd4 in /src/ch/clickhouse/.cmake/src/libclickhouse_serverd.so
2021-02-13 13:23:03 +03:00
Azat Khuzhin
592f62d0af Remove superfluous out->next() call in HTTPHandler 2021-02-13 13:22:37 +03:00
Azat Khuzhin
06e8065ee6 Add missing sync of underlying files 2021-02-13 13:19:51 +03:00
Azat Khuzhin
fa329808e5 Call next() from sync()/finalize() in WriteBuffer 2021-02-13 13:14:11 +03:00
Ilya Yatsishin
8ff458a2bf
Merge pull request #20459 from ClickHouse/decimal-comparison-ubsan 2021-02-13 12:34:40 +03:00
Ilya Yatsishin
5e6ee87096
Merge pull request #20453 from ClickHouse/catch-traps 2021-02-13 12:33:20 +03:00
Azat Khuzhin
4aa46ce3d6 More tests for join_use_nulls
All of them already works, but just in case
2021-02-13 11:05:25 +03:00