Commit Graph

86 Commits

Author SHA1 Message Date
Nikolai Kochetov
07b29453cc Update weak hash. 2020-03-24 14:29:55 +03:00
Nikolai Kochetov
1d94b8bfbd Merge branch 'master' into weak-hash 2020-03-23 19:22:46 +03:00
alexey-milovidov
c7863e1ac6
Clang Tidy, part 7 (#9799)
* Attempt to enable identifier naming check

* Attempt to enable identifier naming check, continue

* Progress on identifier names

* Adopt identifier names check

* Fixed error

* Merge with master

* Fixed build

* Fixed build

* Fixed build

* Fixed build

* Fixed build

* Fixed error

* Fixed error

* Fixed error
2020-03-23 05:12:31 +03:00
Nikolai Kochetov
46f63c1dd8 Fix weakHash 2020-03-20 20:31:05 +03:00
Nikolai Kochetov
e6f518154b Fix build. 2020-03-18 19:46:07 +03:00
Nikolai Kochetov
e26eac4649 Implement updateWeakHash32 for other columns. 2020-03-18 19:03:55 +03:00
Alexey Milovidov
6320f59abb clang-tidy, part 11 2020-03-09 04:03:43 +03:00
Alexey Milovidov
79c6bd5ae7 clang-tidy, part 4 2020-03-09 00:40:00 +03:00
Alexey Milovidov
8966520801 Added "assert_cast" function as a replacement for static_cast for columns 2019-08-21 05:28:04 +03:00
Nikolai Kochetov
ced2721ce8 Fix deserializeAndInsertFromArena. (#5973) 2019-07-15 19:20:21 +03:00
alexey-milovidov
254369324b
Miscellanous changes in ColumnArray (#4857)
* Miscellanous

* Miscellanous

* Miscellanous
2019-03-30 13:46:17 +03:00
Alexey Milovidov
f86abeb8df Fixed comments 2019-03-29 18:06:35 +03:00
Alexey Milovidov
fb19cf1eec Attempt to make compositions with COWPtr more convenient 2019-03-25 04:43:54 +03:00
alexey-milovidov
6db73152d2
Hardening debug build (experimental) (#4632)
* Hardening debug build: more granular memory mappings and ASLR; add memory protection for mark cache and index

* Addition to prev. revision

* Addition to prev. revision

* Addition to prev. revision
2019-03-10 06:16:51 +03:00
proller
aad2856eba CLICKHOUSE-4179 : arrayEnumerateDenseRanked arrayEnumerateUniqRanked (#4475)
* Build fixes (clang 7.0.0+)

* better

* wip

* wip

* fix

* fix

* wip

* fix

* clean

* clean

* CLICKHOUSE-4179 WIP

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

*    wip

* wip

* wip

* wip

* wip

* cf

*    wip

* wip

* wip

* wip

* cf

* wip

* wip# Please enter the commit message for your changes. Lines starting

* wip# Please enter the commit message for your changes. Lines starting

* cf

* wip# Please enter the commit message for your changes. Lines starting

* wip

* cf

* wip

* wip

* clean

* clean

* clean

* clean

* wip

* wip

* wip

* cf

* wip

* wip

* wip

* cf

* clean

* wip

* clean

* cf

* clean

* clean

* test

* clean

* wip

* cf

* wip

* clean

* clean

* wip

* wip

* clean

* cf

* clean

* Requested changes

* cf

* no convertToFullColumnIfConst

* clean

* clean

* clean

* fix

* Remove comment
2019-02-28 01:18:58 +03:00
Vitaly Baranov
4b6cba9a8e IColumn::getPermutation() and IColumn::permutate() functions, "limit" parameter: change type UInt64 -> size_t. 2019-02-19 14:56:09 +03:00
Vitaly Baranov
833aa9189b IColumn::index() function, "limit" parameter: change type UInt64 -> size_t. 2019-02-19 14:47:41 +03:00
Alexey Milovidov
c603d270f4 Cleanups #4246 2019-02-10 18:17:45 +03:00
Alexey Milovidov
3874dc5ac3 Fixed error in #3920 2019-01-08 17:56:07 +03:00
Alexey Milovidov
56bd082105 Fixed UB #3926 2018-12-26 06:15:34 +03:00
Amos Bird
8736a3908f left pad 2018-12-24 23:51:06 +08:00
Alexey Milovidov
19d57c78b5 Fixed test #3909 2018-12-23 04:46:30 +03:00
Alexey Milovidov
a8f09809f5 Simplified logic with "IColumn::convertToFullColumnIfConst" (suggested by Amos Bird) [#CLICKHOUSE-2] 2018-12-21 19:00:07 +03:00
Alexey Milovidov
21c3a3d9e2 UBSan fixes #3021 2018-12-14 20:50:10 +03:00
Alexey Milovidov
c77930fe30 Whitespaces [#CLICKHOUSE-2] 2018-11-26 03:56:50 +03:00
Alexey Milovidov
141e9799e4 Fixed error with "extractURLParameter" function (read after buffer); improved performance; added support for zero bytes in URLs; renamed Chars_t type [#CLICKHOUSE-2] 2018-11-25 03:08:50 +03:00
Alexey Milovidov
f93ede0182 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:33:15 +03:00
Alexey Milovidov
bf443fcfa0 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:30:55 +03:00
Alexey Milovidov
ab78bc1b5c Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:13:15 +03:00
Alexey Milovidov
66afebc498 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:40:15 +03:00
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
Nikolai Kochetov
f56d16769b Added pre and post serialization for IDataType BinaryBulkWithMultipleStreams. Supported dictionary serialization format with single global dictionary (limited wit max_dictionary_size) and additional keys which are stored per granule. Changed IDataType::enumerateStream interface. Added (de)serialization params for binary bulk with multiple stream (de)serialization. Changed IColumn::index interface. 2018-06-26 17:12:21 +03:00
Nikolai Kochetov
8470a091bb added IColumn::select 2018-04-23 19:59:11 +03:00
Nikolai Kochetov
4aaf56d9a2 added IColumn::select 2018-04-23 19:55:26 +03:00
Nikolai Kochetov
2119469c51 added IColumn::select 2018-04-19 00:00:47 +03:00
Nikolai Kochetov
cc2c1f5171 removed createImmutable 2018-03-23 22:24:55 +03:00
Nikolai Kochetov
476d4b339c Immutable construction for columns 2018-03-20 22:45:10 +03:00
Alexey Milovidov
c897e5ca39 Better [#CLICKHOUSE-2] 2018-03-03 18:36:20 +03:00
Alexey Milovidov
15b5c27c1c Fixed error [#CLICKHOUSE-2] 2018-01-14 04:25:35 +03:00
Alexey Milovidov
d497d010d7 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-17 08:21:04 +03:00
Alexey Milovidov
7284a64740 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-16 00:32:25 +03:00
Alexey Milovidov
8ce60e3af0 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:53:11 +03:00
Alexey Milovidov
0b76b61c73 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:46:24 +03:00
Alexey Milovidov
9c9896c1a9 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:17:15 +03:00
Alexey Milovidov
401fd2d6d8 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 05:36:40 +03:00
Alexey Milovidov
fb38ef9a8e Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-14 06:56:56 +03:00