Robert Schulze
777b5bc15b
Don't let storages inherit from boost::noncopyable
...
... IStorage has deleted copy ctor / assignment already
2022-05-03 09:07:08 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
kssenii
4374415bd7
Fix clang-tidy, style check
2022-03-29 14:20:21 +02:00
kssenii
a2013ebe2b
Better
2022-03-28 22:40:27 +02:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Anton Popov
c1fdcf7a64
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-01 20:21:39 +03:00
kssenii
092ec45b47
Merge master
2022-03-01 12:06:56 +01:00
kssenii
9b64a8fe39
Fix odbc bridge
2022-02-28 14:29:05 +01:00
Hongbin
c9bc442114
fix comments
2022-02-28 16:44:35 +08:00
Hongbin
99bd56e2de
Fix some code comments style
2022-02-28 08:15:37 +08:00
Anton Popov
836a348a9c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-01 15:23:07 +03:00
alesapin
1adc7538fe
Fix benign race condition for storage HDFS, S3, URL
2022-01-31 13:50:28 +03:00
Anton Popov
78b9f15abb
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-30 03:24:37 +03:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
avogar
4efadfad3c
Fix tests
2022-01-18 22:26:13 +03:00
avogar
97788b9c21
Allow to create new files on insert for File/S3/HDFS engines
2021-12-29 21:19:13 +03:00
avogar
8112a71233
Implement schema inference for most input formats
2021-12-29 12:18:56 +03:00
kssenii
1f6ca619b7
Allow some killing
2021-12-27 22:42:56 +03:00
Alexey Milovidov
f03cb4c762
Cleanup trash from Kafka and HDFS
2021-12-25 06:10:59 +03:00
Nikita Mikhaylov
d9c13900f5
Fix build + style
2021-12-20 14:31:56 +00:00
Zhichang Yu
869cdbeb44
added table function hdfsCluster
2021-12-20 13:14:44 +00:00
Anton Popov
99ebabd822
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-17 19:02:29 +03:00
taiyang-li
9d1e63be0f
1. support default expression for storage hdfs; 2. optimize storage hdfs when format is column oriented
2021-12-06 11:54:45 +08:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
Kseniia Sumarokova
065106c299
Merge pull request #30690 from kssenii/partitioned-write
...
Partitioned write for file, hdfs, url storages and table functions
2021-11-02 22:58:16 +03:00
Alexey Milovidov
8b4a6a2416
Remove cruft
2021-10-28 02:10:39 +03:00
kssenii
20772fde04
For storage
2021-10-27 10:04:17 +03:00
kssenii
1d743b9259
Partitoned write
2021-10-25 19:23:44 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Nikolai Kochetov
9c92f43359
Update storages.
2021-07-23 22:33:59 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
kssenii
ac0f86cdbf
Truncate for s3
2021-06-21 15:44:36 +00:00
kssenii
4688f9e038
hdfs truncate table
2021-06-21 13:59:57 +00:00
Maksim Kita
67e9b85951
Merge ext into common
2021-06-16 23:28:41 +03:00
Maksim Kita
30c78c0a23
Fix arcadia
2021-06-11 14:26:33 +03:00
feng lv
0f5c05854c
fix conflict
2021-04-23 12:22:51 +00:00
feng lv
4ffe199d39
Implement table comments
2021-04-23 12:18:23 +00:00
kssenii
da7a4ac1ea
Better
2021-04-20 07:53:55 +00:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Ilya Golshtein
7e97814859
cleanup, fixes, new submodules, ShellCommand, WriteBufferFromString
2020-12-16 14:48:33 +03:00
