Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Alexander Tokmakov
9e05b12d2c
Merge branch 'master' into mvcc_prototype
2022-03-20 22:42:26 +01:00
Alexander Tokmakov
07d952b728
use snapshots for semistructured data, durability fixes
2022-03-17 18:26:18 +01:00
kssenii
a2cd165d38
Add remote host filter
2022-03-17 11:48:42 +01:00
Anton Popov
99ebabd822
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-17 19:02:29 +03:00
kssenii
89db2c57f4
Fix
2021-12-12 00:19:06 +03:00
Anton Popov
6f4d9a53b2
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-12-01 15:54:33 +03:00
kssenii
2ea4e7c4e7
Better
2021-11-29 15:05:02 +00:00
kssenii
2f0fe4a21f
Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into rabbit-kafka-select-commit
2021-11-29 10:08:14 +00:00
Raúl Marín
91bf938075
Reduce dependencies on ASTLiteral.h
...
590 -> 537
2021-11-26 17:54:57 +01:00
kssenii
980c87c466
Add named collection for kafka / rabbit
2021-11-24 14:53:01 +03:00
Anton Popov
ccd78e3838
Merge remote-tracking branch 'upstream/master' into HEAD
2021-11-22 17:19:35 +03:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
kssenii
fdaca4d8be
Better
2021-11-06 19:12:32 +00:00
kssenii
35a4be601a
Select query commit only with settings
2021-11-03 15:43:58 +03:00
kssenii
285742dcba
Fix tests
2021-11-03 11:57:33 +03:00
kssenii
b899dd9af5
Better
2021-11-02 22:47:27 +03:00
kssenii
f662c1829d
Fix
2021-11-02 18:08:10 +03:00
Nikolai Kochetov
ab28c6c855
Remove BlockInputStream interfaces.
2021-10-14 13:25:43 +03:00
Nikolai Kochetov
2957971ee3
Remove some last streams.
2021-10-13 21:22:02 +03:00
Nikolai Kochetov
78e1db209f
Remove more data streams ( #29491 )
...
* Remove more streams.
* Fixing build.
* Fixing build.
* Rename files.
* Fix fast test.
* Fix StorageKafka.
* Try fix kafka test.
* Move createBuffer to KafkaSource ctor.
* Revert "Move createBuffer to KafkaSource ctor."
This reverts commit 81fa94d27e
.
* Revert "Try fix kafka test."
This reverts commit 2107e54969
.
* Comment some rows in test.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-10-07 11:26:08 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Nikolai Kochetov
9d3e8fb9c3
Tiny fix.
2021-09-24 13:41:52 +03:00
Nikolai Kochetov
cc53ba283d
Try fix other tests.
2021-09-24 13:23:28 +03:00
Nikolai Kochetov
a8c3b02598
Merge branch 'master' into rewrite-pushing-to-views
2021-09-17 15:38:11 +03:00
Kseniia Sumarokova
e9d44d0848
Merge pull request #28797 from kssenii/rabbit-fix
...
Rewrite StorageRabbitMQ a little
2021-09-16 23:58:51 +03:00
kssenii
7b068317c1
Fix build
2021-09-16 13:55:18 +00:00
kssenii
432ca1ed93
Fix tests
2021-09-16 10:46:43 +00:00
Nikolai Kochetov
e616732743
Small refactoring.
2021-09-15 22:35:48 +03:00
Kseniia Sumarokova
fbc048b2bf
Merge branch 'master' into rabbit-fix
2021-09-15 12:11:57 +03:00
Anton Popov
fc17936c12
Merge remote-tracking branch 'upstream/master' into HEAD
2021-09-14 23:02:30 +03:00
Nikolai Kochetov
0e267c50b4
Merge branch 'master' into rewrite-pushing-to-views
2021-09-14 16:13:54 +03:00
kssenii
0978c8baab
Fix tests
2021-09-12 16:55:37 +03:00
Vitaly Baranov
51dbedafd9
Expand macros in RabbitMQ settings.
2021-09-12 16:42:03 +03:00
kssenii
453bd27c0a
Review fixes
2021-09-11 20:40:18 +03:00
kssenii
f26f64993a
Rewrite StorageRabbitMQ a bit
2021-09-10 13:35:24 +03:00
Nikolai Kochetov
f569a3e3f7
Merge branch 'master' into rewrite-pushing-to-views
2021-09-09 20:30:23 +03:00
kssenii
24010689e6
Fix possible throw from shutdown
2021-09-09 15:08:18 +03:00
Anton Popov
4c388e3d84
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-09-09 14:10:16 +03:00
Anton Popov
59128412ea
Merge remote-tracking branch 'upstream/master' into HEAD
2021-09-03 22:17:11 +03:00
Nikolai Kochetov
66a76ab70f
Rewrite PushingToViewsBlockOutputStream part 6
2021-09-03 20:29:36 +03:00
Kseniia Sumarokova
09c9dd489b
Update StorageRabbitMQ.cpp
2021-09-01 13:28:34 +03:00
kssenii
335b6f12fd
Fix
2021-08-30 20:59:03 +03:00
Anton Popov
6d3274c22c
Merge remote-tracking branch 'upstream/master' into HEAD
2021-08-26 03:31:46 +03:00
Vitaly Baranov
ff1fad8521
Use setSetting() with implicit conversion true/false -> Field.
2021-08-23 08:57:00 +03:00
Anton Popov
3a0d4807a5
Merge branch 'async-insert' of git://github.com/abyss7/ClickHouse into merging-20557
2021-08-06 16:20:02 +03:00
Anton Popov
e36736b50c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-02 22:52:02 +03:00
Nikolai Kochetov
61d8f880cd
Rename some files.
2021-07-26 19:48:25 +03:00
Nikolai Kochetov
2dc5c89b66
Update Storage::write
2021-07-23 17:25:35 +03:00