Robert Schulze
a1c131c0da
Query Cache: Try to fix bad cast from ColumnConst to ColumnVector<char8_t>
...
Resolves #49445
The query cache buffers query result chunks and eventually squashes
them before insertion into the cache. Here, squashing failed because not
all chunks were of the same type. Looks like chunks of the same
underlying type (e.g. UInt8) in a query result be of mixed const, sparse
or low-cardinality type. Fix this by always materializing the data
regardless of the compression. Strange thing is that the failing query
in the stress test (*) isn't able to reproduce the bug, and I haven't
managed to trigger the issue otherwise, so no test case is added.
(*) SELECT 1 UNION ALL SELECT 1 INTERSECT SELECT 1
E.g. here: https://s3.amazonaws.com/clickhouse-test-reports/0/18817517ed6f8849e3d979e10fbb273e0edf0eaa/stress_test__debug_/fatal_messages.txt
2023-06-22 11:46:22 +00:00
kssenii
8ff8125ebd
Better
2023-06-22 13:25:47 +02:00
kssenii
4fbf52f2de
Less loggers
2023-06-22 13:08:53 +02:00
Alexander Tokmakov
6929a9b852
Update WriteBufferFromOStream.cpp
2023-06-22 14:01:28 +03:00
Sema Checherinda
95349a405b
release buffers with exception context
2023-06-22 13:00:13 +02:00
kssenii
df7c291bd3
Merge remote-tracking branch 'origin/delete-non-evictable-feature' into delete-non-evictable-feature
2023-06-22 12:55:20 +02:00
kssenii
b3ce64caa5
Fix tests
2023-06-22 12:55:05 +02:00
Kseniia Sumarokova
b7ef782335
Merge pull request #51242 from kssenii/fix-possible-incorrect-elements-limit
...
Fix sometimes incorrect current_elements count in fs cache
2023-06-22 12:51:43 +02:00
Igor Nikonov
9d9c9ccaff
Merge pull request #51259 from ClickHouse/cache-eviction-improve-hot-path
...
FileCache: tryReserve() slight improvement
2023-06-22 12:41:01 +02:00
Anton Kozlov
0c440b9d6f
Report loading status for executable dictionaries correctly
2023-06-22 10:28:13 +00:00
San
6288a17708
Merge pull request #50920 from ClickHouse/update_contrib_ocr_module
...
Update contribe/orc in .gitmodules
2023-06-22 19:11:48 +10:00
Robert Schulze
b5d7c200c1
Merge pull request #51249 from rschu1ze/conf-docs
...
Docs: little cleanup of configuration-files.md
2023-06-22 11:09:04 +02:00
Robert Schulze
c1c1758861
Merge branch 'master' into conf-docs
2023-06-22 10:41:22 +02:00
santrancisco
f0dcefa0e1
Fixing git submodule back to our own fork as this pull https://github.com/apache/orc/pull/1542 is now merged into apache/orc repository
2023-06-22 18:00:39 +10:00
Mikhail f. Shiryaev
02776b8a15
Merge pull request #51163 from ClickHouse/fasttest-ignore-chown-fail
...
Ignore errors for `chown` in fasttests
2023-06-22 09:51:57 +02:00
Alexander Gololobov
a604a1de0b
Merge pull request #51238 from ClickHouse/zookeeper_fail_on_get_api_version_error
...
Drop session if we fail to get Keeper API version
2023-06-22 08:06:50 +02:00
LiuNeng
bcdf5f37ee
Merge branch 'master' into fix_core_dump_when_compile_expression
2023-06-22 12:13:55 +08:00
Michael Kolupaev
c96a3a8b15
Unforget to pass callback to readBigAt() in ParallelReadBuffer
2023-06-21 17:14:19 -07:00
Alexey Milovidov
a050b9e9d9
Update FileCache.cpp
2023-06-22 01:28:52 +03:00
Mikhail f. Shiryaev
1591633d72
Merge pull request #49283 from ClickHouse/runners-survival
...
Attempt to increase the general runners' survival rate
2023-06-22 00:16:11 +02:00
Igor Nikonov
e3b43c2b88
Move instead of copy
2023-06-21 21:54:44 +00:00
Igor Nikonov
ad0677147f
Trying slightly improve eviction path
...
+ less copying of shared pointers
+ less indirection in overflow check
2023-06-21 21:48:58 +00:00
Dan Roscigno
c856c4a7df
Merge branch 'master' into Docs/ip_addresses
2023-06-21 17:26:27 -04:00
Sema Checherinda
23120c4467
fix build
2023-06-21 22:32:33 +02:00
Sema Checherinda
679f2c4aa4
Merge branch 'master' into memory-leak
2023-06-21 22:22:11 +02:00
Alexander Gololobov
333483bdce
Merge pull request #49181 from ClickHouse/get_rid_of_delete_on_destroy_marker
...
Deprecate delete-on-destroy.txt
2023-06-21 22:20:57 +02:00
Sema Checherinda
c2fa7a1030
Merge branch 'master' into memory-leak
2023-06-21 21:15:01 +02:00
Sema Checherinda
01de36f1fa
Merge pull request #50395 from CheSema/better-log
...
require `finalize()` call before d-tor for all writes buffers
2023-06-21 21:12:02 +02:00
Alexander Tokmakov
50ee424148
do not update digest during recovery
2023-06-21 21:07:59 +02:00
kssenii
78ea4feca0
Merge remote-tracking branch 'upstream/master' into delete-non-evictable-feature
2023-06-21 20:52:08 +02:00
Alexander Tokmakov
9240a82c64
Update DatabaseReplicated.cpp
2023-06-21 21:49:00 +03:00
kssenii
9aa4647f4f
Delete feature
2023-06-21 20:48:12 +02:00
Sergei Trifonov
99c6bdca24
Merge branch 'master' into fix-flaky-asyncloader-stop
2023-06-21 20:43:42 +02:00
Robert Schulze
57070a6a6e
Ignore "modularization"
2023-06-21 18:18:08 +00:00
Kseniia Sumarokova
45d7f39566
Merge pull request #51222 from ClickHouse/kssenii-patch-7
...
Disable cache setting do_not_evict_index_and_mark_files
2023-06-21 20:17:33 +02:00
Anton Popov
022b85ba0b
Merge pull request #51164 from CurtizJ/better-check-part-with-cache
...
Better checking of data parts on disks with filesystem cache
2023-06-21 20:08:53 +02:00
kssenii
38466169c7
Better
2023-06-21 20:07:45 +02:00
Alexey Milovidov
c54433a1ac
Merge pull request #51131 from ClickHouse/nickitat-patch-11
...
Small fix in `MergeTreePrefetchedReadPool`
2023-06-21 20:31:49 +03:00
Alexey Milovidov
f0d93d5b60
Merge pull request #51199 from ClickHouse/empty_array_get_name
...
Avoid initializing DateLUT from emptyArray function registration
2023-06-21 20:29:28 +03:00
Dan Roscigno
adfe469a15
Merge pull request #51246 from DanRoscigno/fix-settings-nav
...
fix server settings nav
2023-06-21 13:25:33 -04:00
Alexey Milovidov
e87b9ee846
Update AsyncLoader.cpp
2023-06-21 20:25:10 +03:00
DanRoscigno
c14930bc19
bad path
2023-06-21 13:12:09 -04:00
Robert Schulze
fb47eea283
Docs: little cleanup of configuration-files.md
...
I tried to understand in what ways ClickHouse's configuration can be set
up. Unfortunately, the official documentation is quite lacking and
sometimes self-contradictory. After reading some 3rd party guides and
StackOverflow answers, I tried to clean it up a little bit but there is
more work to be done.
2023-06-21 16:49:45 +00:00
kssenii
3ce17fd570
Fix log message
2023-06-21 18:30:46 +02:00
kssenii
509a50f651
Merge remote-tracking branch 'origin/fix-possible-incorrect-elements-limit' into fix-possible-incorrect-elements-limit
2023-06-21 18:29:16 +02:00
kssenii
b007c9f194
Review comments
2023-06-21 18:28:14 +02:00
Dmitry Novik
bb97332599
Merge pull request #50441 from Algunenano/parallel_replicas_analyzer
...
Support parallel replicas with the analyzer
2023-06-21 17:28:06 +02:00
Kseniia Sumarokova
d18da7098a
Update LRUFileCachePriority.cpp
2023-06-21 17:25:09 +02:00
Dan Roscigno
da693c3c32
Merge branch 'master' into fix-settings-nav
2023-06-21 11:22:17 -04:00
DanRoscigno
804466f129
fix server settings nav
2023-06-21 11:20:17 -04:00