Commit Graph

17965 Commits

Author SHA1 Message Date
Constantin S. Pan
cbc0f56af1 Mark all input columns in LIMIT BY as required output
The query analyzer only marks the actual arguments of LIMIT BY as required
output for the LimitBy step in the pipeline. This is fine, unless the query is
distributed, in which case the first stage might remove a column that is used
at the second stage (e.g. for ORDER BY) but is not part of the final select.

Prevent removal of any columns in LimitBy by marking all input columns as
required output.
2019-05-24 09:53:09 +01:00
stavrolia
14ac3de76b Add limit to loop test 2019-05-24 11:38:49 +03:00
alexey-milovidov
f54b01fad8
Merge pull request #5393 from abyss7/fix-blockio
Fix order of destruction inside BlockIO
2019-05-23 21:49:40 +03:00
proller
3bb18d1dc2 Merge remote-tracking branch 'upstream/master' into fix15 2019-05-23 21:38:38 +03:00
stavrolia
17a6e9cffa Loop type of tests 2019-05-23 19:06:21 +03:00
chertus
333c9aeecc support IN in CrossToInnerJoin push down 2019-05-23 19:01:17 +03:00
stavrolia
3a1d3b0025 Try type of test - once 2019-05-23 18:31:23 +03:00
alesapin
15e31d5a8c
Merge pull request #5392 from yandex/insert_data_to_null_columns
Add ability to insert data in column nullable
2019-05-23 17:38:01 +03:00
Clément Rodriguez
c4c99c80a1 Make the connection closure parameterized in dictionary.xml 2019-05-23 15:55:00 +02:00
Ivan Lezhankin
646d6f3fb5 Fix order of destruction 2019-05-23 16:54:11 +03:00
alesapin
d860b3912b Insert data in column nullable 2019-05-23 16:35:26 +03:00
Clément Rodriguez
7b40d37212 Close MySQL connections after usage in MySQLDictionarySource 2019-05-23 15:09:07 +02:00
Nikolai Kochetov
54a52853e8 Remane regression methods. 2019-05-23 14:51:25 +03:00
stavrolia
e9425fdfeb Merge branch 'apply-substitutions-for-create-prepare-drop-query' of https://github.com/yandex/ClickHouse into apply-substitutions-for-create-prepare-drop-query 2019-05-23 13:38:48 +03:00
stavrolia
eb3340dba2 add test with selecting of different formats 2019-05-23 13:37:19 +03:00
alesapin
3425610f79
Update parse_engine_file.xml 2019-05-23 11:45:47 +03:00
stavrolia
a1719b101e Fix name of test 2019-05-22 18:34:16 +03:00
stavrolia
dcd5a80843 Remove not used methods 2019-05-22 17:00:32 +03:00
stavrolia
c398db29d4 Fix style 2019-05-22 14:36:31 +03:00
stavrolia
3469f80172 add config file for test of parsing files in different formats 2019-05-22 14:09:44 +03:00
proller
d6a90b6079
Build fixes (#5368) 2019-05-22 13:16:16 +03:00
alesapin
36cf6fa8f9
Merge pull request #5360 from filimonov/integration_tests_runner_improvements
more fixes for integration tests dockerfiles
2019-05-22 11:58:02 +03:00
sundy-li
ad539464b0 add empty judge 2019-05-22 14:11:27 +08:00
proller
6cb4485473
Rename aggregate functions TSgroup* to timeSeriesGroup* (#5307) 2019-05-21 18:33:54 +03:00
Alexander Kuzmenkov
6472040c6c Initialize StoragesInfo fields. 2019-05-21 16:58:55 +03:00
Ivan Lezhankin
28bddf9a4a [StorageMerge] check that underlying tables support sampling 2019-05-21 16:04:34 +03:00
stavrolia
281a01f5f7 Add ability to make substitutions in create, fill and drop query. 2019-05-21 15:57:19 +03:00
Alexander Kuzmenkov
43655a8db7 Add system.detached_parts table.
https://github.com/yandex/ClickHouse/issues/5164
2019-05-21 15:06:36 +03:00
alesapin
a08fee57b7
Merge pull request #5356 from comunodi/fix_test_without_zk
Fix replication_without_zookeeper test
2019-05-21 13:40:24 +03:00
alesapin
3340ae66ba More stable perf tests 2019-05-21 13:03:36 +03:00
alesapin
91907d2450 Add more information about stages in 00926 test 2019-05-21 13:00:02 +03:00
Oleg Favstov
fe74521710 Use pytest's raises instead of try/except clause 2019-05-21 11:30:39 +03:00
hcz
ba527dac20
Update AggregateFunctionStatisticsSimple.h 2019-05-21 16:17:12 +08:00
alesapin
09ad1732b3
Update test.py 2019-05-21 11:15:47 +03:00
hcz
f7bad8c87b
Fix NaN 2019-05-21 16:10:49 +08:00
Mikhail Filimonov
8a1d773ced more dockerfile fixes 2019-05-21 08:17:46 +02:00
Danila Kutenin
3536184ba8
Merge pull request #5357 from yandex/concat_optimization
Optimize concat function with recent format function.
2019-05-21 08:11:35 +03:00
Guillaume Tassery
938d6d7f24 coding style 2019-05-21 11:06:36 +07:00
Guillaume Tassery
d94ce121e2 update test 2019-05-21 10:53:53 +07:00
Andy Yang
a62f7e2fea Fixed bitmap functions produce wrong result 2019-05-21 10:58:38 +08:00
sundy-li
afcd60a0a4 add NO_SANITIZE_UNDEFINED 2019-05-21 10:16:46 +08:00
sundy-li
b55bf7cf83 whitespaces 2019-05-21 09:56:48 +08:00
alexey-milovidov
418a86f338
Merge pull request #5355 from yandex/checksum-mismatch-more-verbose-error-message
Better error message on checksum mismatch #5347
2019-05-21 01:46:52 +03:00
Danila Kutenin
cf014b704a Check for number of arguments 2019-05-21 00:12:25 +03:00
Danila Kutenin
daaebf5ab0 optimized concat function with format, make format a bit more generic 2019-05-21 00:06:43 +03:00
Oleg Favstov
896e995fe8 Fix test that doesn't assert anything 2019-05-20 23:59:07 +03:00
Alexey Milovidov
4b604e4656 Better error message on checksum mismatch #5347 2019-05-20 23:46:52 +03:00
Alexey Milovidov
da142a5d5d Better error message on checksum mismatch #5347 2019-05-20 23:35:43 +03:00
alexey-milovidov
1b86f28f08
Merge pull request #5350 from 4ertus2/bugs
Fix decimal conversion in IN
2019-05-20 22:01:56 +03:00
proller
50b74deeb4 CLICKHOUSE-4509 Fix error codes in DataPartsExchange 2019-05-20 20:04:36 +03:00
chertus
187311add0 add decimal to decimal convertion in IN 2019-05-20 18:51:54 +03:00
Guillaume Tassery
6fada68fe5 forget client.cpp 2019-05-20 20:24:53 +07:00
Guillaume Tassery
77b7158cd8 Progress rename for total_rows and write_[rows|bytes] 2019-05-20 18:37:41 +07:00
Mikhail Filimonov
8fe7633b62 Fixing "the input device is not a TTY" for test runner 2019-05-20 11:48:36 +02:00
Mikhail Filimonov
464cff4665 Sereval improvements in integration tests runner 2019-05-20 10:11:53 +02:00
sundy-li
66c60c2985 better tests 2019-05-20 12:31:52 +08:00
sundy-li
6843254ce4 Make sequenceMatch support other unsigned integer types 2019-05-20 12:02:54 +08:00
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Danila Kutenin
295a4a8684
Merge pull request #5330 from yandex/format_function
Format function added
2019-05-19 12:07:57 +03:00
Danila Kutenin
ed588bf727 style 2019-05-19 03:39:44 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
2f471d6ea3
Set allocatesMemoryInArena for SingleValueDataString to true
This includes next aggregate functions for String() type:
- *min*
- *max*
- *any*
2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
2254b171a7
Merge pull request #5313 from yandex/fix-external-query-in-with-single-element
Fix external queries with IN operator.
2019-05-19 03:12:57 +03:00
Danila Kutenin
876b5c3bbb style 2019-05-19 02:21:29 +03:00
Alexey Milovidov
648d2bdb25 Fixed test 2019-05-19 01:19:24 +03:00
alexey-milovidov
e73fc1bd0f
Merge pull request #5320 from sundy-li/feature/funnel64
Make windowFunnel support other Unsigned Integer Types
2019-05-18 23:47:12 +03:00
Danila Kutenin
fca6e4fd38 constant string handling 2019-05-18 18:09:52 +03:00
Danila Kutenin
95cd3e5bb8 style 2019-05-18 16:38:03 +03:00
Danila Kutenin
1c6707526a style 2019-05-18 16:21:48 +03:00
Danila Kutenin
59f26b7569 some optimizations 2019-05-18 15:56:26 +03:00
Danila Kutenin
a49ee5efd6 some optimizations 2019-05-18 15:52:33 +03:00
Danila Kutenin
84b04dc8ea format function added 2019-05-18 15:29:10 +03:00
Danila Kutenin
a48cf9abe5 format function added 2019-05-18 14:30:50 +03:00
Danila Kutenin
4e3a607267 format function added 2019-05-18 14:30:36 +03:00
alexey-milovidov
dc5232d40d
Update Server.cpp 2019-05-18 13:17:26 +03:00
alexey-milovidov
24b16da9fd
Merge pull request #5235 from vitlibar/improve-new-json-functions
Improve new json functions
2019-05-18 12:51:41 +03:00
alexey-milovidov
c2132880f6
Update WriteBufferFromVector.h 2019-05-18 12:43:43 +03:00
alexey-milovidov
7985ad10ef
Update IStorage.h 2019-05-18 12:31:51 +03:00
sundy-li
dcfdc09003 fix style 2019-05-18 09:34:55 +08:00
alexey-milovidov
fa4a7eb3d1
Merge branch 'master' into merge-itable-istorage 2019-05-18 00:37:12 +03:00
alexey-milovidov
8bf48de9c9
Merge pull request #5308 from abyss7/issue-5100
Add setting to regulate Kafka committing policy
2019-05-18 00:27:19 +03:00
alexey-milovidov
8b9b305a5f
Merge pull request #5325 from abyss7/issue-5286
Allow to shadow virtual column '_table' in Merge engine
2019-05-18 00:17:34 +03:00
alexey-milovidov
34f36e2891
Merge pull request #5304 from 4ertus2/funcs
Support quantile(s) and median for Decimal
2019-05-17 23:03:27 +03:00
Danila Kutenin
e0b90de474
Merge pull request #5322 from yandex/to_valid_utf8
toValidUTF8 function added
2019-05-17 22:48:32 +03:00
Ivan Lezhankin
dcff73c8d4 Fix build 2019-05-17 21:45:42 +03:00
Ivan Lezhankin
7b6c78402d Allow to shadow virtual column '_table' in Merge engine 2019-05-17 20:40:51 +03:00
Ivan Lezhankin
7f762aee88 Move some code from header to source file. 2019-05-17 17:48:03 +03:00
Ivan Lezhankin
0821d62516 Merge ITableDeclaration into IStorage.
Also a couple of massive include-refactorings with better forwarding
2019-05-17 17:34:25 +03:00
Vitaly Baranov
095fc7b454 Optimization by using implementation-specific JSONParser::sizeOfArray(), JSONParser::sizeOfObject(). 2019-05-17 17:24:13 +03:00
Danila Kutenin
64913c4778 better names 2019-05-17 16:00:29 +03:00
Yuriy
4a14eac00b fixed memory leak and changed logging levels 2019-05-17 16:00:09 +03:00
Danila Kutenin
0d3422fa8a toValidUTF8 function added 2019-05-17 15:55:21 +03:00
alesapin
7a9dfbbb53 More stable perf tests 2019-05-17 14:42:41 +03:00
sundy-li
cbaca96926 remove spaces 2019-05-17 19:41:18 +08:00
sundy-li
4c95b9d007 modify createAggregateFunctionWindowFunnel 2019-05-17 19:31:29 +08:00
sundy-li
d3c4c1c255 modify createAggregateFunctionWindowFunnel 2019-05-17 19:30:09 +08:00
sundy-li
760bc5708d support unsigned integer type in windowFunnel Aggregate function 2019-05-17 19:17:52 +08:00
Artem Zuikov
4eee10d788
Merge pull request #5271 from 4ertus2/some
Cache ExpressionBlockInputStream header
2019-05-17 13:14:22 +03:00
alexey-milovidov
1707cd79c8
Merge pull request #5297 from github1youlc/xid_equal_to_close_xid_deadlock_fix
fix deadlock when xid equal to close_xid
2019-05-17 11:45:35 +03:00