Commit Graph

117540 Commits

Author SHA1 Message Date
Alexander Tokmakov
dc0a224f52 fix 2023-06-15 15:05:17 +02:00
avogar
870f3d1270 Fix comments 2023-06-15 12:59:46 +00:00
Mikhail f. Shiryaev
2ac95ccfce
Adjust version_helper test cases to proper tags 2023-06-15 14:48:10 +02:00
Mikhail f. Shiryaev
07203a4542
Fix a versions' tweak for tagged commits, improve version_helper 2023-06-15 14:48:09 +02:00
Kseniia Sumarokova
c15e7b93cb
Merge pull request #50976 from kssenii/fix-data-lakes-too-many-head-requests
Fix data lakes slowness because of synchronous head requests
2023-06-15 13:33:09 +02:00
Dan Roscigno
ee9faa9be1
Merge pull request #50968 from DerekChia/patch-3
Update delete.md
2023-06-15 07:06:49 -04:00
Kseniia Sumarokova
31e08635bf
Merge branch 'master' into unify-priorities-pools 2023-06-15 12:51:45 +02:00
Alexander Tokmakov
6fc9479730
Update settings.md (#51007) 2023-06-15 13:51:42 +03:00
Igor Nikonov
1113a7c524
Merge pull request #50214 from azat/parallelize_output_from_storages-fix
Disable parallelize_output_from_storages for processing MATERIALIZED VIEWs and storages with one block only
2023-06-15 12:48:54 +02:00
Kseniia Sumarokova
b7fbc4dd8e
Merge pull request #50977 from valbok/empty-table-overrides
MaterializedMySQL: Keep parentheses for empty table overrides
2023-06-15 12:48:04 +02:00
Kseniia Sumarokova
58650b3280
Merge pull request #51002 from ClickHouse/Avogar-patch-1
Fix flaky test_seekable_formats
2023-06-15 12:46:04 +02:00
Kseniia Sumarokova
f1f8b302bf
Merge pull request #50934 from azat/tests/fix-query_log
Fix tests sanity checks and avoid dropping system.query_log table
2023-06-15 12:44:23 +02:00
Alexander Tokmakov
f73a3cf255
Merge pull request #50924 from valbok/missing-drops
MaterializedMySQL: Add missing DROP DATABASE for tests
2023-06-15 13:33:28 +03:00
Alexander Tokmakov
a018d9ca11 try to fix false-positive 'part is lost forever' 2023-06-15 12:25:16 +02:00
Kruglov Pavel
7aea4a1f10
Merge branch 'master' into allow-skip-empty-files 2023-06-15 12:07:24 +02:00
Robert Schulze
946e1a8c6f
Merge pull request #50966 from arenadata/ADQM-934
clickhouse-client: Force that `--password` is specified at most once
2023-06-15 11:14:26 +02:00
Antonio Andelic
c1faf42481
Merge pull request #50967 from baibaichen/feature/fix_build_clang15
fix build issue on clang 15
2023-06-15 10:32:38 +02:00
Kseniia Sumarokova
c786fbf8bd
Add comment 2023-06-15 10:22:02 +02:00
Victor Krasnov
bd16233263 Add more clear remarks to the test 2023-06-15 11:17:13 +03:00
Victor Krasnov
c899f6b68d Use int the test explicit date_add() and date_sub() instead of + and -. 2023-06-15 11:12:22 +03:00
Victor Krasnov
72ef15e03f Shrink the test half-interval to a minute 2023-06-15 11:04:15 +03:00
Victor Krasnov
fe0bc992bf Move the reference time point to the border of June 2023-06-15 10:58:24 +03:00
Victor Krasnov
5026e0f492 Tackle the test's flakiness 2023-06-15 10:47:22 +03:00
Victor Krasnov
11dfd35cd7 Amend the docs following the reviewer's pointers 2023-06-15 10:45:18 +03:00
Kseniia Sumarokova
c8619ee6e4
Merge pull request #50974 from kssenii/iceberg-metadata-fix
Fix iceberg V2 optional metadata parsing
2023-06-15 09:31:36 +02:00
KevinyhZou
953f40aa3b
Merge branch 'master' into bug_fix_csv_parse_by_tab_delimiter 2023-06-15 10:25:19 +08:00
Alexey Milovidov
a13db6a5ec
Merge pull request #50958 from den-crane/patch-51
Doc. Note about supported docker version
2023-06-15 01:58:18 +03:00
pufit
e2b9f59e1e
Merge pull request #50965 from ClickHouse/pufit/keeper-client-better-help-message
Fix keeper-client help message
2023-06-14 18:42:26 -04:00
Dan Roscigno
bd6744982b
Merge pull request #51009 from DanRoscigno/update-cl-ru
catch ru changelog up to 2023
2023-06-14 18:41:21 -04:00
Dan Roscigno
1dfbfd9018
Merge pull request #51010 from ClickHouse/DanRoscigno-patch-5
Update gcs.md
2023-06-14 18:40:50 -04:00
Alexey Gerasimchuck
75e6b4475d corrections after review 2023-06-14 22:35:38 +00:00
Alexey Gerasimchuck
a6420ee338
Merge branch 'master' into ADQM-934 2023-06-15 08:25:24 +10:00
Michael Kolupaev
badde0fde2 Print git hash when crashing 2023-06-14 15:22:44 -07:00
Denny Crane
93e0e2c7cf
Update mergetree.md 2023-06-14 19:04:20 -03:00
Dan Roscigno
e75cb90b7d
Update gcs.md
fix nav

closes https://github.com/ClickHouse/clickhouse-docs/issues/1230
2023-06-14 17:56:34 -04:00
DanRoscigno
005e7d3b27 Chinese also 2023-06-14 17:40:29 -04:00
DanRoscigno
40d4508a72 catch ru changelog up to 2023 2023-06-14 17:32:03 -04:00
Denny Crane
c142ed8a06
Merge branch 'master' into patch-51 2023-06-14 17:39:00 -03:00
Thomas Panetti
dbdf77ce51
Merge branch 'master' into mysql_compatible_types 2023-06-14 13:05:54 -07:00
tpanetti
87904976ed Fix test for MySQL Compatible Types (suppress password warning) 2023-06-14 13:05:38 -07:00
Jiebin Sun
fcadb851c8
Maintain per-thread timer_id rather than create/delete frequently (#48778)
* Maintain per-thread timer_id rather than create/delete frequently

The QueryProfiler will frequently create/delete timer_id globally, which
will result in heavy kernel lock contention.
The idea is to maintain thread-local timer_id. Before create the
timer_id, it should check whether there is a timer_id already. And we
could stop the timer by timer_settime() rather than delete the timer_id
with timer_delete().

Apply the patch and run clickbench on latest 65d671b7c7 ClickHouse with
SPR 112 x 2 vCPUs. Query 4, 0, 5, 3, 15, 32 have 17.5%, 14.4%, 8.3%, 7.9%,
7.1%, 5.8% performance gain. The overall geomean has got 2.5%
performance gain.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Pack the timer and delete the timer_id when thread terminates

Pack the timer and related methods into the class. Delete the timer_id
when the thread terminates.

According to the issue (ClickHouse#49965),
all of the SSB queries benefit from this optimization, some have even got
improved by ~30% and the overall QPS could be significantly improved by ~18%.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Update src/Common/QueryProfiler.cpp

Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

* Update src/Common/QueryProfiler.cpp

Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

* Fix the review issue of QueryProfiler Timer from PR
https://github.com/ClickHouse/ClickHouse/pull/48778.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Update src/Common/QueryProfiler.cpp

Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>

* Add two separate CurrentMetrics for created and active timers
in QueryProfiler.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

---------

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-06-14 21:22:09 +02:00
Vitaly Baranov
6366940a37 Use hash_of_all_files from system.parts to check identity of parts during on-cluster backups. 2023-06-14 20:39:50 +02:00
Igor Nikonov
ea46ba0d05
Merge branch 'master' into parallelize_output_from_storages-fix 2023-06-14 19:54:55 +02:00
Igor Nikonov
145f7c928e Use CLICKHOUSE_TEST_UNIQUE_NAME for data file
+ comment
2023-06-14 17:48:40 +00:00
Kruglov Pavel
bb7ec69b90
Fix flaky test_seekable_formats 2023-06-14 19:38:03 +02:00
robot-ch-test-poll3
c96f0c9f2f
Merge pull request #50992 from ClickHouse/thomoco-patch-4
Update mysql.md
2023-06-14 19:30:37 +02:00
robot-ch-test-poll3
d36c6ae870
Merge pull request #50988 from ClickHouse/thomoco-patch-3
Update postgresql.md
2023-06-14 19:30:11 +02:00
Igor Nikonov
df1d16a165 Fix flaky 02561_null_as_default_more_formats 2023-06-14 17:11:10 +00:00
Sergei Trifonov
170e17c9e8
Merge pull request #50935 from azat/tests/02703_max_local_write_bandwidth 2023-06-14 18:54:49 +02:00
Thomas Panetti
18fb4fbc15
Merge branch 'master' into mysql_compatible_types 2023-06-14 09:52:28 -07:00